From: Will Deacon <will@kernel.org>
To: Mark Rutland <mark.rutland@arm.com>
Cc: Janne Grunau <j@jannau.net>,
linux-arm-kernel@lists.infradead.org, asahi@lists.linux.dev,
ecurtin@redhat.com, lina@asahilina.net,
linux-kernel@vger.kernel.org, peterz@infradead.org,
ravi.bangoria@amd.com
Subject: Re: [PATCH 1/2] arm_pmu: fix event CPU filtering
Date: Thu, 16 Feb 2023 15:17:19 +0000 [thread overview]
Message-ID: <20230216151718.GA21275@willie-the-truck> (raw)
In-Reply-To: <Y+5IByR9RelBDm2+@FVFF77S0Q05N.cambridge.arm.com>
On Thu, Feb 16, 2023 at 03:13:11PM +0000, Mark Rutland wrote:
> On Thu, Feb 16, 2023 at 03:35:19PM +0100, Janne Grunau wrote:
> > On 2023-02-16 14:12:38 +0000, Mark Rutland wrote:
> > > Fix the CPU filtering by performing this consistently in
> > > armpmu_filter(), and remove the redundant arm_pmu::filter() callback and
> > > armv8pmu_filter() implementation.
> > >
> > > Commit bd2756811766 also silently removed the CHAIN event filtering from
> > > armv8pmu_filter(), which will be addressed by a separate patch without
> > > using the filter callback.
>
> [...]
>
> > This works as well. I limited the patch to the minimal fix this
> > this late in the cycle.
>
> I did appreciate that you'd made the effort for the minimal fix; had the issue
> with CHAIN events not existed I would have acked that as-is and done the
> simplification later. Given the CHAIN issue and given the simplification make
> the code "obviously correct" I think it's preferable to do both bits now.
>
> > Tested-by: Janne Grunau <j@jannau.net>
>
> Thanks!
>
> Hopefully Will or Peter can pick this up shortly; I'm assuming that Will can
> take this via the arm64 tree.
I'll grab 'em.
Will
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-02-16 15:18 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-16 14:12 [PATCH 0/2] arm_pmu: fix fallout from context handling rewrite Mark Rutland
2023-02-16 14:12 ` [PATCH 1/2] arm_pmu: fix event CPU filtering Mark Rutland
2023-02-16 14:35 ` Janne Grunau
2023-02-16 15:13 ` Mark Rutland
2023-02-16 15:17 ` Will Deacon [this message]
2023-02-16 14:12 ` [PATCH 2/2] arm64: perf: reject CHAIN events at creation time Mark Rutland
2023-02-16 22:14 ` [PATCH 0/2] arm_pmu: fix fallout from context handling rewrite Will Deacon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230216151718.GA21275@willie-the-truck \
--to=will@kernel.org \
--cc=asahi@lists.linux.dev \
--cc=ecurtin@redhat.com \
--cc=j@jannau.net \
--cc=lina@asahilina.net \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=peterz@infradead.org \
--cc=ravi.bangoria@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox