From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 53E89C05027 for ; Fri, 17 Feb 2023 16:33:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=FF8CmOcA+VECf5FZQJ+mxu2xxjtyF83Ig6C3UjwUJMU=; b=gdsPkRl6iIIQmr p4bi/T8O4E+hOfynZrw19xK+7mqFmfaTegxjQ3b21P4H/wikr71VDAJD7RxNLLxFmbgMsYn9MmekL LBHNgLW052MShQoJ3n4CVthoGJm9VcDfmrsTpo2pZpAXsD1nC1rCCMx1GAzqRvxxfvGREAqvv3aUn dor/qRKFaXf0bzFt2qnY6RFcvzhTA/JFgMm/6pjjszkoBN/vGbXdQ0t1eW+ZCweaVgC53jJdljKrm ujTfh/gNPvpv3eV/f7qMLeTKvlH7yLNrQpWjBU3/fh+A2LmcXbqK+i5m3oNEjC4zqtb427o1JIZB0 DYNFupTgj09wtgD43WMg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pT3fM-00F4z3-1z; Fri, 17 Feb 2023 16:32:56 +0000 Received: from mail.andi.de1.cc ([2a01:238:4321:8900:456f:ecd6:43e:202c]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pT3eK-00F4XG-Q6 for linux-arm-kernel@lists.infradead.org; Fri, 17 Feb 2023 16:31:55 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=kemnade.info; s=20220719; h=Content-Transfer-Encoding:Content-Type: MIME-Version:References:In-Reply-To:Message-ID:Subject:Cc:To:From:Date:Sender :Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help: List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=fdyKvwYgQMyYOvs0tXMattzjV5AJbXrXbx9GVNi92gc=; b=rB70gVJYdKjUfB2yk/iVq2XOG1 Kgz5TPxBW/7arPV6XSZz1yZ12auLu2TXIoaD7K1FW7uVqa7Wsyapj81K0uh4ETQJe0YucyxwXfZpy JAWsOqemDPnYuCoYmLLtqw4gPH5njmPZcee71RnsRhqjJqZk5RvQeRKNKHrtD7lssDjdYV5n1amOe eKJ4MgDUEax7LfqUoDPNYve/gQX9vV9j0+WlUmBSa9sdoJQdCjuzI1JKc36+uMNZ3/Ue/j/mXAhwL UCjZUecALDmF/lsNq1WZWU3DfsBUsTMeVWxjcMsU5G8HWJEn2M+viihT0izK/FZKldRpU0JBFzo8l N5Mx9YRg==; Received: from p200300ccff0dfd001a3da2fffebfd33a.dip0.t-ipconnect.de ([2003:cc:ff0d:fd00:1a3d:a2ff:febf:d33a] helo=aktux) by mail.andi.de1.cc with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1pT3de-00064j-S3; Fri, 17 Feb 2023 17:31:11 +0100 Date: Fri, 17 Feb 2023 17:31:08 +0100 From: Andreas Kemnade To: Tony Lindgren Cc: Linus Walleij , Mun Yew Tham , Bartosz Golaszewski , Joel Stanley , Andrew Jeffery , Alban Bedel , Orson Zhai , Baolin Wang , Chunyan Zhang , Jay Fang , Daniel Palmer , Romain Perier , Grygorii Strashko , Santosh Shilimkar , Kevin Hilman , William Breathitt Gray , linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, linux-omap@vger.kernel.org, Marc Zyngier Subject: Re: [PATCH 15/17] gpio: omap: Convert to immutable irq_chip Message-ID: <20230217173108.1448ce92@aktux> In-Reply-To: References: <20230215-immutable-chips-v1-0-51a8f224a5d0@linaro.org> <20230215-immutable-chips-v1-15-51a8f224a5d0@linaro.org> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230217_083153_058440_B12D1603 X-CRM114-Status: GOOD ( 18.80 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, 17 Feb 2023 09:49:37 +0200 Tony Lindgren wrote: > Hi, > > * Linus Walleij [230216 09:38]: > > Convert the driver to immutable irq-chip with a bit of > > intuition. > > > > This driver require some special care: .irq_ack() was copied > > from dummy_irq_chip where it was defined as noop. This only > > makes sense if using handle_edge_irq() that will unconditionally > > call .irq_ack() to avoid a crash, but this driver is not ever > > using handle_edge_irq() so just avoid assigning .irq_ack(). > > > > A separate chip had to be created for the non-wakeup instance. > > Nice, works for me. > > BTW, I still see these warnings remaining on boot: > > gpio gpiochip0: Static allocation of GPIO base is deprecated, use dynamic allocation. > > Seems like we might be able to get rid of those too now or are > there still some dependencies with /sys/class/gpio for example? > on what are you testing? on -next? I thought I have fixed theese warning with https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=92bf78b33b0b463b00c6b0203b49aea845daecc8 Regards, Andreas _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel