From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CEAA2C636CC for ; Sun, 19 Feb 2023 13:23:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=D1JY01TdlC+8NvSxulMw52cpXwLGRIeZWFT4FzmLYa8=; b=B6YbDUW8CBbMAS l6HRTW0N6IQ3yPrLVnjXXRhGf4OJgdNTXuRakN4qJLSJ+MoziBVZXhcOlmI28Bwi6qhAn09GOkdqH v6HXDs12U5diBFOjTKau9BVZhRJ/bDlZadUW+T/8qDNSz7QNKe/C74LlCXkCjDc+IJYhewxRXP9TM 58rVl1tUp3+V6cmmJeap1mAPXNByYzmW7XB2PJV6SqJYIjhJ48I3q958dyEeaCAc41ggIfwK7mWE9 9EvJgrRx3gPGuOkzexB7xg9dE/M7ovVLYuUu2rYV1W8By9VDJGiKk4UWZhZp1ipcby/iP97dLqg07 JWFx84q0p8e8jQxUnGIg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pTje3-001YxB-Lb; Sun, 19 Feb 2023 13:22:23 +0000 Received: from soltyk.jannau.net ([144.76.91.90]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pTjdw-001YvM-3v for linux-arm-kernel@lists.infradead.org; Sun, 19 Feb 2023 13:22:22 +0000 Received: by soltyk.jannau.net (Postfix, from userid 1000) id D1D5A26F7B6; Sun, 19 Feb 2023 14:22:08 +0100 (CET) Date: Sun, 19 Feb 2023 14:22:08 +0100 From: Janne Grunau To: Sven Peter Cc: Hector Martin , Alyssa Rosenzweig , Rob Herring , Krzysztof Kozlowski , Mark Kettenis , asahi@lists.linux.dev, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 16/16] arm64: dts: apple: t8112: Initial t8112 (M2) device trees Message-ID: <20230219132208.GA32724@jannau.net> References: <20230202-asahi-t8112-dt-v2-0-22926a283d92@jannau.net> <20230202-asahi-t8112-dt-v2-16-22926a283d92@jannau.net> <8303bbae-2f98-49fb-8fd6-550ecb272bae@app.fastmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <8303bbae-2f98-49fb-8fd6-550ecb272bae@app.fastmail.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230219_052216_350090_56B759EE X-CRM114-Status: GOOD ( 26.08 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 2023-02-19 13:36:22 +0100, Sven Peter wrote: > Hi, > > > On Tue, Feb 14, 2023, at 12:03, Janne Grunau wrote: > > From: Hector Martin > > > > This adds device trees for the following devices: > > - Macbook Air (M2, 2022) > > - Macbook Pro 13" (M2, 2022) > > - Mac mini (M2, 2023) > > > > Signed-off-by: Hector Martin > > Co-developed-by: Janne Grunau > > Signed-off-by: Janne Grunau > > --- > > arch/arm64/boot/dts/apple/Makefile | 3 + > > arch/arm64/boot/dts/apple/t8112-j413.dts | 63 ++ > > arch/arm64/boot/dts/apple/t8112-j473.dts | 54 ++ > > arch/arm64/boot/dts/apple/t8112-j493.dts | 52 ++ > > arch/arm64/boot/dts/apple/t8112-jxxx.dtsi | 81 ++ > > arch/arm64/boot/dts/apple/t8112-pmgr.dtsi | 1141 +++++++++++++++++++++++++++++ > > arch/arm64/boot/dts/apple/t8112.dtsi | 912 +++++++++++++++++++++++ > > 7 files changed, 2306 insertions(+) > > > > diff --git a/arch/arm64/boot/dts/apple/Makefile > > b/arch/arm64/boot/dts/apple/Makefile > > index 5a7506ff5ea3..aec5e29cdfb7 100644 > > --- a/arch/arm64/boot/dts/apple/Makefile > > +++ b/arch/arm64/boot/dts/apple/Makefile > > @@ -10,3 +10,6 @@ dtb-$(CONFIG_ARCH_APPLE) += t6000-j316s.dtb > > dtb-$(CONFIG_ARCH_APPLE) += t6001-j316c.dtb > > dtb-$(CONFIG_ARCH_APPLE) += t6001-j375c.dtb > > dtb-$(CONFIG_ARCH_APPLE) += t6002-j375d.dtb > > +dtb-$(CONFIG_ARCH_APPLE) += t8112-j413.dtb > > +dtb-$(CONFIG_ARCH_APPLE) += t8112-j473.dtb > > +dtb-$(CONFIG_ARCH_APPLE) += t8112-j493.dtb > > diff --git a/arch/arm64/boot/dts/apple/t8112-j413.dts > > b/arch/arm64/boot/dts/apple/t8112-j413.dts > > new file mode 100644 > > index 000000000000..9e758edeaa82 > > --- /dev/null > > +++ b/arch/arm64/boot/dts/apple/t8112-j413.dts > > @@ -0,0 +1,63 @@ > > +// SPDX-License-Identifier: GPL-2.0+ OR MIT > > +/* > > + * Apple MacBook Air (M2, 2022) > > + * > > + * target-type: J413 > > + * > > + * Copyright The Asahi Linux Contributors > > + */ > > + > > +/dts-v1/; > > + > > +#include "t8112.dtsi" > > +#include "t8112-jxxx.dtsi" > > + > > +/ { > > + compatible = "apple,j413", "apple,t8112", "apple,arm-platform"; > > + model = "Apple MacBook Air (13-inch, M2, 2022)"; > > + > > + aliases { > > + bluetooth0 = &bluetooth0; > > + wifi0 = &wifi0; > > + }; > > +}; > > + > > +/* > > + * Force the bus number assignments so that we can declare some of the > > + * on-board devices and properties that are populated by the bootloader > > + * (such as MAC addresses). > > + */ > > +&port00 { > > + bus-range = <1 1>; > > + wifi0: wifi@0,0 { > > + compatible = "pci14e4,4433"; > > I'm not sure how these pci compatibles are usually handled. Do they have to > be added to the dt-bindings Documentation as well or is it fine to just have them > here since they're not really used to match anything? I suppose they have to be added (at least for dtb validation) but "pci14e4,4433" is already in net/wireless/brcm,bcm4329-fmac.yaml. Added via e2e37224e8b3 ("dt-bindings: net: bcm4329-fmac: Add Apple properties & chips"). Janne _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel