From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CA77EC64EC7 for ; Mon, 20 Feb 2023 19:46:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=EK7CS7G7moin2oK8rds3D0DbXjednvQiZFS2RAmMbx8=; b=t9T1CbpLTNo56y ZNGlfxh+wENm/hCYcpIagt8+FFFwkO+cCGR1qnG5Er3XH1CWbjjrknT2yWe7Ckc86Hq2UekixhbHv L79mwB/FGcCu9CSB9h/lXgI+R2RK+GbUEKkRZHccnhnHHj/jZ0CUUPgrY/owEU1saPj2hYtw+qm9Z 7fajTylJr6S3a7O8uJcMrjkJSyJFr3r8JTs9NOKOSiVFZofPhtMEmDVS8EVnzKx96x8ePvb9suG1b wo+4CcyYU96IpGKK7/eCqOwKPJJ4/iAtJUFeJfVzPFh11vl48XuRCCl/Jx0uZrO9XX2FDNjo95hjA CIVisVIAm15Gie5sJNOg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pUC5i-005Ouk-P9; Mon, 20 Feb 2023 19:44:50 +0000 Received: from mail-wm1-x32a.google.com ([2a00:1450:4864:20::32a]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pUC5d-005Osy-Og for linux-arm-kernel@lists.infradead.org; Mon, 20 Feb 2023 19:44:48 +0000 Received: by mail-wm1-x32a.google.com with SMTP id o4-20020a05600c4fc400b003e1f5f2a29cso1937856wmq.4 for ; Mon, 20 Feb 2023 11:44:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20210112.gappssmtp.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=fx6Cy3cfwtLc2tIkcYv2b/6D80WxggLsKcXv+WH52kA=; b=Yzr32MycoFefeV/s5hGlruGe4mCnnO/LjwL2l8oZAJaeg9M+kOHt1A9JP6b1LjIyJi ZBD3GzBYVzqpXOzA3eq3W8nKGr2ZmAInCdp7lNPsuDhiFIj36DJQwsxsKpXid7dL/CrC q20SDqdEx6TDdM9x0EiMagmv4/BH/htFIVWRX+1T43WRniojzL/kkSmMdIMFFL5L3Zsi SBLziUP+GmnAbXFaUGfaERO3oS000f9I5alU8bLG13OlhF+YHbL+RHuY42AB711IPh5k 2AUqcRNZ6kXtZcAB40EMv2yQGV/OiOpU97JgraWxzEGL+CSDxP+1SrMlSf4q2/vggpXy vXrQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=fx6Cy3cfwtLc2tIkcYv2b/6D80WxggLsKcXv+WH52kA=; b=oj/GOfqFU8+no6Ty2aS83GAnAebO5T41Wz9wejERqj75WuSdZH2ab3KMmffPPEt/bK EY/BQg4+L3KKyGeEPi4uRJH/bdjIK++qMN213X/my92p1WEedxGYEr8Mn+EBxcnJkR2r PMeailfrpCPsplBzMLEkfaUjT4T9YQjuxuqZNzhSjJgBqeak4qx1ogeI6/MIC3aOUuTI JPGnNnGNaMZ+d04BNL7eJeHvERCmutwiE+lAAD4nhv6Whvyn+pLSGXgTOyVscQWR1z1F CFeemMZ4c14uKs4w1XeF+OR1u1yZpQJ2+ZgF+icKmTeqKVdoOP/PpaVXD3RiDkmYZcTD HrOw== X-Gm-Message-State: AO0yUKU4ayRKMe2clC3Zjo/Ot3IDkNbnlBkMtPNdsaMBjTUmwI7AK/93 hu2owyA98TqKmYWNbKgiWsaUBw== X-Google-Smtp-Source: AK7set81wWp/nPh3uqn5YDsno1xkj3omzQM9DY1JIhAnX8EuPDIa6IJRQOWOHx81vBlsHWmBpa7Bkw== X-Received: by 2002:a05:600c:4f44:b0:3e1:df8d:e022 with SMTP id m4-20020a05600c4f4400b003e1df8de022mr1754669wmq.9.1676922282285; Mon, 20 Feb 2023 11:44:42 -0800 (PST) Received: from blmsp ([2001:4090:a247:8056:be7d:83e:a6a5:4659]) by smtp.gmail.com with ESMTPSA id s10-20020a7bc38a000000b003dc1a525f22sm14871414wmj.25.2023.02.20.11.44.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Feb 2023 11:44:41 -0800 (PST) Date: Mon, 20 Feb 2023 20:44:41 +0100 From: Markus Schneider-Pargmann To: Matthias Brugger Cc: Rob Herring , Krzysztof Kozlowski , Chun-Jie Chen , AngeloGioacchino Del Regno , Fabien Parent , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, Fabien Parent Subject: Re: [PATCH 8/8] soc: mediatek: pm-domains: Add support for MT8365 Message-ID: <20230220194441.2564ct25qsxvvvic@blmsp> References: <20230105170735.1637416-1-msp@baylibre.com> <20230105170735.1637416-9-msp@baylibre.com> <07a16be1-3f96-374c-3a9b-e3920bb4b437@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <07a16be1-3f96-374c-3a9b-e3920bb4b437@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230220_114446_034288_3931567B X-CRM114-Status: GOOD ( 24.14 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Matthias, On Fri, Feb 03, 2023 at 01:22:38PM +0100, Matthias Brugger wrote: > > > On 05/01/2023 18:07, Markus Schneider-Pargmann wrote: > > From: Fabien Parent > > > > Add the needed board data to support MT8365 SoC. > > > > Signed-off-by: Fabien Parent > > Signed-off-by: Markus Schneider-Pargmann > > --- > > drivers/soc/mediatek/mt8365-pm-domains.h | 147 +++++++++++++++++++++++ > > drivers/soc/mediatek/mtk-pm-domains.c | 5 + > > 2 files changed, 152 insertions(+) > > create mode 100644 drivers/soc/mediatek/mt8365-pm-domains.h > > > > diff --git a/drivers/soc/mediatek/mt8365-pm-domains.h b/drivers/soc/mediatek/mt8365-pm-domains.h > > new file mode 100644 > > index 000000000000..8735e833b15b > > --- /dev/null > > +++ b/drivers/soc/mediatek/mt8365-pm-domains.h > > @@ -0,0 +1,147 @@ > > +/* SPDX-License-Identifier: GPL-2.0-only */ > > + > > +#ifndef __SOC_MEDIATEK_MT8365_PM_DOMAINS_H > > +#define __SOC_MEDIATEK_MT8365_PM_DOMAINS_H > > + > > +#include "mtk-pm-domains.h" > > +#include > > + > > +/* > > + * MT8365 power domain support > > + */ > > + > > +static const struct scpsys_domain_data scpsys_domain_data_mt8365[] = { > > + [MT8365_POWER_DOMAIN_MM] = { > > + .name = "mm", > > + .sta_mask = PWR_STATUS_DISP, > > + .ctl_offs = 0x30c, > > + .pwr_sta_offs = 0x0180, > > + .pwr_sta2nd_offs = 0x0184, > > + .sram_pdn_bits = GENMASK(8, 8), > > + .sram_pdn_ack_bits = GENMASK(12, 12), > > + .caps = MTK_SCPD_STRICT_BUS_PROTECTION | MTK_SCPD_HAS_WAY_EN, > > + .bp_infracfg = { > > + BUS_PROT_WR(BIT(16) | BIT(17), 0x2a8, 0x2ac, 0x258), > > + BUS_PROT_WR(BIT(1) | BIT(2) | BIT(10) | BIT(11), 0x2a0, 0x2a4, 0x228), > > + BUS_PROT_WAY_EN(BIT(6), 0x200, BIT(24), 0x0), > > + BUS_PROT_WAY_EN(BIT(5), 0x234, BIT(14), 0x28), > > + BUS_PROT_WR(BIT(6), 0x2a0, 0x2a4, 0x228), > > > BUS_PROT_WR(BIT(6), 0x2a0, 0x2a4, 0x228) repeates several times in the > definition. Would it make sense to create a new define like we did with > BUS_PROT_UPDATE_TOPAXI()? Are this offests are used in other SoCs. > > In any case instead of magic numbers the values should be defined in > include/linux/soc/mediatek/infracfg.h or appropiate header files. Thanks, you are right, I got rid of all the magic numbers and introduced some helper defines as well. Thank you, Markus _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel