From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 28D31C636D6 for ; Wed, 22 Feb 2023 13:17:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:CC:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=SqfFm9eRN0PPF518Y1LisFiYg2Gr+br8CL8YvVF4m2c=; b=QDxtFYhcrkt2b7 OGM9vz6lMhwKVmC7DZJ/MlJ7G4ewAyJTtVTcoYlJ7iAKsurO4GuKx3S1AdN2LMKPh9kZEXZE6v6YH gCs2ElIEh3XZ6GTfGBeyYAU3AYo2vUxEE5t/KB3UITKbCnWgW/En4/3oC4cWnt/QNBoB8ZG7cnD7A Pl8QFsJAt5I95e9Kj/NycxljrdMOFvtB9XOEcemZLadrZ7IpDWgiwicVmNinRHwc2WBkIYTT/ElhB MrmpJ28YN5OTwDqSyijOln10K/oSAlocSTL8arfIS309Q1zfQEATL281Opq2zAOpdNYAuTX5WS2ok kIpy7W29x8G8V+ZcZQdQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pUoyo-00CUyl-9D; Wed, 22 Feb 2023 13:16:18 +0000 Received: from fllv0016.ext.ti.com ([198.47.19.142]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pUoyk-00CUxo-4i for linux-arm-kernel@lists.infradead.org; Wed, 22 Feb 2023 13:16:16 +0000 Received: from fllv0035.itg.ti.com ([10.64.41.0]) by fllv0016.ext.ti.com (8.15.2/8.15.2) with ESMTP id 31MDFxnp113410; Wed, 22 Feb 2023 07:15:59 -0600 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1677071759; bh=hD52NgGyIxcH+/PIi7CS0t2PfjHjhrKYf0n1At3rXj4=; h=Date:From:To:CC:Subject:References:In-Reply-To; b=A6kApQgYAguYcRVJXgjC/uQ5wT3p1B8YFodt7GXl1iUHprmZPlNa49YnCapg7FOmX sEGvO+g3rgVvY4LGmHcXK72AUZBH3q1X9VAHZp5/sS1QPz9Q5oLOf22YMT7fh0la1s HhbNFECRMa7kmY3sePI17pRDlrLJhkr5mLGaVJ/k= Received: from DFLE108.ent.ti.com (dfle108.ent.ti.com [10.64.6.29]) by fllv0035.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 31MDFx3T083692 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Wed, 22 Feb 2023 07:15:59 -0600 Received: from DFLE110.ent.ti.com (10.64.6.31) by DFLE108.ent.ti.com (10.64.6.29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.16; Wed, 22 Feb 2023 07:15:59 -0600 Received: from fllv0040.itg.ti.com (10.64.41.20) by DFLE110.ent.ti.com (10.64.6.31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.16 via Frontend Transport; Wed, 22 Feb 2023 07:15:59 -0600 Received: from localhost (ileaxei01-snat.itg.ti.com [10.180.69.5]) by fllv0040.itg.ti.com (8.15.2/8.15.2) with ESMTP id 31MDFxVx104054; Wed, 22 Feb 2023 07:15:59 -0600 Date: Wed, 22 Feb 2023 07:15:59 -0600 From: Nishanth Menon To: Ravi Gunasekaran CC: , , , , , , , , Subject: Re: [PATCH v10 2/9] arm64: dts: ti: k3-j721s2-main: Add support for USB Message-ID: <20230222131559.day4frfvjuje25i4@suffrage> References: <20230221120612.27366-1-r-gunasekaran@ti.com> <20230221120612.27366-3-r-gunasekaran@ti.com> <20230221135852.n3yukx55q7jmqbgk@chowder> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230222_051614_241643_8E86E6F4 X-CRM114-Status: GOOD ( 11.50 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 10:21-20230222, Ravi Gunasekaran wrote: [...] > >> + usbss0: cdns-usb@4104000 { > >> + compatible = "ti,j721e-usb"; > >> + reg = <0x00 0x04104000 0x00 0x100>; > >> + clocks = <&k3_clks 360 16>, <&k3_clks 360 15>; > >> + clock-names = "ref", "lpm"; > >> + assigned-clocks = <&k3_clks 360 16>; /* USB2_REFCLK */ > >> + assigned-clock-parents = <&k3_clks 360 17>; > >> + power-domains = <&k3_pds 360 TI_SCI_PD_EXCLUSIVE>; > >> + #address-cells = <2>; > >> + #size-cells = <2>; > >> + ranges; > >> + dma-coherent; > >> + > >> + status = "disabled"; > > > > Why disabled by default? > > One of the comment received in the v9 series was to disable the node in > the include file and then enable it in the board specific DTS file. > Changes in this series addressed that comment. Document in the node why it is disabled by default. Also do make sure All K3 SoCs dtsi nodes follow the same argument. -- Regards, Nishanth Menon Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel