From: Mark Brown <broonie@kernel.org>
To: Liam Girdwood <lgirdwood@gmail.com>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>
Cc: "Nícolas F. R. A. Prado" <nfraprado@collabora.com>,
alsa-devel@alsa-project.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org,
"Mark Brown" <broonie@kernel.org>
Subject: [PATCH 3/4] ASoC: mt8192: Report an error if when an invalid sidetone gain is written
Date: Fri, 24 Feb 2023 14:03:57 +0000 [thread overview]
Message-ID: <20230223-asoc-mt8192-quick-fixes-v1-3-9a85f90368e1@kernel.org> (raw)
In-Reply-To: <20230223-asoc-mt8192-quick-fixes-v1-0-9a85f90368e1@kernel.org>
Reporting an error on invalid values is optional but helpful to userspace
so do so.
Signed-off-by: Mark Brown <broonie@kernel.org>
---
sound/soc/mediatek/mt8192/mt8192-dai-adda.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/sound/soc/mediatek/mt8192/mt8192-dai-adda.c b/sound/soc/mediatek/mt8192/mt8192-dai-adda.c
index a33d1ce33349..a02a297c0450 100644
--- a/sound/soc/mediatek/mt8192/mt8192-dai-adda.c
+++ b/sound/soc/mediatek/mt8192/mt8192-dai-adda.c
@@ -601,6 +601,8 @@ static int stf_positive_gain_set(struct snd_kcontrol *kcontrol,
POSITIVE_GAIN_MASK_SFT,
(gain_db / 6) << POSITIVE_GAIN_SFT,
&change);
+ } else {
+ return -EINVAL;
}
return change;
--
2.30.2
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-02-24 14:09 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-24 14:03 [PATCH 0/4] ASoC: mt8192: Fixes from initial glance at kselftest run Mark Brown
2023-02-24 14:03 ` [PATCH 1/4] ASoC: mt8192: Remove spammy log messages Mark Brown
2023-02-24 19:06 ` Nícolas F. R. A. Prado
2023-02-24 19:15 ` Mark Brown
2023-02-27 8:52 ` AngeloGioacchino Del Regno
2023-02-24 14:03 ` [PATCH 2/4] ASoC: mt8192: Fix event generation for controls Mark Brown
2023-02-24 19:14 ` Nícolas F. R. A. Prado
2023-02-27 8:52 ` AngeloGioacchino Del Regno
2023-02-24 14:03 ` Mark Brown [this message]
2023-02-24 19:15 ` [PATCH 3/4] ASoC: mt8192: Report an error if when an invalid sidetone gain is written Nícolas F. R. A. Prado
2023-02-27 8:52 ` AngeloGioacchino Del Regno
2023-02-24 14:03 ` [PATCH 4/4] ASoC: mt8192: Fix range for sidetone positive gain Mark Brown
2023-02-24 19:19 ` Nícolas F. R. A. Prado
2023-02-27 8:52 ` AngeloGioacchino Del Regno
2023-02-24 19:40 ` [PATCH 0/4] ASoC: mt8192: Fixes from initial glance at kselftest run Nícolas F. R. A. Prado
2023-02-28 18:00 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230223-asoc-mt8192-quick-fixes-v1-3-9a85f90368e1@kernel.org \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=angelogioacchino.delregno@collabora.com \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=nfraprado@collabora.com \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).