From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EFAA7C678D5 for ; Thu, 23 Feb 2023 19:43:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:References: List-Owner; bh=ElTTHogYq0EbnCsJE9VsgN9N9nIoxq+B3jYaHoX/QMQ=; b=4K0WM4/RREwNDm v3rYRgcOsT3PGZFp2qfnd3ildDgJuKh0gnbOKSScDaUbyYktc65CNeiwYEEWL835lXfs5hCYaXPYe aNNu6N7di2dsFv1PV8N32m261JPSdlTh/QZNiSKpsOw/65pV3pvEg1yWWZ2K4mt9ju/7Uy4eWP6+f qsiu0RYz+OVfCEDatnIQQOhkYYuaR1+Ms4hhu93zN7I8m0YkuTxdJ/8w+eXxMuGLm0Xd7jjPeobLj DRlQwOv1/U0k7+/H5dTUsDxSL7j/xEEI6VXW2PFHzPASf9j/B/L3kY6pvS9LC+7bAvu3RVUUyPK5w 7X67kBGzKJptXPoqiVTg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pVHUL-00080V-U6; Thu, 23 Feb 2023 19:42:46 +0000 Received: from sin.source.kernel.org ([2604:1380:40e1:4800::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pVHUD-0007yA-NH for linux-arm-kernel@lists.infradead.org; Thu, 23 Feb 2023 19:42:39 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sin.source.kernel.org (Postfix) with ESMTPS id DFB48CE210B; Thu, 23 Feb 2023 19:42:33 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C292BC433EF; Thu, 23 Feb 2023 19:42:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1677181352; bh=yBmZi1dgHiYx3f1jIdVOufjs7LlM8Rf+8jsvfrqP5eI=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=jjYxMDUKZhonBr9WaQk+3e1oaOg71ENniA+tkDkWixIxikS5zJ1MOKKipwjbNj5N/ O6JkZLgXAlb0SGWKstzO8DbFZw8uGn2RD3riEpNvJq1ZxA3tU4Z4hMq0kZagAW9haq nyyXcsWo6PgF0NGDmG5ZsAeMmOk+OvAVsS7yPvBuEwu48VEzW1O4/co3ps993eBuqJ ldpaqS2tGq2MuGRV2hbHBZeN+BwC5uT/gHtOJpwcV7EXZLEC2yG9OEPX4hjbRhDz8r ZUixli7uPsQHdBQ3TEba70j5CHzzHYkmuz3vXZn/HtFPMLS5STqwg9fuKqDWTbv8hx fVC5+6MFFdVVA== Date: Thu, 23 Feb 2023 13:42:30 -0600 From: Bjorn Helgaas To: Elad Nachman Cc: thomas.petazzoni@bootlin.com, bhelgaas@google.com, lpieralisi@kernel.org, robh@kernel.org, kw@linux.com, krzysztof.kozlowski+dt@linaro.org, linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 0/7] PCI: dwc: Add support for Marvell AC5 SoC Message-ID: <20230223194230.GA3888258@bhelgaas> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230223180531.15148-1-enachman@marvell.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230223_114237_992520_E1219099 X-CRM114-Status: GOOD ( 12.93 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Feb 23, 2023 at 08:05:24PM +0200, Elad Nachman wrote: > From: Elad Nachman > > Add support for AC5 SoC with MSI and in message emulated legacy mode. > There are differences in the registers addresses, blocks, DDR location > for coherent DMA allocation and additional implementation specific registers. > In addition, support cases of older Designware IP (Armada 7020) which supports > above 4GB PCIe physical memory window by use of device tree. > ... > Elad Nachman (4): > dt-bindings: PCI: dwc: add DMA, region mask bits > PCI: dwc: support AC5 Legacy PCIe interrupts > PCI: dwc: Introduce Configurable DMA mask > PCI: dwc: Introduce region limit from DT > > Raz Adashi (1): > PCI: armada8k: Add AC5 SoC support > > Vadym Kochan (1): > dt-bindings: PCI: armada8k: Add compatible string for AC5 SoC > > Yuval Shaia (1): > PCI: armada8k: Add MSI support for AC5 SoC Capitalize subject consistently. Use consistent driver tags. Use parallel sentence structure. s/add DMA/Add DMA/ s/PCI: dwc: support/PCI: armada8k: Support/ (this particular patch only affects armada8k, so don't label it "dwc") s/support/Support/ s/Configurable/configurable/ s/Add MSI support for AC5 SoC/Add AC5 MSI support/ (parallel to "Add AC5 SoC support") The PCIe spec doesn't really use "legacy" when defining the interrupt model. I think you're referring to INTx, which it *does* use and is more specific. If so, please say "INTx interrupts" instead of "legacy PCIe interrupts". _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel