From: Mark Brown <broonie@kernel.org>
To: Liam Girdwood <lgirdwood@gmail.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>
Cc: "Nícolas F. R. A. Prado" <nfraprado@collabora.com>,
alsa-devel@alsa-project.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org,
"Mark Brown" <broonie@kernel.org>
Subject: [PATCH 2/3] ASoC: mt6358: Validate Wake on Voice 2 writes
Date: Sun, 26 Feb 2023 12:47:57 +0000 [thread overview]
Message-ID: <20230224-asoc-mt6358-quick-fixes-v1-2-747d9186be4b@kernel.org> (raw)
In-Reply-To: <20230224-asoc-mt6358-quick-fixes-v1-0-747d9186be4b@kernel.org>
Currently the Wake on Voice 2 control accepts and stores any value written
but it reports that only 0 and 1 are valid values. Reject any out of range
values written by userspace.
Signed-off-by: Mark Brown <broonie@kernel.org>
---
sound/soc/codecs/mt6358.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/sound/soc/codecs/mt6358.c b/sound/soc/codecs/mt6358.c
index 9004377461f7..89d0dcb2635b 100644
--- a/sound/soc/codecs/mt6358.c
+++ b/sound/soc/codecs/mt6358.c
@@ -560,6 +560,9 @@ static int mt6358_put_wov(struct snd_kcontrol *kcontrol,
struct mt6358_priv *priv = snd_soc_component_get_drvdata(c);
int enabled = ucontrol->value.integer.value[0];
+ if (enabled < 0 || enabled > 1)
+ return -EINVAL;
+
if (priv->wov_enabled != enabled) {
if (enabled)
mt6358_enable_wov_phase2(priv);
--
2.30.2
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-02-26 12:49 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-26 12:47 [PATCH 0/3] ASoC: mt6358: Fixes from an initial glance at a kselftest run Mark Brown
2023-02-26 12:47 ` [PATCH 1/3] ASoC: mt6358: Fix event generation for wake on voice stage 2 switch Mark Brown
2023-02-27 8:55 ` AngeloGioacchino Del Regno
2023-02-26 12:47 ` Mark Brown [this message]
2023-02-27 8:55 ` [PATCH 2/3] ASoC: mt6358: Validate Wake on Voice 2 writes AngeloGioacchino Del Regno
2023-02-26 12:47 ` [PATCH 3/3] ASoC: mt6358: Remove undefined HPx Mux enumeration values Mark Brown
2023-02-27 8:55 ` AngeloGioacchino Del Regno
2023-02-28 18:00 ` [PATCH 0/3] ASoC: mt6358: Fixes from an initial glance at a kselftest run Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230224-asoc-mt6358-quick-fixes-v1-2-747d9186be4b@kernel.org \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=angelogioacchino.delregno@collabora.com \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=nfraprado@collabora.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).