* [PATCH 1/2] ASoC: mt8183: Remove spammy logging from I2S DAI driver
2023-02-26 12:49 [PATCH 0/2] ASoC: mt8183: Fixes from an initial glance at a kselftest run Mark Brown
@ 2023-02-26 12:49 ` Mark Brown
2023-02-27 8:55 ` AngeloGioacchino Del Regno
2023-02-26 12:49 ` [PATCH 2/2] ASoC: mt8183: Fix event generation for I2S DAI operations Mark Brown
2023-02-28 18:00 ` [PATCH 0/2] ASoC: mt8183: Fixes from an initial glance at a kselftest run Mark Brown
2 siblings, 1 reply; 6+ messages in thread
From: Mark Brown @ 2023-02-26 12:49 UTC (permalink / raw)
To: Liam Girdwood, Matthias Brugger, AngeloGioacchino Del Regno
Cc: Nícolas F. R. A. Prado, alsa-devel, linux-arm-kernel,
linux-mediatek, linux-kernel, Mark Brown
There is a lot of dev_info() logging in normal operation in the I2S DAI
driver, remove it to avoid spamming the console.
Signed-off-by: Mark Brown <broonie@kernel.org>
---
sound/soc/mediatek/mt8183/mt8183-dai-i2s.c | 16 ----------------
1 file changed, 16 deletions(-)
diff --git a/sound/soc/mediatek/mt8183/mt8183-dai-i2s.c b/sound/soc/mediatek/mt8183/mt8183-dai-i2s.c
index 6a9ace4180d3..38f7fa38ee95 100644
--- a/sound/soc/mediatek/mt8183/mt8183-dai-i2s.c
+++ b/sound/soc/mediatek/mt8183/mt8183-dai-i2s.c
@@ -148,9 +148,6 @@ static int mt8183_i2s_hd_set(struct snd_kcontrol *kcontrol,
hd_en = ucontrol->value.integer.value[0];
- dev_info(afe->dev, "%s(), kcontrol name %s, hd_en %d\n",
- __func__, kcontrol->id.name, hd_en);
-
i2s_priv = get_i2s_priv_by_name(afe, kcontrol->id.name);
if (!i2s_priv) {
@@ -276,9 +273,6 @@ static int mtk_apll_event(struct snd_soc_dapm_widget *w,
struct snd_soc_component *cmpnt = snd_soc_dapm_to_component(w->dapm);
struct mtk_base_afe *afe = snd_soc_component_get_drvdata(cmpnt);
- dev_info(cmpnt->dev, "%s(), name %s, event 0x%x\n",
- __func__, w->name, event);
-
switch (event) {
case SND_SOC_DAPM_PRE_PMU:
if (strcmp(w->name, APLL1_W_NAME) == 0)
@@ -307,9 +301,6 @@ static int mtk_mclk_en_event(struct snd_soc_dapm_widget *w,
struct mtk_base_afe *afe = snd_soc_component_get_drvdata(cmpnt);
struct mtk_afe_i2s_priv *i2s_priv;
- dev_info(cmpnt->dev, "%s(), name %s, event 0x%x\n",
- __func__, w->name, event);
-
i2s_priv = get_i2s_priv_by_name(afe, w->name);
if (!i2s_priv) {
@@ -715,11 +706,6 @@ static int mtk_dai_i2s_config(struct mtk_base_afe *afe,
unsigned int i2s_con = 0, fmt_con = I2S_FMT_I2S << I2S_FMT_SFT;
int ret = 0;
- dev_info(afe->dev, "%s(), id %d, rate %d, format %d\n",
- __func__,
- i2s_id,
- rate, format);
-
if (i2s_priv) {
i2s_priv->rate = rate;
@@ -810,8 +796,6 @@ static int mtk_dai_i2s_set_sysclk(struct snd_soc_dai *dai,
return -EINVAL;
}
- dev_info(afe->dev, "%s(), freq %d\n", __func__, freq);
-
apll = mt8183_get_apll_by_rate(afe, freq);
apll_rate = mt8183_get_apll_rate(afe, apll);
--
2.30.2
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH 2/2] ASoC: mt8183: Fix event generation for I2S DAI operations
2023-02-26 12:49 [PATCH 0/2] ASoC: mt8183: Fixes from an initial glance at a kselftest run Mark Brown
2023-02-26 12:49 ` [PATCH 1/2] ASoC: mt8183: Remove spammy logging from I2S DAI driver Mark Brown
@ 2023-02-26 12:49 ` Mark Brown
2023-02-27 8:55 ` AngeloGioacchino Del Regno
2023-02-28 18:00 ` [PATCH 0/2] ASoC: mt8183: Fixes from an initial glance at a kselftest run Mark Brown
2 siblings, 1 reply; 6+ messages in thread
From: Mark Brown @ 2023-02-26 12:49 UTC (permalink / raw)
To: Liam Girdwood, Matthias Brugger, AngeloGioacchino Del Regno
Cc: Nícolas F. R. A. Prado, alsa-devel, linux-arm-kernel,
linux-mediatek, linux-kernel, Mark Brown
ALSA control put() operations should return 0 if the value changed so that
events can be generated appropriately for userspace but the custom control
in the MT8183 I2S DAI driver doesn't do that, fix it.
Signed-off-by: Mark Brown <broonie@kernel.org>
---
sound/soc/mediatek/mt8183/mt8183-dai-i2s.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/sound/soc/mediatek/mt8183/mt8183-dai-i2s.c b/sound/soc/mediatek/mt8183/mt8183-dai-i2s.c
index 38f7fa38ee95..8645ab686970 100644
--- a/sound/soc/mediatek/mt8183/mt8183-dai-i2s.c
+++ b/sound/soc/mediatek/mt8183/mt8183-dai-i2s.c
@@ -141,7 +141,7 @@ static int mt8183_i2s_hd_set(struct snd_kcontrol *kcontrol,
struct mtk_base_afe *afe = snd_soc_component_get_drvdata(cmpnt);
struct mtk_afe_i2s_priv *i2s_priv;
struct soc_enum *e = (struct soc_enum *)kcontrol->private_value;
- int hd_en;
+ int hd_en, change;
if (ucontrol->value.enumerated.item[0] >= e->items)
return -EINVAL;
@@ -155,9 +155,10 @@ static int mt8183_i2s_hd_set(struct snd_kcontrol *kcontrol,
return -EINVAL;
}
+ change = i2s_priv->low_jitter_en != hd_en;
i2s_priv->low_jitter_en = hd_en;
- return 0;
+ return change;
}
static const struct snd_kcontrol_new mtk_dai_i2s_controls[] = {
--
2.30.2
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH 0/2] ASoC: mt8183: Fixes from an initial glance at a kselftest run
2023-02-26 12:49 [PATCH 0/2] ASoC: mt8183: Fixes from an initial glance at a kselftest run Mark Brown
2023-02-26 12:49 ` [PATCH 1/2] ASoC: mt8183: Remove spammy logging from I2S DAI driver Mark Brown
2023-02-26 12:49 ` [PATCH 2/2] ASoC: mt8183: Fix event generation for I2S DAI operations Mark Brown
@ 2023-02-28 18:00 ` Mark Brown
2 siblings, 0 replies; 6+ messages in thread
From: Mark Brown @ 2023-02-28 18:00 UTC (permalink / raw)
To: Liam Girdwood, Matthias Brugger, AngeloGioacchino Del Regno,
Mark Brown
Cc: Nícolas F. R. A. Prado, alsa-devel, linux-arm-kernel,
linux-mediatek, linux-kernel
On Sun, 26 Feb 2023 12:49:55 +0000, Mark Brown wrote:
> This is a collection of fixes I came up after glancing through an
> initial test run with the snappily named Kukui Jacuzzi SKU16 Chromebook
> on KernelCI. There are more issues flagged, this is just what I fixed
> thus far.
>
>
Applied to
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next
Thanks!
[1/2] ASoC: mt8183: Remove spammy logging from I2S DAI driver
commit: d71ed1c8f0f458ae6852fdab055790fe1d9d19b6
[2/2] ASoC: mt8183: Fix event generation for I2S DAI operations
commit: 18f51ed09888c8e48bd377d1715d4ff807b4c805
All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying
to this mail.
Thanks,
Mark
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 6+ messages in thread