From: Jonathan Cameron <jic23@kernel.org>
To: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Cc: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
"Lars-Peter Clausen" <lars@metafoo.de>,
"Neil Armstrong" <neil.armstrong@linaro.org>,
"Kevin Hilman" <khilman@baylibre.com>,
"Jerome Brunet" <jbrunet@baylibre.com>,
"Andy Shevchenko" <andriy.shevchenko@linux.intel.com>,
"Nuno Sá" <nuno.sa@analog.com>,
linux-iio@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-amlogic@lists.infradead.org, kernel@pengutronix.de
Subject: Re: [PATCH v2] iio: adc: meson_saradc: Better handle BL30 not releaseing the hardware
Date: Sat, 25 Feb 2023 16:36:32 +0000 [thread overview]
Message-ID: <20230225163632.4891019e@jic23-huawei> (raw)
In-Reply-To: <CAFBinCCF_wSt6qd125f=7wzCPm21iz6ZbJ2oHGnPNBJy30y_DA@mail.gmail.com>
On Sun, 19 Feb 2023 22:05:16 +0100
Martin Blumenstingl <martin.blumenstingl@googlemail.com> wrote:
> Hello Uwe,
>
> I think there's a typo in the subject line:
> s/releaseing/releasing/
>
> On Sun, Feb 19, 2023 at 9:44 PM Uwe Kleine-König
> <u.kleine-koenig@pengutronix.de> wrote:
> >
> > meson_sar_adc_lock() might return an error if BL30 doesn't release its
> > lock on the hardware. Just returning early from .remove() is wrong
> > however as this keeps the clocks and regulators on which is never
> > cleaned up later.
> >
> > Given the BL30 not giving up its lock is a strong hint for broken
> > behaviour, and there is nothing we can do about that: Just clean up
> > ignoring the fact that we're not holding the lock.
> >
> > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> Other than the typo (which maybe Jonathan can fix up while applying):
> Reviewed-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Fixed up typo and applied to the togreg branch of iio.git.
Note I'll not push that out other than as testing until I can rebase on rc1.
Thanks,
Jonathan
>
>
> Thank you!
> Martin
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2023-02-25 16:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-19 20:44 [PATCH v2] iio: adc: meson_saradc: Better handle BL30 not releaseing the hardware Uwe Kleine-König
2023-02-19 21:05 ` Martin Blumenstingl
2023-02-25 16:36 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230225163632.4891019e@jic23-huawei \
--to=jic23@kernel.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=jbrunet@baylibre.com \
--cc=kernel@pengutronix.de \
--cc=khilman@baylibre.com \
--cc=lars@metafoo.de \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-iio@vger.kernel.org \
--cc=martin.blumenstingl@googlemail.com \
--cc=neil.armstrong@linaro.org \
--cc=nuno.sa@analog.com \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox