* [PATCH v1] drivers/spi-rockchip.c : Remove redundant variable slave
@ 2023-02-26 6:33 Lizhe
2023-03-06 13:05 ` Mark Brown
0 siblings, 1 reply; 2+ messages in thread
From: Lizhe @ 2023-02-26 6:33 UTC (permalink / raw)
To: broonie, heiko
Cc: linux-spi, linux-arm-kernel, linux-rockchip, linux-kernel, Lizhe
variable slave in spi_alloc_master() or spi_alloc_slave()
has been assigned. it is not necessary to be assigned again
Signed-off-by: Lizhe <sensor1010@163.com>
---
drivers/spi/spi-rockchip.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/spi/spi-rockchip.c b/drivers/spi/spi-rockchip.c
index 79242dc5272d..a45717eb8890 100644
--- a/drivers/spi/spi-rockchip.c
+++ b/drivers/spi/spi-rockchip.c
@@ -772,7 +772,6 @@ static int rockchip_spi_probe(struct platform_device *pdev)
platform_set_drvdata(pdev, ctlr);
rs = spi_controller_get_devdata(ctlr);
- ctlr->slave = slave_mode;
/* Get basic io resource and map it */
mem = platform_get_resource(pdev, IORESOURCE_MEM, 0);
--
2.34.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v1] drivers/spi-rockchip.c : Remove redundant variable slave
2023-02-26 6:33 [PATCH v1] drivers/spi-rockchip.c : Remove redundant variable slave Lizhe
@ 2023-03-06 13:05 ` Mark Brown
0 siblings, 0 replies; 2+ messages in thread
From: Mark Brown @ 2023-03-06 13:05 UTC (permalink / raw)
To: heiko, Lizhe; +Cc: linux-spi, linux-arm-kernel, linux-rockchip, linux-kernel
On Sun, 26 Feb 2023 14:33:34 +0800, Lizhe wrote:
> variable slave in spi_alloc_master() or spi_alloc_slave()
> has been assigned. it is not necessary to be assigned again
>
>
Applied to
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-next
Thanks!
[1/1] drivers/spi-rockchip.c : Remove redundant variable slave
commit: 8c220e6c6da9c2f70a78ba8b3121893b3634a54c
All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying
to this mail.
Thanks,
Mark
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-03-06 13:06 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-02-26 6:33 [PATCH v1] drivers/spi-rockchip.c : Remove redundant variable slave Lizhe
2023-03-06 13:05 ` Mark Brown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).