From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 96D8EC64ED6 for ; Mon, 27 Feb 2023 03:27:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=XfUyxWr/BJSP79KuAAKYuy5UfcVY1vSRrePpIcDCPsQ=; b=XfTQSQFBL4G1JN XurNv8QAIvp7+ICsIzwL8aCb2jJtTKInvFed5CXk4M0aDnn9/CJUp0BCN1NNvnATPqzFsyOjwlRRN hkX8ym8bNmoorNpFse30mygM65lgV+VPWTkP25FHFQXZODPwATWszaTfEOspe/dF4ZyxaCUf4I0dg OV+EOtUueEobd7AEBnEDqTR0wticAt5dIKywXKv0YggcGNKDgsTFhp9yhQJ5rl8aHB4UjEolBnHOD LVpYdprH1weTO+bjb2lXls0Cv2gCnvZP9wXpvUMMTxx7B1JFCRWtpuwpxniOnpBB/JvH/hJ1Dc4S/ QlyvpvV6RXEFw5neLY1g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pWU9S-008N3w-Fu; Mon, 27 Feb 2023 03:26:10 +0000 Received: from mail-pj1-x1036.google.com ([2607:f8b0:4864:20::1036]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pWU9L-008N3F-Ji for linux-arm-kernel@lists.infradead.org; Mon, 27 Feb 2023 03:26:08 +0000 Received: by mail-pj1-x1036.google.com with SMTP id oj5so697372pjb.5 for ; Sun, 26 Feb 2023 19:26:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=vQjgP6xD9SwZtosmKlpC86tRlv5f9ObNbS66GUAaxVc=; b=CGkQ0zxIXtJqp7Tctt5suGL0lPfve3yYjTiOlUXqSX/r2QEQf973FYr8hi2xhusYW8 cj34TaRKzIUFaKiOlKpepE1TDiWpFAi3m5h8K3srK7O4/xpcM1XP8fghYxNDOQNOa+sA EHaF/bJPmHCLZTy37xH03vHeP3pRJeNQvrHJy/E/O150fh/dCim+5VO9eaaHTNP47dh3 BJvnfyucKF7xzHyMm2DL9Ub0xp0DxTVFPRC8fF6kTcblzi9kw5AYstuxKGixmQRoH/5Q hHO19rYnyQrgqtoSRluRhrTic8nQ3FadEw2rJ5g0BeVTkGRurBkeWIKJSzZZHr1yjUi+ kxEQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=vQjgP6xD9SwZtosmKlpC86tRlv5f9ObNbS66GUAaxVc=; b=roldrokSty0In4y6J9CY0ZTbQcXn6tA7yndlprBwxt4LMX1MIcVnXpSeRweuTFjqOz UYfLZOtsH7ddsixLFPb+sBJAQCYX1SFptUZ1dHECFQ9sWBVw2mCNih1l3Ux4d+Ro0EfF etKfv83NoRxcBNT+3yVsMXww4k+N352Av1oMhqtbhlwAFQfBwg6ufD4P6cgR+YmRtYc4 XnOZ+7ahDdbn2wMYy/YD3FPQCvHcllziQ/tgpO8WdwwVxebZZ7KqxY9Vp+2fNRW45Ckt zi7grZvN8u+H+OeDRwxZ3PEC8fW3Hy6K28XXFz71yrc4U+i47g96pmGVfaQJ+ifH+SA8 k0yA== X-Gm-Message-State: AO0yUKWnfJAWdbwOWDsCdVYsL+Lk6XR4oPtF/FSRj9HILz9FOZzQdp1U pGokKLNeTlHVH7KcU1ahbP29q9oAzZN2u9+s X-Google-Smtp-Source: AK7set/A1fBsD28xROh2L7g6t5SbmBzKfmCs44JaXQTElMb14SOP8rF3ZD9cIYLbYZe46MEMIH00kQ== X-Received: by 2002:a17:902:b286:b0:19c:a9b8:4349 with SMTP id u6-20020a170902b28600b0019ca9b84349mr15651897plr.32.1677468361962; Sun, 26 Feb 2023 19:26:01 -0800 (PST) Received: from localhost.localdomain ([103.116.245.58]) by smtp.gmail.com with ESMTPSA id jc11-20020a17090325cb00b0019682e27995sm3342751plb.223.2023.02.26.19.26.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 26 Feb 2023 19:26:01 -0800 (PST) From: void0red To: will@kernel.org Cc: mark.rutland@arm.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Kang Chen Subject: [PATCH] perf/smmuv3: add a check of devm_add_action in smmu_pmu_setup_msi Date: Mon, 27 Feb 2023 11:25:57 +0800 Message-Id: <20230227032557.894274-1-void0red@gmail.com> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230226_192603_692356_9E134A23 X-CRM114-Status: GOOD ( 11.89 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org From: Kang Chen devm_add_action may fails, add a warning when it happens. Signed-off-by: Kang Chen --- drivers/perf/arm_smmuv3_pmu.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/perf/arm_smmuv3_pmu.c b/drivers/perf/arm_smmuv3_pmu.c index 25a269d43..307bac904 100644 --- a/drivers/perf/arm_smmuv3_pmu.c +++ b/drivers/perf/arm_smmuv3_pmu.c @@ -724,7 +724,11 @@ static void smmu_pmu_setup_msi(struct smmu_pmu *pmu) pmu->irq = msi_get_virq(dev, 0); /* Add callback to free MSIs on teardown */ - devm_add_action(dev, smmu_pmu_free_msis, dev); + ret = devm_add_action(dev, smmu_pmu_free_msis, dev); + if (ret) { + dev_warn(dev, "failed to add callback to free MSIs on teardown\n"); + return; + } } static int smmu_pmu_setup_irq(struct smmu_pmu *pmu) -- 2.34.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel