From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6E917C64ED8 for ; Mon, 27 Feb 2023 19:52:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=U2sXc2vKMuWAbdtwfdw3ISJrfMa1yzqlVD3tR1XVc7E=; b=Z5rebP//Fd4Az5 w/2ShqZ6ze+21Cats2RAkdVygZzrmhC74hp3Uh1wXO7VGpa0ytjMCVnR8TvewsZEm5jRUGIciSZRu jhV2GfVjx1Q2a+WT/7KoRxOWGRwdgGhi0lmA319a/oi/F44FJhmQsHNav5RPmIRQyc6sT8Bkefa09 3ryFarNzcdVWnYImZmIS7I4WS4Rrda6YTYF9akYhKqw3n/kezr3gtsj4CQKaZF3RA4x7bGaEwWZA5 +NPkgQPanaQKz6wMrjZjXqyhOqw+qrUprlmlM26l2zDLawdoOzi1ZI4KcyG4cFAb2ejC2dMYt93GJ Olnqhbbzh9SCEW3zkhHg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pWjXS-00B2XK-U4; Mon, 27 Feb 2023 19:51:59 +0000 Received: from mail-oa1-f49.google.com ([209.85.160.49]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pWjXC-00B2Pg-O3 for linux-arm-kernel@lists.infradead.org; Mon, 27 Feb 2023 19:51:44 +0000 Received: by mail-oa1-f49.google.com with SMTP id 586e51a60fabf-17264e9b575so8571652fac.9 for ; Mon, 27 Feb 2023 11:51:41 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=U2w9C/mXgb39nbWWzCANJLsyjZIuLsO8IPSpBBNMA04=; b=nf3rXAGR9KgBdGgrFMCp6beBfLtJdO4VUaR0/Y9ngNXUC0aoeaMjxQS5f3DENQ6pu6 1aNYjPtRJiLOlFUzvC0iwcxxwx0XEPdhmisqWXRMBOysH1Th2imgXrYhczKh81wYOVlr qda6VAZs1H58QLjMSsW+m1D1keJEOkT+tPsuJB1E6UIQQ7B9vbFYdLVLkKT8GZ03Swbt SZZQnX3wJheHgFEz1X69auuPUTwqegEfEfNIOT4SYzQumcfsjVEJwham9JYXN/wpng90 n7w5ryYNBEmYY/2L+QHoojhgZEujG+g8olKLir69yqaq2wvjKlBD5eTqZDf+ijztq0Do X6VA== X-Gm-Message-State: AO0yUKUJ1jAQ9SVPudQoyfoyyPh2xdXM/NV7d9SM7Sv4bLwTvmWuCuYb rCk3YfiXkWsLx/7QAgQYhg== X-Google-Smtp-Source: AK7set8+QjpptCrKzerYds+IQtpA5ahwHgQ9R+U8uqnkDEbcdthD+ZZB5YTwTiygb3cfDhitheANoA== X-Received: by 2002:a05:6871:586:b0:172:64f3:8430 with SMTP id u6-20020a056871058600b0017264f38430mr11660397oan.28.1677527500430; Mon, 27 Feb 2023 11:51:40 -0800 (PST) Received: from robh_at_kernel.org (66-90-144-107.dyn.grandenetworks.net. [66.90.144.107]) by smtp.gmail.com with ESMTPSA id m2-20020a056870194200b001727c3bf124sm2578392oak.31.2023.02.27.11.51.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Feb 2023 11:51:39 -0800 (PST) Received: (nullmailer pid 749238 invoked by uid 1000); Mon, 27 Feb 2023 19:51:39 -0000 Date: Mon, 27 Feb 2023 13:51:39 -0600 From: Rob Herring To: Sasha Finkelstein Cc: Hector Martin , Sven Peter , Alyssa Rosenzweig , Dmitry Torokhov , Krzysztof Kozlowski , - , Henrik Rydberg , linux-arm-kernel@lists.infradead.org, linux-input@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH RFC 1/4] dt-bindings: input: touchscreen: Add Z2 controller bindings. Message-ID: <20230227195139.GA677578-robh@kernel.org> References: <20230223-z2-for-ml-v1-0-028f2b85dc15@gmail.com> <20230223-z2-for-ml-v1-1-028f2b85dc15@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230223-z2-for-ml-v1-1-028f2b85dc15@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230227_115142_803556_09221681 X-CRM114-Status: GOOD ( 24.47 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Feb 24, 2023 at 11:20:06AM +0100, Sasha Finkelstein wrote: > Add bindings for touchscreen controllers attached using the Z2 protocol. > Those are present in most Apple devices. > > Signed-off-by: Sasha Finkelstein > --- > .../input/touchscreen/apple,z2-touchscreen.yaml | 81 ++++++++++++++++++++++ > 1 file changed, 81 insertions(+) > > diff --git a/Documentation/devicetree/bindings/input/touchscreen/apple,z2-touchscreen.yaml b/Documentation/devicetree/bindings/input/touchscreen/apple,z2-touchscreen.yaml > new file mode 100644 > index 000000000000..695594494b1e > --- /dev/null > +++ b/Documentation/devicetree/bindings/input/touchscreen/apple,z2-touchscreen.yaml > @@ -0,0 +1,81 @@ > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/input/touchscreen/apple,z2-touchscreen.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Apple touchscreens attached using the Z2 protocol. > + > +maintainers: > + - asahi@lists.linux.dev > + - Sasha Finkelstein > + > +description: A series of touschscreen controllers used in Apple products. > + > +allOf: > + - $ref: touchscreen.yaml# > + - $ref: /schemas/spi/spi-peripheral-props.yaml# > + > +properties: > + compatible: > + const: apple,z2-touchscreen Is 'z2' anything other than a touchscreen? If not, '-touchscreen' is redundant. If so, then what else is there? You should be describing physical devices, not just a protocol for touchscreen. > + > + reg: > + maxItems: 1 > + > + interrupts-extended: Just 'interrupts' here. 'interrupts-extended' is implicitly supported. > + maxItems: 1 > + > + reset-gpios: > + maxItems: 1 > + > + cs-gpios: There is a standard way to do GPIO based chip-selects. It happens to be 'cs-gpios', but this is in the wrong place. It goes in the SPI controller node. > + maxItems: 1 > + > + firmware-name: > + maxItems: 1 > + > + apple,z2-device-name: > + description: The name to be used for the input device > + $ref: /schemas/types.yaml#/definitions/string > + > + touchscreen-size-x: true > + touchscreen-size-y: true > + spi-max-frequency: true > + > +required: > + - compatible > + - interrupts-extended > + - reset-gpios > + - cs-gpios > + - firmware-name > + - apple,z2-device-name > + - touchscreen-size-x > + - touchscreen-size-y > + > +additionalProperties: false > + > +examples: > + - | > + #include > + #include > + > + spi { > + #address-cells = <1>; > + #size-cells = <0>; 4 space indentation is preferred here. > + > + touchscreen@0 { > + compatible = "apple,z2-touchscreen"; > + reg = <0>; > + spi-max-frequency = <11500000>; > + reset-gpios = <&pinctrl_ap 139 0>; > + cs-gpios = <&pinctrl_ap 109 0>; > + interrupts-extended = <&pinctrl_ap 194 IRQ_TYPE_EDGE_FALLING>; > + firmware-name = "apple/dfrmtfw-j293.bin"; > + touchscreen-size-x = <23045>; > + touchscreen-size-y = <640>; > + apple,z2-device-name = "MacBookPro17,1 Touch Bar"; Why do we need this string? If you want a human consumed label for some identification, we have a property for that purpose. It's called 'label'. But when there is only 1 instance, I don't really see the point. Rob _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel