From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 23C44C64ED8 for ; Mon, 27 Feb 2023 20:53:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=dzxPTJQeN0srNdGUu6c/YEy+LoL33/exiylj2NWJZjY=; b=cWNDyvoTlebLJA ql7E9yAIC0NmI2uEG50SGafd+ZweaIQBtlkuHxmaEYPtLVWyCm8Htxtgg1mDwi3lvPuTUeg0T9NWw SyyxJFF1Z0RI2IDifA7T5b2rjF7Bp/zxStxkKYwGQzZL9/MTdOeD9k7m2sc+utIiimVQrBMHOORHF Abhs+pTa4ynK7bY5ELaQ72beEYhpfXGZdUZ9HXsnEvMOpRbC0FgAHaVBSkh2RQA1ylZ+HeFS/Mu9n xyLU/5fc2PW8eP+VttEs+fDPRbHu+tOdQi4QXDyhZjuZ9kXFNXqWygapI9nhZVn3TH4Z2klE/tR5v tR+RgpDNiIBIlMGo92WA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pWkUC-00BD8t-7g; Mon, 27 Feb 2023 20:52:40 +0000 Received: from mail-oi1-f178.google.com ([209.85.167.178]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pWkU9-00BD67-0r for linux-arm-kernel@lists.infradead.org; Mon, 27 Feb 2023 20:52:38 +0000 Received: by mail-oi1-f178.google.com with SMTP id y184so6292220oiy.8 for ; Mon, 27 Feb 2023 12:52:31 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=1IO0sBucNdWhZTvHKKkXibO8za6vlePhK4sUIcE5pvE=; b=glpS1xbVY0pYDaZCeLEoCjYCRkpFn31mM5ln67m3PeqQ4i+SvEEUz+y3GEyz2ItFWt dDSXTP6YG37HIv2ckNE0HmzIoc+3V4FOXluuOr4ouRLd5mUPqzaqaincBBNp1KNQ6cDs cc84o1OJgur8p0AfCJ4DAW61M7/skqauZqRL0YxJkWb9PdD2u4kl9yRRgkWzaTnRaKWl y+yk+PU6a3pHVOFPJ0pT+7tPsaOVXeuYTUKY5f3kbgLrzEk/Z9sKbY4OQrUYSRk5n0jq l3u1SJD8jFpegh7RlYDkDzrHQXyrnjdyMJYzGH/yDOCiSFBpVKkeBT2dKypCnLHwT8qN gSrw== X-Gm-Message-State: AO0yUKVtTAjF8xSKqEaJNoBUAxgb52DUzpP1bjOzgAvQGyRuaiXiVtZq XCYd7euMAGbskCWxHA05kQ== X-Google-Smtp-Source: AK7set9tiuyo+JLiUNfNjG4cswyI/NX7Fs2lfJdk7bR1wtltnPuv7VveV/ORSiio5JbdRdOdZyls9w== X-Received: by 2002:a05:6808:60a:b0:37f:ab79:a198 with SMTP id y10-20020a056808060a00b0037fab79a198mr234978oih.27.1677531150184; Mon, 27 Feb 2023 12:52:30 -0800 (PST) Received: from robh_at_kernel.org (66-90-144-107.dyn.grandenetworks.net. [66.90.144.107]) by smtp.gmail.com with ESMTPSA id j126-20020acab984000000b00369a721732asm3546861oif.41.2023.02.27.12.52.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Feb 2023 12:52:29 -0800 (PST) Received: (nullmailer pid 894886 invoked by uid 1000); Mon, 27 Feb 2023 20:52:29 -0000 Date: Mon, 27 Feb 2023 14:52:29 -0600 From: Rob Herring To: "Peng Fan (OSS)" Cc: gregkh@linuxfoundation.org, krzysztof.kozlowski+dt@linaro.org, shawnguo@kernel.org, s.hauer@pengutronix.de, xu.yang_2@nxp.com, kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com, linux-usb@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, jun.li@nxp.com, Peng Fan Subject: Re: [PATCH V3 1/7] dt-bindings: usb: usbmisc-imx: convert to DT schema Message-ID: <20230227205229.GA880857-robh@kernel.org> References: <20230226130539.277336-1-peng.fan@oss.nxp.com> <20230226130539.277336-2-peng.fan@oss.nxp.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230226130539.277336-2-peng.fan@oss.nxp.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230227_125237_094404_51424464 X-CRM114-Status: GOOD ( 22.87 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sun, Feb 26, 2023 at 09:05:33PM +0800, Peng Fan (OSS) wrote: > From: Peng Fan > > Convert usbmisc-imx to DT schema format. > > Signed-off-by: Peng Fan > --- > .../devicetree/bindings/usb/fsl,usbmisc.yaml | 54 +++++++++++++++++++ > .../devicetree/bindings/usb/usbmisc-imx.txt | 19 ------- > 2 files changed, 54 insertions(+), 19 deletions(-) > create mode 100644 Documentation/devicetree/bindings/usb/fsl,usbmisc.yaml > delete mode 100644 Documentation/devicetree/bindings/usb/usbmisc-imx.txt > > diff --git a/Documentation/devicetree/bindings/usb/fsl,usbmisc.yaml b/Documentation/devicetree/bindings/usb/fsl,usbmisc.yaml > new file mode 100644 > index 000000000000..517390b9d2c6 > --- /dev/null > +++ b/Documentation/devicetree/bindings/usb/fsl,usbmisc.yaml > @@ -0,0 +1,54 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/usb/fsl,usbmisc.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Freescale i.MX wrapper module for Chipidea USB2 controller > + > +maintainers: > + - Xu Yang > + - Peng Fan > + > +properties: > + compatible: > + oneOf: > + - enum: > + - fsl,imx6q-usbmisc > + - fsl,imx7ulp-usbmisc > + - fsl,vf610-usbmisc > + - items: > + - enum: > + - fsl,imx6ul-usbmisc > + - fsl,imx6sx-usbmisc > + - fsl,imx7d-usbmisc > + - const: fsl,imx6q-usbmisc > + - items: > + - enum: > + - fsl,imx7ulp-usbmisc > + - fsl,imx8mm-usbmisc > + - const: fsl,imx7d-usbmisc So imx8mm is compatible with imx7d, and imx7d is compatible with imx6q, but imx8mm is not compatible with imx6q? That doesn't really make sense. Maybe all 3 compatibles makes sense, but only if s/w understanding only one of the fallback compatibles would function without knowledge of the newer h/w. > + > + reg: > + maxItems: 1 > + > + '#index-cells': > + const: 1 > + description: Cells used to describe usb controller index. Please mark this as deprecated. If it is always 1 cell, then there's no point. > + > +required: > + - compatible > + - reg > + - '#index-cells' And drop as required. That all can be a follow-up patch if you prefer or in this patch is fine. Primarily, I don't want this pattern copied. > + > +additionalProperties: false > + > +examples: > + - | > + usbmisc@2184800 { > + #index-cells = <1>; > + compatible = "fsl,imx6q-usbmisc"; > + reg = <0x02184800 0x200>; > + }; > + > +... > diff --git a/Documentation/devicetree/bindings/usb/usbmisc-imx.txt b/Documentation/devicetree/bindings/usb/usbmisc-imx.txt > deleted file mode 100644 > index 29b8f65ff849..000000000000 > --- a/Documentation/devicetree/bindings/usb/usbmisc-imx.txt > +++ /dev/null > @@ -1,19 +0,0 @@ > -* Freescale i.MX non-core registers > - > -Required properties: > -- #index-cells: Cells used to describe usb controller index. Should be <1> > -- compatible: Should be one of below: > - "fsl,imx6q-usbmisc" for imx6q > - "fsl,vf610-usbmisc" for Vybrid vf610 > - "fsl,imx6sx-usbmisc" for imx6sx > - "fsl,imx7d-usbmisc" for imx7d > - "fsl,imx7ulp-usbmisc" for imx7ulp > - "fsl,imx8mm-usbmisc" for imx8mm > -- reg: Should contain registers location and length > - > -Examples: > -usbmisc@2184800 { > - #index-cells = <1>; > - compatible = "fsl,imx6q-usbmisc"; > - reg = <0x02184800 0x200>; > -}; > -- > 2.37.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel