From: Marco Felsch <m.felsch@pengutronix.de>
To: Alexander Stein <alexander.stein@ew.tq-group.com>
Cc: Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>,
devicetree@vger.kernel.org, NXP Linux Team <linux-imx@nxp.com>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 1/1] arm64: dts: imx93: Add FlexSPI support
Date: Tue, 28 Feb 2023 10:21:47 +0100 [thread overview]
Message-ID: <20230228092147.joryf6rfebsamxbn@pengutronix.de> (raw)
In-Reply-To: <20230228091757.381583-1-alexander.stein@ew.tq-group.com>
Hi Alexander,
On 23-02-28, Alexander Stein wrote:
> Add FlexSPI node for i.MX93.
>
> Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
> ---
> Changes in v2:
> * Move 'compatible' and 'reg*' properties to top location
>
> arch/arm64/boot/dts/freescale/imx93.dtsi | 15 +++++++++++++++
> 1 file changed, 15 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/freescale/imx93.dtsi b/arch/arm64/boot/dts/freescale/imx93.dtsi
> index 64901ae10b2c..dccbcedf0206 100644
> --- a/arch/arm64/boot/dts/freescale/imx93.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx93.dtsi
> @@ -458,6 +458,21 @@ flexcan2: can@425b0000 {
> status = "disabled";
> };
>
> + flexspi1: spi@425e0000 {
> + compatible = "nxp,imx8mm-fspi";
> + reg = <0x425e0000 0x10000>, <0x28000000 0x10000000>;
> + reg-names = "fspi_base", "fspi_mmap";
> + #address-cells = <1>;
> + #size-cells = <0>;
> + interrupts = <GIC_SPI 55 IRQ_TYPE_LEVEL_HIGH>;
> + clocks = <&clk IMX93_CLK_FLEXSPI1_GATE>,
> + <&clk IMX93_CLK_FLEXSPI1_GATE>;
> + clock-names = "fspi_en", "fspi";
> + assigned-clocks = <&clk IMX93_CLK_FLEXSPI1>;
> + assigned-clock-parents = <&clk IMX93_CLK_SYS_PLL_PFD1>;
> + status = "disabled";
> + };
Don't have the RM to verify the node but from style pov lgtm now :)
Regards,
Marco
> +
> lpuart7: serial@42690000 {
> compatible = "fsl,imx93-lpuart", "fsl,imx7ulp-lpuart";
> reg = <0x42690000 0x1000>;
> --
> 2.34.1
>
>
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-02-28 9:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-28 9:17 [PATCH v2 1/1] arm64: dts: imx93: Add FlexSPI support Alexander Stein
2023-02-28 9:21 ` Marco Felsch [this message]
2023-03-14 3:21 ` Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230228092147.joryf6rfebsamxbn@pengutronix.de \
--to=m.felsch@pengutronix.de \
--cc=alexander.stein@ew.tq-group.com \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=kernel@pengutronix.de \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).