* [PATCH 2/2] arm64: dts: rockchip: rk3588: Add sdmmc node
2023-02-13 15:27 [PATCH 1/2] dt-bindings: mmc: rockchip-dw-mshc: Add RK3588 compatible string Lucas Tanure
@ 2023-02-13 15:27 ` Lucas Tanure
2023-02-28 10:36 ` [PATCH v2] " Lucas Tanure
2023-02-13 15:43 ` [PATCH 1/2] dt-bindings: mmc: rockchip-dw-mshc: Add RK3588 compatible string Krzysztof Kozlowski
` (2 subsequent siblings)
3 siblings, 1 reply; 7+ messages in thread
From: Lucas Tanure @ 2023-02-13 15:27 UTC (permalink / raw)
To: Ulf Hansson, Rob Herring, Krzysztof Kozlowski, Heiko Stuebner,
Shawn Lin
Cc: linux-mmc, linux-arm-kernel, linux-rockchip, devicetree,
linux-kernel, Lucas Tanure, kernel
Add SD Card node for RK3588s and RK3588.
Co-developed-by: Shawn Lin <shawn.lin@rock-chips.com>
Signed-off-by: Shawn Lin <shawn.lin@rock-chips.com>
Signed-off-by: Lucas Tanure <lucas.tanure@collabora.com>
---
arch/arm64/boot/dts/rockchip/rk3588s.dtsi | 15 +++++++++++++++
1 file changed, 15 insertions(+)
diff --git a/arch/arm64/boot/dts/rockchip/rk3588s.dtsi b/arch/arm64/boot/dts/rockchip/rk3588s.dtsi
index 005cde61b4b2..fca8503aed8c 100644
--- a/arch/arm64/boot/dts/rockchip/rk3588s.dtsi
+++ b/arch/arm64/boot/dts/rockchip/rk3588s.dtsi
@@ -1099,6 +1099,21 @@ gmac1_mtl_tx_setup: tx-queues-config {
};
};
+ sdmmc: mmc@fe2c0000 {
+ compatible = "rockchip,rk3588-dw-mshc", "rockchip,rk3288-dw-mshc";
+ reg = <0x0 0xfe2c0000 0x0 0x4000>;
+ interrupts = <GIC_SPI 203 IRQ_TYPE_LEVEL_HIGH 0>;
+ clocks = <&scmi_clk SCMI_HCLK_SD>, <&scmi_clk SCMI_CCLK_SD>,
+ <&cru SCLK_SDMMC_DRV>, <&cru SCLK_SDMMC_SAMPLE>;
+ clock-names = "biu", "ciu", "ciu-drive", "ciu-sample";
+ fifo-depth = <0x100>;
+ max-frequency = <200000000>;
+ pinctrl-names = "default";
+ pinctrl-0 = <&sdmmc_clk &sdmmc_cmd &sdmmc_det &sdmmc_bus4>;
+ power-domains = <&power RK3588_PD_SDMMC>;
+ status = "disabled";
+ };
+
sdhci: mmc@fe2e0000 {
compatible = "rockchip,rk3588-dwcmshc";
reg = <0x0 0xfe2e0000 0x0 0x10000>;
--
2.39.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 7+ messages in thread* [PATCH v2] arm64: dts: rockchip: rk3588: Add sdmmc node
2023-02-13 15:27 ` [PATCH 2/2] arm64: dts: rockchip: rk3588: Add sdmmc node Lucas Tanure
@ 2023-02-28 10:36 ` Lucas Tanure
2023-03-07 23:35 ` Heiko Stuebner
0 siblings, 1 reply; 7+ messages in thread
From: Lucas Tanure @ 2023-02-28 10:36 UTC (permalink / raw)
To: lucas.tanure
Cc: devicetree, heiko, kernel, krzysztof.kozlowski+dt,
linux-arm-kernel, linux-kernel, linux-mmc, linux-rockchip,
robh+dt, shawn.lin, ulf.hansson
Add SD Card node for RK3588s and RK3588.
Co-developed-by: Shawn Lin <shawn.lin@rock-chips.com>
Signed-off-by: Shawn Lin <shawn.lin@rock-chips.com>
Signed-off-by: Lucas Tanure <lucas.tanure@collabora.com>
---
Changes Since v1:
None. Re-submitting this patch alone as the first patch of this series was
already accepted.
---
arch/arm64/boot/dts/rockchip/rk3588s.dtsi | 15 +++++++++++++++
1 file changed, 15 insertions(+)
diff --git a/arch/arm64/boot/dts/rockchip/rk3588s.dtsi b/arch/arm64/boot/dts/rockchip/rk3588s.dtsi
index 005cde61b4b2..fca8503aed8c 100644
--- a/arch/arm64/boot/dts/rockchip/rk3588s.dtsi
+++ b/arch/arm64/boot/dts/rockchip/rk3588s.dtsi
@@ -1099,6 +1099,21 @@ gmac1_mtl_tx_setup: tx-queues-config {
};
};
+ sdmmc: mmc@fe2c0000 {
+ compatible = "rockchip,rk3588-dw-mshc", "rockchip,rk3288-dw-mshc";
+ reg = <0x0 0xfe2c0000 0x0 0x4000>;
+ interrupts = <GIC_SPI 203 IRQ_TYPE_LEVEL_HIGH 0>;
+ clocks = <&scmi_clk SCMI_HCLK_SD>, <&scmi_clk SCMI_CCLK_SD>,
+ <&cru SCLK_SDMMC_DRV>, <&cru SCLK_SDMMC_SAMPLE>;
+ clock-names = "biu", "ciu", "ciu-drive", "ciu-sample";
+ fifo-depth = <0x100>;
+ max-frequency = <200000000>;
+ pinctrl-names = "default";
+ pinctrl-0 = <&sdmmc_clk &sdmmc_cmd &sdmmc_det &sdmmc_bus4>;
+ power-domains = <&power RK3588_PD_SDMMC>;
+ status = "disabled";
+ };
+
sdhci: mmc@fe2e0000 {
compatible = "rockchip,rk3588-dwcmshc";
reg = <0x0 0xfe2e0000 0x0 0x10000>;
--
2.39.2
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 7+ messages in thread* Re: [PATCH v2] arm64: dts: rockchip: rk3588: Add sdmmc node
2023-02-28 10:36 ` [PATCH v2] " Lucas Tanure
@ 2023-03-07 23:35 ` Heiko Stuebner
0 siblings, 0 replies; 7+ messages in thread
From: Heiko Stuebner @ 2023-03-07 23:35 UTC (permalink / raw)
To: Lucas Tanure
Cc: Heiko Stuebner, devicetree, linux-arm-kernel, shawn.lin,
linux-rockchip, robh+dt, ulf.hansson, linux-kernel,
krzysztof.kozlowski+dt, kernel, linux-mmc
On Tue, 28 Feb 2023 10:36:10 +0000, Lucas Tanure wrote:
> Add SD Card node for RK3588s and RK3588.
>
>
Applied, thanks!
[1/1] arm64: dts: rockchip: rk3588: Add sdmmc node
commit: dbe406d1397ffccd4a0f85daef456291f265505a
Best regards,
--
Heiko Stuebner <heiko@sntech.de>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 1/2] dt-bindings: mmc: rockchip-dw-mshc: Add RK3588 compatible string
2023-02-13 15:27 [PATCH 1/2] dt-bindings: mmc: rockchip-dw-mshc: Add RK3588 compatible string Lucas Tanure
2023-02-13 15:27 ` [PATCH 2/2] arm64: dts: rockchip: rk3588: Add sdmmc node Lucas Tanure
@ 2023-02-13 15:43 ` Krzysztof Kozlowski
2023-02-13 16:36 ` Heiko Stübner
2023-02-14 12:18 ` Ulf Hansson
3 siblings, 0 replies; 7+ messages in thread
From: Krzysztof Kozlowski @ 2023-02-13 15:43 UTC (permalink / raw)
To: Lucas Tanure, Ulf Hansson, Rob Herring, Krzysztof Kozlowski,
Heiko Stuebner, Shawn Lin
Cc: linux-mmc, linux-arm-kernel, linux-rockchip, devicetree,
linux-kernel, kernel
On 13/02/2023 16:27, Lucas Tanure wrote:
> Add RK3588 compatible string for SD interface.
>
> Co-developed-by: Shawn Lin <shawn.lin@rock-chips.com>
> Signed-off-by: Shawn Lin <shawn.lin@rock-chips.com>
> Signed-off-by: Lucas Tanure <lucas.tanure@collabora.com>
> ---
> Documentation/devicetree/bindings/mmc/rockchip-dw-mshc.yaml | 1 +
Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards,
Krzysztof
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 1/2] dt-bindings: mmc: rockchip-dw-mshc: Add RK3588 compatible string
2023-02-13 15:27 [PATCH 1/2] dt-bindings: mmc: rockchip-dw-mshc: Add RK3588 compatible string Lucas Tanure
2023-02-13 15:27 ` [PATCH 2/2] arm64: dts: rockchip: rk3588: Add sdmmc node Lucas Tanure
2023-02-13 15:43 ` [PATCH 1/2] dt-bindings: mmc: rockchip-dw-mshc: Add RK3588 compatible string Krzysztof Kozlowski
@ 2023-02-13 16:36 ` Heiko Stübner
2023-02-14 12:18 ` Ulf Hansson
3 siblings, 0 replies; 7+ messages in thread
From: Heiko Stübner @ 2023-02-13 16:36 UTC (permalink / raw)
To: Ulf Hansson, Rob Herring, Krzysztof Kozlowski, Shawn Lin,
Lucas Tanure
Cc: linux-mmc, linux-arm-kernel, linux-rockchip, devicetree,
linux-kernel, Lucas Tanure, kernel
Am Montag, 13. Februar 2023, 16:27:39 CET schrieb Lucas Tanure:
> Add RK3588 compatible string for SD interface.
>
> Co-developed-by: Shawn Lin <shawn.lin@rock-chips.com>
> Signed-off-by: Shawn Lin <shawn.lin@rock-chips.com>
> Signed-off-by: Lucas Tanure <lucas.tanure@collabora.com>
Reviewed-by: Heiko Stuebner <heiko@sntech.de>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 1/2] dt-bindings: mmc: rockchip-dw-mshc: Add RK3588 compatible string
2023-02-13 15:27 [PATCH 1/2] dt-bindings: mmc: rockchip-dw-mshc: Add RK3588 compatible string Lucas Tanure
` (2 preceding siblings ...)
2023-02-13 16:36 ` Heiko Stübner
@ 2023-02-14 12:18 ` Ulf Hansson
3 siblings, 0 replies; 7+ messages in thread
From: Ulf Hansson @ 2023-02-14 12:18 UTC (permalink / raw)
To: Lucas Tanure
Cc: Rob Herring, Krzysztof Kozlowski, Heiko Stuebner, Shawn Lin,
linux-mmc, linux-arm-kernel, linux-rockchip, devicetree,
linux-kernel, kernel
On Mon, 13 Feb 2023 at 16:27, Lucas Tanure <lucas.tanure@collabora.com> wrote:
>
> Add RK3588 compatible string for SD interface.
>
> Co-developed-by: Shawn Lin <shawn.lin@rock-chips.com>
> Signed-off-by: Shawn Lin <shawn.lin@rock-chips.com>
> Signed-off-by: Lucas Tanure <lucas.tanure@collabora.com>
Applied for next, thanks!
Kind regards
Uffe
> ---
> Documentation/devicetree/bindings/mmc/rockchip-dw-mshc.yaml | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/devicetree/bindings/mmc/rockchip-dw-mshc.yaml b/Documentation/devicetree/bindings/mmc/rockchip-dw-mshc.yaml
> index 67d7223f74da..211cd0b0bc5f 100644
> --- a/Documentation/devicetree/bindings/mmc/rockchip-dw-mshc.yaml
> +++ b/Documentation/devicetree/bindings/mmc/rockchip-dw-mshc.yaml
> @@ -39,6 +39,7 @@ properties:
> - rockchip,rk3368-dw-mshc
> - rockchip,rk3399-dw-mshc
> - rockchip,rk3568-dw-mshc
> + - rockchip,rk3588-dw-mshc
> - rockchip,rv1108-dw-mshc
> - rockchip,rv1126-dw-mshc
> - const: rockchip,rk3288-dw-mshc
> --
> 2.39.1
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 7+ messages in thread