From: Tanmay Shah <tanmay.shah@amd.com>
To: <michal.simek@amd.com>, <andersson@kernel.org>,
<mathieu.poirier@linaro.org>, <jaswinder.singh@linaro.org>,
<ben.levinsky@amd.com>, <shubhrajyoti.datta@amd.com>
Cc: <linux-kernel@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-remoteproc@vger.kernel.org>,
Tanmay Shah <tanmay.shah@amd.com>
Subject: [PATCH v4 2/5] mailbox: zynqmp: fix IPI isr handling
Date: Tue, 28 Feb 2023 13:02:13 -0800 [thread overview]
Message-ID: <20230228210216.447373-3-tanmay.shah@amd.com> (raw)
In-Reply-To: <20230228210216.447373-1-tanmay.shah@amd.com>
Multiple IPI channels are mapped to same interrupt handler.
Current isr implementation handles only one channel per isr.
Fix this behavior by checking isr status bit of all child
mailbox nodes.
Signed-off-by: Tanmay Shah <tanmay.shah@amd.com>
---
drivers/mailbox/zynqmp-ipi-mailbox.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/mailbox/zynqmp-ipi-mailbox.c b/drivers/mailbox/zynqmp-ipi-mailbox.c
index e287ed7a92ce..b1498f6f06e1 100644
--- a/drivers/mailbox/zynqmp-ipi-mailbox.c
+++ b/drivers/mailbox/zynqmp-ipi-mailbox.c
@@ -152,7 +152,7 @@ static irqreturn_t zynqmp_ipi_interrupt(int irq, void *data)
struct zynqmp_ipi_message *msg;
u64 arg0, arg3;
struct arm_smccc_res res;
- int ret, i;
+ int ret, i, status = IRQ_NONE;
(void)irq;
arg0 = SMC_IPI_MAILBOX_STATUS_ENQUIRY;
@@ -170,11 +170,11 @@ static irqreturn_t zynqmp_ipi_interrupt(int irq, void *data)
memcpy_fromio(msg->data, mchan->req_buf,
msg->len);
mbox_chan_received_data(chan, (void *)msg);
- return IRQ_HANDLED;
+ status = IRQ_HANDLED;
}
}
}
- return IRQ_NONE;
+ return status;
}
/**
--
2.25.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-02-28 21:04 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-28 21:02 [PATCH v4 0/5] drivers: remoteproc: xilinx: add mailbox support Tanmay Shah
2023-02-28 21:02 ` [PATCH v4 1/5] mailbox: zynqmp: fix counts of child nodes Tanmay Shah
2023-03-08 11:53 ` Michal Simek
2023-03-09 20:30 ` Tanmay Shah
2023-02-28 21:02 ` Tanmay Shah [this message]
2023-03-08 11:56 ` [PATCH v4 2/5] mailbox: zynqmp: fix IPI isr handling Michal Simek
2023-02-28 21:02 ` [PATCH v4 3/5] mailbox: zynqmp: fix typo in IPI documentation Tanmay Shah
2023-03-08 11:56 ` Michal Simek
2023-02-28 21:02 ` [PATCH v4 4/5] drivers: remoteproc: xilinx: fix carveout names Tanmay Shah
2023-02-28 21:02 ` [PATCH v4 5/5] remoteproc: xilinx: add mailbox channels for rpmsg Tanmay Shah
2023-03-02 23:10 ` Mathieu Poirier
2023-03-03 16:36 ` Tanmay Shah
2023-03-03 18:13 ` Mathieu Poirier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230228210216.447373-3-tanmay.shah@amd.com \
--to=tanmay.shah@amd.com \
--cc=andersson@kernel.org \
--cc=ben.levinsky@amd.com \
--cc=jaswinder.singh@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=mathieu.poirier@linaro.org \
--cc=michal.simek@amd.com \
--cc=shubhrajyoti.datta@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).