From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 24AE1C64EC4 for ; Tue, 28 Feb 2023 21:04:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:CC:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=P+wccR1Yf+VuSQLAopOeyMN+3OqP3/W5P/O6wPS/5b8=; b=TI1xsyQmbUEYbU pImeQF2wA2hBzMspKl+evP6My/dctIPnR7Unayv/m3k7nuzM2m/vxd/CCvrZ1J9jZMugNiDXvOvj4 hIPGe0Ai8Zd4fUWyDs/fwnx/MOvWSCZMF/aqDnwJ5xN2/QtPLHljeTi003EDrNxaKdWjStATDwpxC o7JCvjoVo0OVmcA3hPkR4syMhF/U9D0pY6gC6Uv89bOv4pHLtKg/NQhI6TI4s0HWibYWl1/ZFrNUd kAvzVWbcA/IM7921FQ23z1f/KhmwFutG7dBYESU0PgeJrRWwcbfJ23DH0McGvzerpgJG6kH67RpU6 AVz8R6Vfl/PCGFATjPSw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pX77k-00EGPn-12; Tue, 28 Feb 2023 21:03:00 +0000 Received: from mail-co1nam11on20625.outbound.protection.outlook.com ([2a01:111:f400:7eab::625] helo=NAM11-CO1-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pX77I-00EGIO-36 for linux-arm-kernel@lists.infradead.org; Tue, 28 Feb 2023 21:02:35 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=JonRgnHi5SSpTGgMLRhf8mxg+0NnwMTCbN1yrGPdAhXp1kr0bijbUIrvNCISwFz8vSMQ6xLgSdi+Kq8/W2yPwSf49H02hw9TuWq0kifKzWUoyOjL8MlHighv7JmRuoNj6rzr0CZPtUkK4IO11fQPAQTTE2VTXhyqxFhJDB4LyiCWcUiY4emLjPkaVz8a7VQjVd1sn0QKCLyJd95ZkJ2hDkYVMps4bbccoqftU+MwnwuzfT/Tnt/i0ASJeICgNFOAgDZHOQVfOZlL69UeLBCgegzamMG4hKZIi4X6cDLBKhiaIc6HH76IHRTziLaySPresvq3Xu1a++0k6PEdP2y37g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=8ZZbFSCii/bEzZuwFiGNigWIcDZEsXJksoL1k+8ANIo=; b=bamowe3dv2LWTISJqUxVFrWo9s5MTsjqRMEv9y+aJtPeyirBEzUqn6ripbqGZjApHyuaczh1vhynJ5I/lRY85gLoIeAN37bH8LIQZLrxTqNFlGRnWELpI8tbDapxCu/fj1DnxEbB1rQUUGYJU6Ar4VQDU4pE8uMlThUR6b77Wl3t7G1r4LiiYIYKTM3UieyNmtm1wytc0C5qBYUr0JyoV2QgPeuZVXYgyGZaVCSfI0cpyxrH2pddxKhqa1kuqhnIC5Hl3L5nhWRAaYWPZJl7sWDNYtt8iYQRqd9LE7EXyMzfA72kgs028r/tlmtSpjyT/o5zPJmI7bay6vWyDydd1g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=kernel.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=8ZZbFSCii/bEzZuwFiGNigWIcDZEsXJksoL1k+8ANIo=; b=3e5oM2R9oA8t9tculmjXxqDZPVEnzDummCihNupr7760/tes2h4z0YXSTsJOAQlZeGcT9Nbmkc4z+BdGvdFSYJ+pwEy500lf2nIOUaMbPb6wQPyIuH8QX4fMahiywBUyAY6k5pp0R1eeMJJ5CVP1LV+WMd84Krzne1TCmgB5rzU= Received: from DM5PR07CA0087.namprd07.prod.outlook.com (2603:10b6:4:ae::16) by IA0PR12MB8424.namprd12.prod.outlook.com (2603:10b6:208:40c::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6134.30; Tue, 28 Feb 2023 21:02:27 +0000 Received: from DM6NAM11FT018.eop-nam11.prod.protection.outlook.com (2603:10b6:4:ae:cafe::88) by DM5PR07CA0087.outlook.office365.com (2603:10b6:4:ae::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6134.30 via Frontend Transport; Tue, 28 Feb 2023 21:02:27 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB03.amd.com; pr=C Received: from SATLEXMB03.amd.com (165.204.84.17) by DM6NAM11FT018.mail.protection.outlook.com (10.13.172.110) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.6156.17 via Frontend Transport; Tue, 28 Feb 2023 21:02:27 +0000 Received: from SATLEXMB03.amd.com (10.181.40.144) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Tue, 28 Feb 2023 15:02:22 -0600 Received: from xsjtanmays50.xilinx.com (10.180.168.240) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server id 15.1.2375.34 via Frontend Transport; Tue, 28 Feb 2023 15:02:22 -0600 From: Tanmay Shah To: , , , , , CC: , , , Tanmay Shah Subject: [PATCH v4 2/5] mailbox: zynqmp: fix IPI isr handling Date: Tue, 28 Feb 2023 13:02:13 -0800 Message-ID: <20230228210216.447373-3-tanmay.shah@amd.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230228210216.447373-1-tanmay.shah@amd.com> References: <20230228210216.447373-1-tanmay.shah@amd.com> MIME-Version: 1.0 X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM6NAM11FT018:EE_|IA0PR12MB8424:EE_ X-MS-Office365-Filtering-Correlation-Id: 0de68b8c-f6a0-426c-f4b7-08db19cf192b X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: rkaM2PWXt2rnZuGz2PuApCq3ImCZO+xx2FIQoGedOVhfCT/0diTjbAj5WVllDBgHKYX3eq+3szf8SVZh2GzYr+iCtrkYl44CeVH18C01izIQV2/idE+0Rb+QdMaaTkjvGKfktLJx23GIdB7+ZkSuxpHXJ1ccOq3rcnPM8eK2SPorW0piyQ+LZRC0c8I77m7akgEa63obZiynxVI8FoN23lJV2ciS09dQ9QsggWJooho/B9DVEQIXanOyYIcu6saYcJUOqCgz3ZBbiD2drzElccaHkPbYVuK2WL5TE0Bg9uzu7y5iOE5x9MUrr3+KMT6UWpYjHXaTGYDXfPdVc95UWH1nc9WReU82SgSPrf+/Btj2lXyLPyjQ0lDxSuTMgDjkZ9H8tN7Pw38+EwOXw1H8tpU+IA0vKG0+/ZzOU+JeVgZxYxaUScKMYwHzkGXshduXB+jcFuQIPhCBGL0pCLMD7nJ28iCVdvPXHBeBM3YyebWQYom1LLYw826qLa1XYJBTuswpv4+YEIzSLiTTC0BnZR8yIDL1rvToSyCpaDBeDMKQqzGaamU9pQi5dADMRIDf7PxcdFf+XgENybLzNPduSPaArApze4+lPzsIAnwEuE40G6rT9g3pQdYnND5pPBBSyVxo9E6vVlldxwo9Z9tbgOq0rzy/0kWabc+la5/Ci6KL+kNNK8nSOXjrWykPNjj8Q+JfLekVMzPF2oqcUeq5zSv8a5eci8yUtavfS732Ha4= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB03.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230025)(4636009)(396003)(376002)(39860400002)(136003)(346002)(451199018)(40470700004)(36840700001)(46966006)(356005)(36860700001)(81166007)(82740400003)(86362001)(36756003)(2906002)(44832011)(15650500001)(40480700001)(8676002)(41300700001)(5660300002)(70206006)(8936002)(4326008)(70586007)(82310400005)(40460700003)(1076003)(2616005)(336012)(47076005)(426003)(110136005)(26005)(186003)(83380400001)(6636002)(478600001)(54906003)(316002)(6666004)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Feb 2023 21:02:27.3511 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 0de68b8c-f6a0-426c-f4b7-08db19cf192b X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB03.amd.com] X-MS-Exchange-CrossTenant-AuthSource: DM6NAM11FT018.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA0PR12MB8424 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230228_130232_150645_E3E4076A X-CRM114-Status: GOOD ( 11.72 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Multiple IPI channels are mapped to same interrupt handler. Current isr implementation handles only one channel per isr. Fix this behavior by checking isr status bit of all child mailbox nodes. Signed-off-by: Tanmay Shah --- drivers/mailbox/zynqmp-ipi-mailbox.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/mailbox/zynqmp-ipi-mailbox.c b/drivers/mailbox/zynqmp-ipi-mailbox.c index e287ed7a92ce..b1498f6f06e1 100644 --- a/drivers/mailbox/zynqmp-ipi-mailbox.c +++ b/drivers/mailbox/zynqmp-ipi-mailbox.c @@ -152,7 +152,7 @@ static irqreturn_t zynqmp_ipi_interrupt(int irq, void *data) struct zynqmp_ipi_message *msg; u64 arg0, arg3; struct arm_smccc_res res; - int ret, i; + int ret, i, status = IRQ_NONE; (void)irq; arg0 = SMC_IPI_MAILBOX_STATUS_ENQUIRY; @@ -170,11 +170,11 @@ static irqreturn_t zynqmp_ipi_interrupt(int irq, void *data) memcpy_fromio(msg->data, mchan->req_buf, msg->len); mbox_chan_received_data(chan, (void *)msg); - return IRQ_HANDLED; + status = IRQ_HANDLED; } } } - return IRQ_NONE; + return status; } /** -- 2.25.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel