From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1F0F1C678D4 for ; Thu, 2 Mar 2023 11:08:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:CC:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=mnzt8WcdpcjC684HaW+yWLgmkJQI9G0uzVBnI6icHD4=; b=zCBUkz5GlmEBKJ 8HBOP6EkdYZ0UUSVohdT5HtTpY7jwk4HvAHjsHtVkRWAfPDFQhNuOAgwwMj9SAvOhS9Vd/kafv+pf Wx2WlV9DdWtlNNCvPkpZEhhtLlIO17gTejolhDV1zH40ooywyXGv4wSnHhjViW75y4Ht27ylDBQMw p8AVdseIFdS+g77Uu/arw9Cxw6iGwkPvSwL8MIGSXy7bzsI1ih/jfSR/mO+ad4UfIIKrr9nmlao3/ Hv8+juwrK39XEdC1W9os7R2ikiBeFkRdxI2VTMZWjOzHXYFUs2GnRdU/8JjTMwSBB6KnehHgreEhZ 1sHC0sAm8/GjLt5aWIMg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pXgms-001psO-Hw; Thu, 02 Mar 2023 11:07:50 +0000 Received: from mail-vi1eur05on2062e.outbound.protection.outlook.com ([2a01:111:f400:7d00::62e] helo=EUR05-VI1-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pXgml-001pnE-RU for linux-arm-kernel@lists.infradead.org; Thu, 02 Mar 2023 11:07:45 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=OQ4crIVMT50AdDFTiFUyvJYKNuw63tAkStWsZ5GEMX8=; b=1RkOrbK1i6ncVwRH/Uqrc8iOmnivFsmfUpMVsUaYtybXxgrzLt5i9ncoe0Ve3ATH1AVoEh/g9Bb7y0qodHLJwjYaSUaEghOjlnFs2EQ90d5PHWj/K4hQTQVCnNfTFM2lwyTowZn3ecvHSbV9C3rixMpbsn80597nUhgq195bMM8= Received: from DB6PR0402CA0014.eurprd04.prod.outlook.com (2603:10a6:4:91::24) by PAXPR08MB7528.eurprd08.prod.outlook.com (2603:10a6:102:24e::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6156.18; Thu, 2 Mar 2023 11:07:35 +0000 Received: from DBAEUR03FT035.eop-EUR03.prod.protection.outlook.com (2603:10a6:4:91:cafe::14) by DB6PR0402CA0014.outlook.office365.com (2603:10a6:4:91::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6156.19 via Frontend Transport; Thu, 2 Mar 2023 11:07:35 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT035.mail.protection.outlook.com (100.127.142.136) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6156.19 via Frontend Transport; Thu, 2 Mar 2023 11:07:35 +0000 Received: ("Tessian outbound 0df938784972:v135"); Thu, 02 Mar 2023 11:07:34 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 76cfeb340727d869 X-CR-MTA-TID: 64aa7808 Received: from b340bb095a4c.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id B3F7A356-8443-4959-B286-424EEB20C9E8.1; Thu, 02 Mar 2023 11:07:28 +0000 Received: from EUR03-DBA-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id b340bb095a4c.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 02 Mar 2023 11:07:28 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fTF5k/bYCNGaLi3ktBBfgDmpbsQTy0+X6tO61Ym2/4xsu6lHIMbeWX4w2Mdp16Yr7wMI7X98dzGZcjIEGybwGZPR4sudG6ZL35UHJadb0ti7T1t839gP4wu8mLGo9JpsUVj5P3jg6KNBlTF4HQ57bPxFBqdgYe3jXMX4yGp8SQQEnGwrq48fTrf3BquKZnMmaZQ5I6nG5jwvcONmveSNCU9u0OOQrjfT4KEL7k94xaWF82bcDdNHpmoTmvchHPFH2To8EnQka8ZofxH+sJccaHbLnLTLuzvDFsqKjhbvAaKgwKPDZHrsG0aJCHBVLb0R2fcyrEYyz4NdOf6IwNKAdA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=OQ4crIVMT50AdDFTiFUyvJYKNuw63tAkStWsZ5GEMX8=; b=d6WXr13jo7I/zJkrk5T0db2RSWJrLebMGQT1YRVVzgJv3DYUzzel7FPZIOrPY9WKI0XAhqnnmi0ZD83NosJKLm0Km7QOb0AkQh9p3sS882SQxpU8VXX4u8Ywzp3KQWvHTqQEN/z8ux05AeQuDbUbG04nXVZ9TNvJIu8tt03OypPpBymuh6Ke2KohtdYxNVf4K2dyj35FhM93LIoDEli+JSlqs8i/h7e1AuCZ4My2lVqU7pGY8S83QzLN/zk3MexBMCBPM4lTS8rhJZJpO7SMTpZIReYn+jL+oLhoKNt7FHYU7em9e07HI9l51+U2radVthjgXjL2z4Atum6UnAhebg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 40.67.248.234) smtp.rcpttodomain=redhat.com smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=OQ4crIVMT50AdDFTiFUyvJYKNuw63tAkStWsZ5GEMX8=; b=1RkOrbK1i6ncVwRH/Uqrc8iOmnivFsmfUpMVsUaYtybXxgrzLt5i9ncoe0Ve3ATH1AVoEh/g9Bb7y0qodHLJwjYaSUaEghOjlnFs2EQ90d5PHWj/K4hQTQVCnNfTFM2lwyTowZn3ecvHSbV9C3rixMpbsn80597nUhgq195bMM8= Received: from DU2PR04CA0304.eurprd04.prod.outlook.com (2603:10a6:10:2b5::9) by AS2PR08MB8952.eurprd08.prod.outlook.com (2603:10a6:20b:5fb::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6156.17; Thu, 2 Mar 2023 11:07:24 +0000 Received: from DBAEUR03FT014.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:2b5:cafe::7) by DU2PR04CA0304.outlook.office365.com (2603:10a6:10:2b5::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6156.18 via Frontend Transport; Thu, 2 Mar 2023 11:07:24 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 40.67.248.234) smtp.mailfrom=arm.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 40.67.248.234 as permitted sender) receiver=protection.outlook.com; client-ip=40.67.248.234; helo=nebula.arm.com; pr=C Received: from nebula.arm.com (40.67.248.234) by DBAEUR03FT014.mail.protection.outlook.com (100.127.143.22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.6156.19 via Frontend Transport; Thu, 2 Mar 2023 11:07:24 +0000 Received: from AZ-NEU-EX02.Emea.Arm.com (10.251.26.5) by AZ-NEU-EX03.Arm.com (10.251.24.31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.17; Thu, 2 Mar 2023 11:07:23 +0000 Received: from AZ-NEU-EX03.Arm.com (10.251.24.31) by AZ-NEU-EX02.Emea.Arm.com (10.251.26.5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.17; Thu, 2 Mar 2023 11:07:22 +0000 Received: from e124191.cambridge.arm.com (10.1.197.45) by mail.arm.com (10.251.24.31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.17 via Frontend Transport; Thu, 2 Mar 2023 11:07:22 +0000 Date: Thu, 2 Mar 2023 11:07:21 +0000 From: Joey Gouly To: Peter Xu CC: Catalin Marinas , Andrew Morton , Lennart Poettering , Zbigniew =?utf-8?Q?J=C4=99drzejewski-Szmek?= , "Alexander Viro" , Kees Cook , "Szabolcs Nagy" , Mark Brown , Jeremy Linton , Topi Miettinen , , , , , , , Arnaldo Carvalho de Melo Subject: Re: [PATCH v2 2/2] kselftest: vm: add tests for memory-deny-write-execute Message-ID: <20230302110721.GA4476@e124191.cambridge.arm.com> References: <20230119160344.54358-1-joey.gouly@arm.com> <20230119160344.54358-3-joey.gouly@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) X-EOPAttributedMessage: 1 X-MS-TrafficTypeDiagnostic: DBAEUR03FT014:EE_|AS2PR08MB8952:EE_|DBAEUR03FT035:EE_|PAXPR08MB7528:EE_ X-MS-Office365-Filtering-Correlation-Id: 61c583e7-61cb-4b2a-2254-08db1b0e53c9 x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: 4pw66NlTRgOnMUk0rXZQQ+grD4rIlSdzr98qp2eb6549VD5XPN/9wmJ0Pic+Qf6CvWk9ZOiDukMKqRRLCwjIrQFsIuEGxAqBGfVe9C2mjJHrxnsvNabMIA8HXwM66YB7TtypzZ3hE1CHaZcCJvbgIFqhCOv23LvtOxSWNEK9LXnToNVdrqcrz4USs8dpvUAhiTwGVa+dWaYx5wmQWXdo0huWfE1MZ5P8ZpaSCuN4fXX69EraC0MPylcqXxi9LHQIi4TiQ7qoxmeqvHQgB0VoDXFZLb+4CKoygr4WCuggr/vlzmwVY5yieZf+CdV8akuqapIpTDqpfLiriwTpajvRBncwXC22ntBrJtcsVwKy7U/AXjMlGAIwzCrNYjvK91hcy7oK/FNGAxWd1mTIR1+/kJk3B2ITV5Zp1OILSKo8nIFlxzg9YN7su88AXdc6v6Di3I94tXXPfIAWelFVRq4v0gCcUW8k7qH3u+BMMJKlsh/vr6cHFvOPqeZPQyBspB2XXdDNyhWdkSZYGBOOgfZX57wEe09NREDmd87Ibf8u58fU7a+WqbmJ5Z1TP5SCyhS9h60e0QoDatjjti+lyyVP0UmfIIH2EKo3CN6Op+Vc0B0nuMCXPiSiQM90iN3L3+wwnPoL2IVYRB5ufJmrpbL9P0vai9SpaN3ON/9JDIyHPL60ibzafwgwi3n8z/Yj/vtEJR1u86kAPSGef82/RNeTw1nHVev9nJlArdw9K9MotSU= X-Forefront-Antispam-Report-Untrusted: CIP:40.67.248.234;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:nebula.arm.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230025)(4636009)(136003)(346002)(39860400002)(376002)(396003)(451199018)(46966006)(40470700004)(36840700001)(8936002)(36860700001)(81166007)(5660300002)(82310400005)(7416002)(4326008)(8676002)(44832011)(6916009)(41300700001)(82740400003)(70206006)(70586007)(55016003)(478600001)(7696005)(54906003)(40460700003)(33656002)(47076005)(2906002)(426003)(83380400001)(336012)(356005)(1076003)(53546011)(26005)(86362001)(40480700001)(316002)(186003)(36900700001);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS2PR08MB8952 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT035.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: a78036c7-1141-4c77-996c-08db1b0e4d65 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: MCFwWGqeSRXwCZu5VR0VDGfAast4SfPHv71SXwo+1puMJ792nVmgq1tG1Nfs/KnMPDwiQLZqa0nqxOuFCz8BhcNAlTCdN1/DRnvv/RY/4NzfLjLzkUmnQN+Rbnw2Cm/tbbLT7dEmeuqh/mjeZlTObCsyfKQOXtf50wH4R82rQzeG6KkElCiSzo5iPo7gsyP6XhzieiQu+iEkWnTOxpUz0Iipw357ndXYifYgKYoajIZ4F7lAKZFlh6L7R/N7ifNik+CDeAg0uZxyomIRLmsrticBJZMm/8Fue45YXr6se/2zheTS0A1BQDyCFJZZC6zMWdP/I6Z+pFgyYOINe0A1E8Jto/EoO3fGzCQY+1PiVRxeKGIyAWs+PV7p6HYI7sNeUymeydCsg2slIrMMvZKu27A/QmLPCIHePdV5rcGvVIUkFOy5Ge6q/9xFMYkZ3PINZBphXdQ0q8xlQbPvZ4S4UV2YgQurW6w/VN4u6fCGsCvQHgzNdet1KsKDyFrVt+/0PgdqBtYE6hJjr4X7fhg6rhBQ0MsrVEYBPpv5C71E66GKZT7DGHtPlwG6Eh1evWnUSA2NuLMzgjHSIvk0RfUr7V6+HQRXmq2uxAyE/4FvuFU4UxTBO19TSOvfKlXRPETNHke0HKPTa5/Je0z0Knmr0oPpZF/ymre+rIIwUrsuxZPRLzHgBqAauWQLNJp4xsl3XfZ4CiEnt5XLert0Wg9a1A== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230025)(4636009)(346002)(396003)(39860400002)(376002)(136003)(451199018)(40470700004)(36840700001)(46966006)(83380400001)(36860700001)(47076005)(426003)(107886003)(40460700003)(33656002)(6862004)(81166007)(82740400003)(478600001)(5660300002)(8936002)(55016003)(86362001)(40480700001)(82310400005)(186003)(26005)(1076003)(336012)(53546011)(70586007)(2906002)(8676002)(7696005)(70206006)(44832011)(4326008)(41300700001)(316002)(54906003);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Mar 2023 11:07:35.2239 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 61c583e7-61cb-4b2a-2254-08db1b0e53c9 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT035.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR08MB7528 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230302_030743_955189_FA1EC854 X-CRM114-Status: GOOD ( 24.60 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Peter, On Wed, Mar 01, 2023 at 11:35:56AM -0500, Peter Xu wrote: > On Thu, Jan 19, 2023 at 04:03:44PM +0000, Joey Gouly wrote: > > From: Kees Cook > > > > Add some tests to cover the new PR_SET_MDWE prctl. > > > > Co-developed-by: Joey Gouly > > Signed-off-by: Joey Gouly > > Signed-off-by: Kees Cook > > Cc: Shuah Khan > > May need to sync prctl.h into tools/include/uapi? Otherwise selftests/mm > build fails here. There's also one compiler report. A fixup attached > which works for me. > > Thanks, > > -- > Peter Xu I've CC'd Arnaldo because they seem to update the tools version of prctl.h a lot. Sorry about the 'p2' variable in the test, was there for some experiments but seems I accidentally included it. Acked-by: Joey Gouly Thanks, Joey > >From ce8e17c244fcc743c7006316dd431c5650480756 Mon Sep 17 00:00:00 2001 > From: Peter Xu > Date: Wed, 1 Mar 2023 11:33:34 -0500 > Subject: [PATCH] fixup! kselftest: vm: add tests for memory-deny-write-execute > > Signed-off-by: Peter Xu > --- > tools/include/uapi/linux/prctl.h | 6 ++++++ > tools/testing/selftests/mm/mdwe_test.c | 3 +-- > 2 files changed, 7 insertions(+), 2 deletions(-) > > diff --git a/tools/include/uapi/linux/prctl.h b/tools/include/uapi/linux/prctl.h > index e4c629c1f1b0..759b3f53e53f 100644 > --- a/tools/include/uapi/linux/prctl.h > +++ b/tools/include/uapi/linux/prctl.h > @@ -281,6 +281,12 @@ struct prctl_mm_map { > # define PR_SME_VL_LEN_MASK 0xffff > # define PR_SME_VL_INHERIT (1 << 17) /* inherit across exec */ > > +/* Memory deny write / execute */ > +#define PR_SET_MDWE 65 > +# define PR_MDWE_REFUSE_EXEC_GAIN 1 > + > +#define PR_GET_MDWE 66 > + > #define PR_SET_VMA 0x53564d41 > # define PR_SET_VMA_ANON_NAME 0 > > diff --git a/tools/testing/selftests/mm/mdwe_test.c b/tools/testing/selftests/mm/mdwe_test.c > index f466a099f1bf..bc91bef5d254 100644 > --- a/tools/testing/selftests/mm/mdwe_test.c > +++ b/tools/testing/selftests/mm/mdwe_test.c > @@ -163,9 +163,8 @@ TEST_F(mdwe, mprotect_WRITE_EXEC) > > TEST_F(mdwe, mmap_FIXED) > { > - void *p, *p2; > + void *p; > > - p2 = mmap(NULL, self->size, PROT_READ | PROT_EXEC, self->flags, 0, 0); > self->p = mmap(NULL, self->size, PROT_READ, self->flags, 0, 0); > ASSERT_NE(self->p, MAP_FAILED); > > -- > 2.39.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel