From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 41EE4C64EC4 for ; Fri, 3 Mar 2023 12:39:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=oxJlolGmXg6uMjgnSQK4xG4pKPg6wJNoPOgR7PCi0Ik=; b=ALwE04bxXFC+eE mku+hO0s8qtAevaEYRe2bfJhvR3e+K76BqSo7de3OXx/qzwg5wKXq3icWk9ZxER5cd63zj2eNJkAQ zpY2P/yqku4ig4+1oIzbmgRsskTnbtuiXULWK19alScq2++U2HtDHNBt80C6qAH0VWkKUjWnnXYHE MYkQOhW5dQ6UYg5k9aZGIOjW3ciGL3rXDd/Lr/esIb2b1NTg/1mc2yRpvOg6P4zsN7NKTdN6AplKS X8IpBdWqbcd1zfEWqmkvUebHDlxDGPQX4Ro9s76H5jKQOnPmNeJZZ9cWCKv2M3nTGIKvwda1ozvkV xhi0YDiZiLFZOuW+Gsgg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pY4gI-006Ktu-Ir; Fri, 03 Mar 2023 12:38:38 +0000 Received: from mail-lf1-x12b.google.com ([2a00:1450:4864:20::12b]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pY4gG-006KsW-3F for linux-arm-kernel@lists.infradead.org; Fri, 03 Mar 2023 12:38:37 +0000 Received: by mail-lf1-x12b.google.com with SMTP id f18so3419000lfa.3 for ; Fri, 03 Mar 2023 04:38:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1677847112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=LeNXt3isbPRHGAJkEjS0qeuKPk4Ph4hfVApRfVC6Qok=; b=P0YjcZ3S5ACbMGzx+4FQqVrYsfJfk5OAeUWFnmhbhhMgz7Y6myjru7hBUy4wOCtezp /cVnh5BCBuB6qe9UctJ5/iaU0DMycOjd+/JyQMJ4k32z4yKR//VcfV/3kYkvF8ZA63hQ 2E8GkyLcl5beiGfzTYH6A7r7Hd0U/Pnztk3O1+cCiKP/TxO/XKrAj3RDU2qL6oAKc74w LlhTjo2eKXUiuAKLfec8YyGpNOmoXr1+3UrFDev1FqdymopeMImPzKEtlyHUCssIw5NA Z/o6XxM04tfRZpp+aBZIT2WGUpY2j3hX1PGFa8d9si5tdeCtGxABmW67F7aRpPd0WCUp 6MbA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1677847112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=LeNXt3isbPRHGAJkEjS0qeuKPk4Ph4hfVApRfVC6Qok=; b=WPWNqZOuZu0XHKYpRUr6S+5gBKIqIEiMYLqsqbSKlPLjjg6KLboKq8szBINPqQn6lv WUOYM+EctDueQCMOdFq4J9ydaiBPbzIHgD/1pCFgq6Fpul2sKhZ/TL0LfvO43Z1Ybmk2 QAgR1ljU2pfpH39Nj5bgjPkdwN62nYv+hk+bogSW7Ybz6x4GxQWfUiZtEi0eCO7566iI AgSUXOzB4x+go2/vrF50TGFeoyo0/3cmmPUrl0/COhwAinUAoxnsqr7JqdnUtfVSYMNx LasZ2geS/YCDG7xQzxvTeb/tXDwrq22EFVhPoZuJITc32X2ndbCzhhGEoWEbxJBNV/rD jGAg== X-Gm-Message-State: AO0yUKVWH3BKWUZ+2UB9k8BMCn0tk14vdM/ro5WO+X+d+shoq9r0BwV/ 3ce5j18aQ3zNHV/70BOMmOc= X-Google-Smtp-Source: AK7set8AMf7sXcYGM7UKtvCBtcTYORd/6lfdClXFLlsf4lNnLXlfUAkJ2EqaJJ7J2E5fFC/UiNTVrQ== X-Received: by 2002:ac2:546a:0:b0:4cb:449a:31f8 with SMTP id e10-20020ac2546a000000b004cb449a31f8mr501789lfn.35.1677847112505; Fri, 03 Mar 2023 04:38:32 -0800 (PST) Received: from mobilestation ([95.79.133.202]) by smtp.gmail.com with ESMTPSA id c4-20020a2e6804000000b002934be1a0a4sm291705lja.70.2023.03.03.04.38.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 03 Mar 2023 04:38:31 -0800 (PST) Date: Fri, 3 Mar 2023 15:38:29 +0300 From: Serge Semin To: Shradha Todi Cc: lpieralisi@kernel.org, kw@linux.com, robh@kernel.org, bhelgaas@google.com, krzysztof.kozlowski+dt@linaro.org, alim.akhtar@samsung.com, jingoohan1@gmail.com, Sergey.Semin@baikalelectronics.ru, lukas.bulwahn@gmail.com, hongxing.zhu@nxp.com, tglx@linutronix.de, m.szyprowski@samsung.com, jh80.chung@samsung.co, pankaj.dubey@samsung.com, linux-pci@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 00/16] Refactor Exynos PCIe driver to make it generic Message-ID: <20230303123829.er626hqa562sal3t@mobilestation> References: <20230214121333.1837-1-shradha.t@samsung.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230214121333.1837-1-shradha.t@samsung.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230303_043836_195331_B6065F65 X-CRM114-Status: GOOD ( 19.82 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Shradha On Tue, Feb 14, 2023 at 05:43:17PM +0530, Shradha Todi wrote: > Currently pci-exynos is being used as a PCIe driver for Exynos5433 > only. This patch set refactors the driver to make it extensible to > other Samsung manufactured SoCs having DWC PCIe controllers. > The major change points are: > - Renaming all common functions/structures to use "samsung" instead > of "exynos". Make common probe/remove/suspend/resume > - Making clock/regulator get/enable/disable generic > - Adding private struct to hold platform specific function ops Just a general note regarding the DT-bindings. If you're willing to fix some names or most importantly add new ones please follow as much as possible to the generic interface defined in the common part of the DW PCIe bindings schema: Documentation/devicetree/bindings/pci/snps,dw-pcie-common.yaml Documentation/devicetree/bindings/pci/snps,dw-pcie.yaml for instance the generic "reg-names" are "elbi" or "app" defined for the application-dependent registers map (normally implemented via the ELBI interface in hardware), the "appl" name is marked as vendor-specific and should be avoided. -Serge(y) > > Shradha Todi (16): > dt-bindings: PCI: Rename Exynos PCIe binding to Samsung PCIe > PCI: exynos: Rename Exynos PCIe driver to Samsung PCIe > PCI: samsung: Change macro names to exynos specific > PCI: samsung: Use clock bulk API to get clocks > dt-bindings: PCI: Rename the term elbi to appl > arm64: dts: exynos: Rename the term elbi to appl > PCI: samsung: Rename the term elbi to appl > PCI: samsung: Rename exynos_pcie to samsung_pcie > PCI: samsung: Make common appl readl/writel functions > dt-bindings: PCI: Add phy-names as required property > arm64: dts: exynos: Add phy-names as DT property > PCI: samsung: Get PHY using non-DT version > PCI: samsung: Rename common functions to samsung > PCI: samsung: Add platform device private data > PCI: samsung: Add structure to hold resource operations > PCI: samsung: Make handling of regulators generic > > ...ung,exynos-pcie.yaml => samsung,pcie.yaml} | 15 +- > MAINTAINERS | 4 +- > arch/arm64/boot/dts/exynos/exynos5433.dtsi | 3 +- > drivers/pci/controller/dwc/Kconfig | 6 +- > drivers/pci/controller/dwc/Makefile | 2 +- > drivers/pci/controller/dwc/pci-samsung.c | 508 ++++++++++++++++++ > 6 files changed, 526 insertions(+), 12 deletions(-) > rename Documentation/devicetree/bindings/pci/{samsung,exynos-pcie.yaml => samsung,pcie.yaml} (89%) > create mode 100644 drivers/pci/controller/dwc/pci-samsung.c > > -- > 2.17.1 > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel