* [PATCH 1/1] firmware: imx: scu: use dev_err_probe
@ 2023-01-31 9:53 Alexander Stein
2023-01-31 10:50 ` Mukesh Ojha
2023-03-06 2:10 ` Shawn Guo
0 siblings, 2 replies; 3+ messages in thread
From: Alexander Stein @ 2023-01-31 9:53 UTC (permalink / raw)
To: Shawn Guo, Sascha Hauer, Fabio Estevam
Cc: Alexander Stein, Pengutronix Kernel Team, NXP Linux Team,
linux-arm-kernel
This simplifies the code and silences -517 error messages. Also
the reason is listed in /sys/kernel/debug/devices_deferred.
Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
---
drivers/firmware/imx/imx-scu.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/firmware/imx/imx-scu.c b/drivers/firmware/imx/imx-scu.c
index dca79caccd01..47db49911e7b 100644
--- a/drivers/firmware/imx/imx-scu.c
+++ b/drivers/firmware/imx/imx-scu.c
@@ -310,9 +310,8 @@ static int imx_scu_probe(struct platform_device *pdev)
sc_chan->ch = mbox_request_channel_byname(cl, chan_name);
if (IS_ERR(sc_chan->ch)) {
ret = PTR_ERR(sc_chan->ch);
- if (ret != -EPROBE_DEFER)
- dev_err(dev, "Failed to request mbox chan %s ret %d\n",
- chan_name, ret);
+ dev_err_probe(dev, ret, "Failed to request mbox chan %s\n",
+ chan_name);
kfree(chan_name);
return ret;
}
--
2.34.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH 1/1] firmware: imx: scu: use dev_err_probe
2023-01-31 9:53 [PATCH 1/1] firmware: imx: scu: use dev_err_probe Alexander Stein
@ 2023-01-31 10:50 ` Mukesh Ojha
2023-03-06 2:10 ` Shawn Guo
1 sibling, 0 replies; 3+ messages in thread
From: Mukesh Ojha @ 2023-01-31 10:50 UTC (permalink / raw)
To: Alexander Stein, Shawn Guo, Sascha Hauer, Fabio Estevam
Cc: Pengutronix Kernel Team, NXP Linux Team, linux-arm-kernel
On 1/31/2023 3:23 PM, Alexander Stein wrote:
> This simplifies the code and silences -517 error messages. Also
> the reason is listed in /sys/kernel/debug/devices_deferred.
>
> Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
LGTM.
Reviewed-by: Mukesh Ojha <quic_mojha@quicinc.com>
-Mukesh
> ---
> drivers/firmware/imx/imx-scu.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/firmware/imx/imx-scu.c b/drivers/firmware/imx/imx-scu.c
> index dca79caccd01..47db49911e7b 100644
> --- a/drivers/firmware/imx/imx-scu.c
> +++ b/drivers/firmware/imx/imx-scu.c
> @@ -310,9 +310,8 @@ static int imx_scu_probe(struct platform_device *pdev)
> sc_chan->ch = mbox_request_channel_byname(cl, chan_name);
> if (IS_ERR(sc_chan->ch)) {
> ret = PTR_ERR(sc_chan->ch);
> - if (ret != -EPROBE_DEFER)
> - dev_err(dev, "Failed to request mbox chan %s ret %d\n",
> - chan_name, ret);
> + dev_err_probe(dev, ret, "Failed to request mbox chan %s\n",
> + chan_name);
> kfree(chan_name);
> return ret;
> }
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH 1/1] firmware: imx: scu: use dev_err_probe
2023-01-31 9:53 [PATCH 1/1] firmware: imx: scu: use dev_err_probe Alexander Stein
2023-01-31 10:50 ` Mukesh Ojha
@ 2023-03-06 2:10 ` Shawn Guo
1 sibling, 0 replies; 3+ messages in thread
From: Shawn Guo @ 2023-03-06 2:10 UTC (permalink / raw)
To: Alexander Stein
Cc: Sascha Hauer, Fabio Estevam, Pengutronix Kernel Team,
NXP Linux Team, linux-arm-kernel
On Tue, Jan 31, 2023 at 10:53:40AM +0100, Alexander Stein wrote:
> This simplifies the code and silences -517 error messages. Also
> the reason is listed in /sys/kernel/debug/devices_deferred.
>
> Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
Applied, thanks!
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-03-06 2:12 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-01-31 9:53 [PATCH 1/1] firmware: imx: scu: use dev_err_probe Alexander Stein
2023-01-31 10:50 ` Mukesh Ojha
2023-03-06 2:10 ` Shawn Guo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox