From: Shawn Guo <shawnguo@kernel.org>
To: Michael Walle <michael@walle.cc>
Cc: Li Yang <leoyang.li@nxp.com>, Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Revert "arm64: dts: ls1028a: sl28: get MAC addresses from VPD"
Date: Mon, 6 Mar 2023 11:10:54 +0800 [thread overview]
Message-ID: <20230306031054.GG143566@dragon> (raw)
In-Reply-To: <20230207131020.2458027-1-michael@walle.cc>
On Tue, Feb 07, 2023 at 02:10:20PM +0100, Michael Walle wrote:
> With commit b203e6f1e833 ("arm64: dts: ls1028a: sl28: get MAC addresses
> from VPD"), the network adapter now depends on the nvmem device to be
> present, which isn't the case and thus breaks networking on this board.
> Revert it.
>
> Fixes: b203e6f1e833 ("arm64: dts: ls1028a: sl28: get MAC addresses from VPD")
> Signed-off-by: Michael Walle <michael@walle.cc>
Applied!
> ---
> Shawn, unfortunately, the driver was NAKed, so this will break our
> KernelCI setup. Alternatively, the original commit can just be dropped
> from your tree, if that's how you do things like this. I've learned that
> the correct way is to get the driver in and then in the next release enable
> the driver and add it to the dts. Next time :)
Yes, please follow the correct way!
Shawn
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2023-03-06 3:12 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-07 13:10 [PATCH] Revert "arm64: dts: ls1028a: sl28: get MAC addresses from VPD" Michael Walle
2023-03-06 3:10 ` Shawn Guo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230306031054.GG143566@dragon \
--to=shawnguo@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=leoyang.li@nxp.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michael@walle.cc \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).