From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D6E51C61DA4 for ; Mon, 6 Mar 2023 03:12:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=5OhoVTCGjIUxcLaHt5/LUxGQin717q/pSribs1Edy7o=; b=so8irg1ugjUBUS pk5IOLWmS5Vxl+i3CAnFcMjRkXlrNFUtCdr34C4tAubdMRD08F9elKDCy0bLtiHXfmURS/bInOdBv vQU5L1/96LSMp16LXgo+kb+b0o7+vWaS/UbXJHMemertugaqGNt7/YYcbJlvYFSEOR4Rx+yhBX+gD yr8Pc2EQXsClD+aUjnzf4/9pnpd7L6KC739kpzysyHYl+pinfG2ji9SreCWddSLIpxc8UrlsvFpNp GdWsljxRHk8pd0uQS+ptAAYIM4jjf1TDkBTxBs97i2Lbb90iA8x/3gSPUKaItYrIErO6HsWo215be NhYo/Hz/jLH89qHPQm/g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pZ1Fr-00B5x8-EO; Mon, 06 Mar 2023 03:11:15 +0000 Received: from ams.source.kernel.org ([145.40.68.75]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pZ1Fm-00B5vs-Ps for linux-arm-kernel@lists.infradead.org; Mon, 06 Mar 2023 03:11:12 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 0F74CB80B0E; Mon, 6 Mar 2023 03:11:09 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 00850C433D2; Mon, 6 Mar 2023 03:11:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1678072267; bh=AK43SQyKJZUihUt0Xy3vFkqCXBiD2WrokES4O8k/UeE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=mxvfaEXInsnU8yD8gCDVev1RahBCGC83N2qN8otUooLXY0geqTInl9rb4zj6Br7RH KL/fj4VkQ5IAjR/aJBgScFNaWkc0euXJrXqobPw0VMcbfQFwFQelGii7W9lixLVtjk Hif5GeHy55H06xAfEqGn8nAxQZn13rn6GjxO4fEYH3obP23l2ju6ojPG5YM7URjKAn /tuLZu9VA3Ot4zMSPQ3Rg/iT/0A7sP3ZcVXrbgJrvYuCulLHUy7XL2N29gBbGEAJDb XifYBMrbk8BnC97BTvo+nQoQarju4DJ/jeUIVX3GBuAVgI0fhay0fgDWJj2ocza0AT H8DlDjyBBY/gg== Date: Mon, 6 Mar 2023 11:10:54 +0800 From: Shawn Guo To: Michael Walle Cc: Li Yang , Rob Herring , Krzysztof Kozlowski , linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] Revert "arm64: dts: ls1028a: sl28: get MAC addresses from VPD" Message-ID: <20230306031054.GG143566@dragon> References: <20230207131020.2458027-1-michael@walle.cc> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230207131020.2458027-1-michael@walle.cc> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230305_191111_039873_393BE24E X-CRM114-Status: GOOD ( 15.62 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Feb 07, 2023 at 02:10:20PM +0100, Michael Walle wrote: > With commit b203e6f1e833 ("arm64: dts: ls1028a: sl28: get MAC addresses > from VPD"), the network adapter now depends on the nvmem device to be > present, which isn't the case and thus breaks networking on this board. > Revert it. > > Fixes: b203e6f1e833 ("arm64: dts: ls1028a: sl28: get MAC addresses from VPD") > Signed-off-by: Michael Walle Applied! > --- > Shawn, unfortunately, the driver was NAKed, so this will break our > KernelCI setup. Alternatively, the original commit can just be dropped > from your tree, if that's how you do things like this. I've learned that > the correct way is to get the driver in and then in the next release enable > the driver and add it to the dts. Next time :) Yes, please follow the correct way! Shawn _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel