From: Tony Lindgren <tony@atomide.com>
To: Andreas Kemnade <andreas@kemnade.info>
Cc: Linus Walleij <linus.walleij@linaro.org>,
Mun Yew Tham <mun.yew.tham@intel.com>,
Bartosz Golaszewski <brgl@bgdev.pl>,
Joel Stanley <joel@jms.id.au>, Andrew Jeffery <andrew@aj.id.au>,
Alban Bedel <albeu@free.fr>, Orson Zhai <orsonzhai@gmail.com>,
Baolin Wang <baolin.wang@linux.alibaba.com>,
Chunyan Zhang <zhang.lyra@gmail.com>,
Jay Fang <f.fangjian@huawei.com>,
Daniel Palmer <daniel@thingy.jp>,
Romain Perier <romain.perier@gmail.com>,
Grygorii Strashko <grygorii.strashko@ti.com>,
Santosh Shilimkar <ssantosh@kernel.org>,
Kevin Hilman <khilman@kernel.org>,
William Breathitt Gray <william.gray@linaro.org>,
linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-aspeed@lists.ozlabs.org, linux-omap@vger.kernel.org,
Marc Zyngier <maz@kernel.org>
Subject: Re: [PATCH 15/17] gpio: omap: Convert to immutable irq_chip
Date: Mon, 6 Mar 2023 09:28:52 +0200 [thread overview]
Message-ID: <20230306072852.GB7501@atomide.com> (raw)
In-Reply-To: <20230217173108.1448ce92@aktux>
* Andreas Kemnade <andreas@kemnade.info> [230217 16:31]:
> On Fri, 17 Feb 2023 09:49:37 +0200
> Tony Lindgren <tony@atomide.com> wrote:
>
> > Hi,
> >
> > * Linus Walleij <linus.walleij@linaro.org> [230216 09:38]:
> > > Convert the driver to immutable irq-chip with a bit of
> > > intuition.
> > >
> > > This driver require some special care: .irq_ack() was copied
> > > from dummy_irq_chip where it was defined as noop. This only
> > > makes sense if using handle_edge_irq() that will unconditionally
> > > call .irq_ack() to avoid a crash, but this driver is not ever
> > > using handle_edge_irq() so just avoid assigning .irq_ack().
> > >
> > > A separate chip had to be created for the non-wakeup instance.
> >
> > Nice, works for me.
> >
> > BTW, I still see these warnings remaining on boot:
> >
> > gpio gpiochip0: Static allocation of GPIO base is deprecated, use dynamic allocation.
> >
> > Seems like we might be able to get rid of those too now or are
> > there still some dependencies with /sys/class/gpio for example?
> >
> on what are you testing? on -next? I thought I have fixed theese warning with
> https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=92bf78b33b0b463b00c6b0203b49aea845daecc8
You're right, sorry looks like I pasted the wrong line from the dmesg
output :)
I intended to paste this example instead of the static allocation line:
gpio gpiochip1: (gpio-32-63): not an immutable chip, please consider fixing it!
Regards,
Tony
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-03-06 7:30 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-16 9:37 [PATCH 00/17] Mass convert GPIO IRQ chips to be immutable Linus Walleij
2023-02-16 9:37 ` [PATCH 01/17] gpio: altera: Convert to immutable irq_chip Linus Walleij
2023-02-16 9:37 ` [PATCH 02/17] gpio: adnp: " Linus Walleij
2023-02-16 9:37 ` [PATCH 03/17] gpio: aspeed: " Linus Walleij
2023-02-27 0:44 ` Joel Stanley
2023-02-16 9:37 ` [PATCH 04/17] gpio: aspeed-sgpio: " Linus Walleij
2023-02-16 9:37 ` [PATCH 05/17] gpio: ath79: " Linus Walleij
2023-02-16 9:37 ` [PATCH 06/17] gpio: cadence: " Linus Walleij
2023-02-16 9:37 ` [PATCH 07/17] gpio: eic_sprd: " Linus Walleij
2023-02-16 9:37 ` [PATCH 08/17] gpio: hisi: " Linus Walleij
2023-02-16 9:37 ` [PATCH 09/17] gpio: hlwd: " Linus Walleij
2023-02-16 9:37 ` [PATCH 10/17] gpio: idt3243x: " Linus Walleij
2023-02-17 13:28 ` Thomas Bogendoerfer
2023-02-16 9:37 ` [PATCH 11/17] gpio: msc313: " Linus Walleij
2023-02-16 9:37 ` [PATCH 12/17] gpio: mlxbf2: " Linus Walleij
2023-02-16 9:37 ` [PATCH 13/17] gpio: max732x: " Linus Walleij
2023-02-16 9:37 ` [PATCH 14/17] gpio: omap: Drop irq_base Linus Walleij
2023-02-17 5:58 ` Tony Lindgren
2023-02-16 9:37 ` [PATCH 15/17] gpio: omap: Convert to immutable irq_chip Linus Walleij
2023-02-17 7:49 ` Tony Lindgren
2023-02-17 16:31 ` Andreas Kemnade
2023-03-06 7:28 ` Tony Lindgren [this message]
2023-03-06 7:31 ` Tony Lindgren
2023-02-16 9:37 ` [PATCH 16/17] gpio: pci-idio-16: " Linus Walleij
2023-02-08 11:16 ` William Breathitt Gray
2023-02-16 9:37 ` [PATCH 17/17] gpio: pcie-idio-24: " Linus Walleij
2023-02-08 11:17 ` William Breathitt Gray
2023-02-16 10:47 ` [PATCH 00/17] Mass convert GPIO IRQ chips to be immutable Marc Zyngier
2023-02-17 6:02 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230306072852.GB7501@atomide.com \
--to=tony@atomide.com \
--cc=albeu@free.fr \
--cc=andreas@kemnade.info \
--cc=andrew@aj.id.au \
--cc=baolin.wang@linux.alibaba.com \
--cc=brgl@bgdev.pl \
--cc=daniel@thingy.jp \
--cc=f.fangjian@huawei.com \
--cc=grygorii.strashko@ti.com \
--cc=joel@jms.id.au \
--cc=khilman@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=maz@kernel.org \
--cc=mun.yew.tham@intel.com \
--cc=orsonzhai@gmail.com \
--cc=romain.perier@gmail.com \
--cc=ssantosh@kernel.org \
--cc=william.gray@linaro.org \
--cc=zhang.lyra@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).