Re: [PATCH 6/8] dt-bindings: ARM: fsl: Add chargebyte Tarragon

Stefan Wahren
2023-03-10T10:10:23Z

Hi Krzysztof,

Am 07.03.23 um 09:24 schrieb Krzysztof Kozlowski:
> On 06/03/2023 18:22, Stefan Wahren wrote:
>> From: Stefan Wahren <stefan.wahren@chargebyte.com>
>>
>> This adds the compatibles for the chargebyte Tarragon boards.
>>
>> Signed-off-by: Stefan Wahren <stefan.wahren@chargebyte.com>
>> Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com>
>> ---
>> Documentation/devicetree/bindings/arm/fsl.yaml | 9 +++++++++
>> 1 file changed, 9 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml
>> index dece3e9ba7fd..2b430e20a7a6 100644
>> --- a/Documentation/devicetree/bindings/arm/fsl.yaml
>> +++ b/Documentation/devicetree/bindings/arm/fsl.yaml
>> @@ -781,6 +781,15 @@ properties:
>> - const: tq,imx6ull-tqma6ull2l # MCIMX6Y2, LGA SoM variant
>> - const: fsl,imx6ull
>>
>> + - description: chargebyte Tarragon Boards
>> + items:
>> + - enum:
>> + - chargebyte,imx6ull-tarragon-master
>> + - chargebyte,imx6ull-tarragon-micro
>> + - chargebyte,imx6ull-tarragon-slave
>> + - chargebyte,imx6ull-tarragon-slavext
>> + - const: fsl,imx6ull
> I don't think you put it in correct place. Didn't you just stuff it at
> the end?

Yes, i just put it at the end. But to be honest, i'm not sure about the
order:

armadeus,imx6ull-opos6uldev
..
dh,imx6ull-dhcom-drc02
..
phytec,imx6ull-pbacd10-emmc
..
toradex,colibri-imx6ull-aster
..
kontron,bl-imx6ull
..
tq,imx6ull-tqma6ull2-mba6ulx

Does the order depend on the compatibles and vendor is relevant?

So your expectation was between armadeus and dh?

>
> Best regards,
> Krzysztof