From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BF6DEC61DA4 for ; Tue, 7 Mar 2023 03:16:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=+eqAicLZLkYP4zS6io8BNW2rE3cFr5H6v6pf3dnMqRo=; b=UoPNnlz+/lcAka Fnsgh828pegjyfZXlRPq76QB4hPVCguxMfH65rEWwKx09/OE1vzZ/nq1lEhEDEOJrUwCLaOVs2ccK hqTUHQdYdGD7o7W4DOgtFnzSJJTwF1qS1X3rOeCIMeBLjO8Ewba32d8oqAwW1ekcaEwGHribC+Gxe JLTC4S6oRLrw1XazL9J/IeGcepz5RdvGzVyTUd5yXfSH/ybPlCs7Hl8/7bhijkUH/56c+UwfQND1Z V3HRKj2CSNkdBQoiRiIqF0YDU19wI0uGETYzBy3MdCSW188Al0oMRd8cgwleDelDEoWIz+qgNUGNK bBCJOelv9569dDDVPxuA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pZNmh-00G1kD-JD; Tue, 07 Mar 2023 03:14:39 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pZNme-00G1jl-EG for linux-arm-kernel@lists.infradead.org; Tue, 07 Mar 2023 03:14:38 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id BE30D611C3; Tue, 7 Mar 2023 03:14:34 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 68177C433EF; Tue, 7 Mar 2023 03:14:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1678158874; bh=HCkiNngXR0O1rJhX2osFm7SVlGm5dWVrrD/EbMZpvDk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Nn+xKF1zxSDbwT+l+a28EcNNbQqAsXDsEEURo9ye0x3c8Qw417AawT9MX3Kq812mE 8lqzbwqJISQW6x9YRZeZOMKQVx/ofTg4KdEQQxLcEdc01aJsAFaUpIJvDJNAEItkNq jYJUkQYLaG4MIAWShqyYVetCBt3066ErvXHWA8KGLO+iTTEVMEWMl0qu63PlMIYmBm Bo1NJlVQVjly0zC1OsAF9X22J6mjEc4JCxmz83UXk8knANsHKw3tIBmjDWLFeGAa6q fGezSZSA7yA27psgiJMqkcDxfErOcn8QwpBCUMRgeldvpc1uq5inDi+U2klu0W0OYz ODZ9w3Df9yOqg== Date: Tue, 7 Mar 2023 11:14:26 +0800 From: Shawn Guo To: Johannes Schneider Cc: Rob Herring , Krzysztof Kozlowski , Sascha Hauer , Fabio Estevam , Li Yang , Shengjiu Wang , Richard Zhu , Pengutronix Kernel Team , NXP Linux Team , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v11 1/2] arm64: dts: imx8mm-evkb: add support for i.MX8MM-EVKB Message-ID: <20230307031426.GI143566@dragon> References: <20230130172553.2738182-1-johannes.schneider@leica-geosystems.com> <20230130172553.2738182-2-johannes.schneider@leica-geosystems.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230130172553.2738182-2-johannes.schneider@leica-geosystems.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230306_191436_605484_6A3FFF08 X-CRM114-Status: GOOD ( 23.80 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Jan 30, 2023 at 06:25:52PM +0100, Johannes Schneider wrote: > Add devicetree for the EVKB, which comes with LPDDR4 and a different > PMIC. > > The regulator min/max values are taken from the evk's schematic: > 8MMINILPD4-CPU SPF-31399_C2.pdf > > Signed-off-by: Johannes Schneider The patch doesn't compile at all (see below), so I took a closer look and decided to drop the series. > --- > arch/arm64/boot/dts/freescale/Makefile | 1 + > arch/arm64/boot/dts/freescale/imx8mm-evkb.dts | 134 ++++++++++++++++++ > 2 files changed, 135 insertions(+) > create mode 100644 arch/arm64/boot/dts/freescale/imx8mm-evkb.dts > > diff --git a/arch/arm64/boot/dts/freescale/Makefile b/arch/arm64/boot/dts/freescale/Makefile > index 3ea9edc87909..3bccc4d10928 100644 > --- a/arch/arm64/boot/dts/freescale/Makefile > +++ b/arch/arm64/boot/dts/freescale/Makefile > @@ -55,6 +55,7 @@ dtb-$(CONFIG_ARCH_MXC) += imx8mm-data-modul-edm-sbc.dtb > dtb-$(CONFIG_ARCH_MXC) += imx8mm-ddr4-evk.dtb > dtb-$(CONFIG_ARCH_MXC) += imx8mm-emcon-avari.dtb > dtb-$(CONFIG_ARCH_MXC) += imx8mm-evk.dtb > +dtb-$(CONFIG_ARCH_MXC) += imx8mm-evkb.dtb I prefer to name it imx8mm-evk-revb.dtb or imx8mm-evk-b.dtb. > dtb-$(CONFIG_ARCH_MXC) += imx8mm-icore-mx8mm-ctouch2.dtb > dtb-$(CONFIG_ARCH_MXC) += imx8mm-icore-mx8mm-edimm2.2.dtb > dtb-$(CONFIG_ARCH_MXC) += imx8mm-kontron-bl.dtb > diff --git a/arch/arm64/boot/dts/freescale/imx8mm-evkb.dts b/arch/arm64/boot/dts/freescale/imx8mm-evkb.dts > new file mode 100644 > index 000000000000..2c3947d68982 > --- /dev/null > +++ b/arch/arm64/boot/dts/freescale/imx8mm-evkb.dts > @@ -0,0 +1,134 @@ > +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) > +/* > + * Copyright 2019-2022 NXP > + */ > + > +/dts-v1/; > + > +#include "imx8mm-evk.dtsi" > + > +/ { > + model = "FSL i.MX8MM EVKB"; // with LPDDR4 and PCA9450 PMIC "FSL i.MX8MM EVK Revision B" imx8mm-evk board has LPDDR4 too, so LPDDR4 is not a difference. It seems PMIC is the only difference between imx8mm-evk and imx8mm-evk-b. In that case, we may want to include "imx8mm-evk.dts" rather than "imx8mm-evk.dtsi". Otherwise, things like flexspi and usdhc3 get lost. Also /* ... */ style of comment is recommended. > + compatible = "fsl,imx8mm-evkb", "fsl,imx8mm"; "fsl,imx8mm-evk-revb" or "fsl,imx8mm-evk-b" > +}; > + > +&i2c1 { > + /* > + * replace "rohm,bd71847" pmic found on previous evks > + * with "nxp,pca9450a" > + */ > + /delete-node/ pmic@4b Missing semicolon causes DTC error. /delete-node/ pmic@4b; Shawn > + > + pmic: pmic@25 { > + compatible = "nxp,pca9450a"; > + reg = <0x25>; > + pinctrl-0 = <&pinctrl_pmic>; > + pinctrl-names = "default"; > + interrupt-parent = <&gpio1>; > + interrupts = <3 IRQ_TYPE_LEVEL_LOW>; > + > + regulators { > + // VDD_SOC_0V8 > + buck1_reg: BUCK1 { > + regulator-name = "BUCK1"; > + regulator-min-microvolt = <780000>; > + regulator-max-microvolt = <900000>; > + regulator-boot-on; > + regulator-always-on; > + regulator-ramp-delay = <1250>; > + }; > + > + // VDD_ARM_0V9 > + buck2_reg: BUCK2 { > + regulator-name = "BUCK2"; > + regulator-min-microvolt = <805000>; > + regulator-max-microvolt = <1050000>; > + regulator-boot-on; > + regulator-always-on; > + regulator-ramp-delay = <1250>; > + nxp,dvs-standby-voltage = <850000>; > + }; > + > + // VDD_DRAM&PU_0V9 (BUCK5 in datasheet) > + buck3_reg: BUCK3 { > + regulator-name = "BUCK3"; > + regulator-min-microvolt = <805000>; > + regulator-max-microvolt = <1000000>; > + regulator-boot-on; > + regulator-always-on; > + }; > + > + // VDD_3V3/NVCC_3V3 (BUCK6 in datasheet) > + buck4_reg: BUCK4 { > + regulator-name = "BUCK4"; > + regulator-min-microvolt = <3000000>; > + regulator-max-microvolt = <3600000>; > + regulator-boot-on; > + regulator-always-on; > + }; > + > + // VDD_1V8/NVCC_1V8 (BUCK7 in datasheet) > + buck5_reg: BUCK5 { > + regulator-name = "BUCK5"; > + regulator-min-microvolt = <1650000>; > + regulator-max-microvolt = <1950000>; > + regulator-boot-on; > + regulator-always-on; > + }; > + > + // NVCC_DRAM_1V1 (BUCK8 in datasheet) > + buck6_reg: BUCK6 { > + regulator-name = "BUCK6"; > + regulator-min-microvolt = <1060000>; > + regulator-max-microvolt = <1140000>; > + regulator-boot-on; > + regulator-always-on; > + }; > + > + // NVCC_SNVS_1V8 > + ldo1_reg: LDO1 { > + regulator-name = "LDO1"; > + regulator-min-microvolt = <1620000>; > + regulator-max-microvolt = <19800000>; > + regulator-boot-on; > + regulator-always-on; > + }; > + > + // VDD_SNVS_0V8 > + ldo2_reg: LDO2 { > + regulator-name = "LDO2"; > + regulator-min-microvolt = <760000>; > + regulator-max-microvolt = <900000>; > + regulator-boot-on; > + regulator-always-on; > + }; > + > + // VDDA_1V8 > + ldo3_reg: LDO3 { > + regulator-name = "LDO3"; > + regulator-min-microvolt = <1710000>; > + regulator-max-microvolt = <1890000>; > + regulator-boot-on; > + regulator-always-on; > + }; > + > + // VDD_PHY_0V9 > + ldo4_reg: LDO4 { > + regulator-name = "LDO4"; > + regulator-min-microvolt = <855000>; > + regulator-max-microvolt = <1000000>; > + regulator-boot-on; > + regulator-always-on; > + }; > + > + // VDD_PHY_1V2 (LDO6 in datasheet) > + ldo5_reg: LDO5 { > + regulator-name = "LDO5"; > + regulator-min-microvolt = <1140000>; > + regulator-max-microvolt = <1260000>; > + regulator-boot-on; > + regulator-always-on; > + }; > + }; > + }; > +}; > -- > 2.25.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel