From: Lee Jones <lee@kernel.org>
To: ChiYuan Huang <cy_huang@richtek.com>
Cc: ChiaEn Wu <chiaen_wu@richtek.com>,
corbet@lwn.net, pavel@ucw.cz, matthias.bgg@gmail.com,
andriy.shevchenko@linux.intel.com, jacek.anaszewski@gmail.com,
angelogioacchino.delregno@collabora.com,
linux-doc@vger.kernel.org, peterwu.pub@gmail.com,
linux-leds@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org,
szunichen@gmail.com
Subject: Re: [PATCH v17 RESEND 3/3] docs: leds: Add MT6370 RGB LED pattern document
Date: Wed, 8 Mar 2023 13:42:08 +0000 [thread overview]
Message-ID: <20230308134208.GK9667@google.com> (raw)
In-Reply-To: <20230307040804.GA15766@linuxcarl2.richtek.com>
On Tue, 07 Mar 2023, ChiYuan Huang wrote:
> Hi, Lee:
>
> Some question about the comment.
> On Sun, Mar 05, 2023 at 10:18:24AM +0000, Lee Jones wrote:
> > On Thu, 23 Feb 2023, ChiaEn Wu wrote:
> >
> > > From: ChiYuan Huang <cy_huang@richtek.com>
> > >
> > > Document the MT6370 RGB LED pattern trigger.
> > >
> > > This simply describe how the pattern works, each timing period, and the
> > > pattern diagram for MT6370 RGB LED.
> > >
> > > Signed-off-by: ChiYuan Huang <cy_huang@richtek.com>
> > > Signed-off-by: ChiaEn Wu <chiaen_wu@richtek.com>
> > > ---
> > > Documentation/leds/leds-mt6370-rgb.rst | 64 ++++++++++++++++++++++++++++++++++
> > > 1 file changed, 64 insertions(+)
> > > create mode 100644 Documentation/leds/leds-mt6370-rgb.rst
> > >
> > > diff --git a/Documentation/leds/leds-mt6370-rgb.rst b/Documentation/leds/leds-mt6370-rgb.rst
> > > new file mode 100644
> > > index 00000000..d1b2e4f
> > > --- /dev/null
> > > +++ b/Documentation/leds/leds-mt6370-rgb.rst
> > > @@ -0,0 +1,64 @@
> > > +.. SPDX-License-Identifier: GPL-2.0
> > > +
> > > +=========================================
> > > +Kernel driver for Mediatek MT6370 RGB LED
> >
> > Are you describing the device or the kernel driver?
> >
> But referring to others, it seems each one also write this as 'Kernel driver'.
> Sorry, I cannot catch the point. Did you mean to modify this description as
> 'The device for MT6370 RGB LED'?
Just because it's been done before, doesn't make it right.
IMHO, this document should describe the device, not the driver.
--
Lee Jones [李琼斯]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2023-03-08 13:43 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-23 11:23 [PATCH v17 RESEND 0/3] Add MediaTek MT6370 PMIC support ChiaEn Wu
2023-02-23 11:23 ` [PATCH v17 RESEND 1/3] leds: rgb: mt6370: Add MediaTek MT6370 current sink type LED Indicator support ChiaEn Wu
2023-02-23 13:14 ` AngeloGioacchino Del Regno
2023-03-05 8:55 ` Lee Jones
2023-03-07 2:23 ` ChiYuan Huang
2023-03-08 14:02 ` Lee Jones
2023-02-23 11:23 ` [PATCH v17 RESEND 2/3] leds: flash: mt6370: Add MediaTek MT6370 flashlight support ChiaEn Wu
2023-03-05 10:06 ` Lee Jones
2023-03-07 3:44 ` ChiYuan Huang
2023-03-08 13:54 ` Lee Jones
2023-03-09 1:49 ` ChiYuan Huang
2023-03-09 17:24 ` Lee Jones
2023-02-23 11:23 ` [PATCH v17 RESEND 3/3] docs: leds: Add MT6370 RGB LED pattern document ChiaEn Wu
2023-03-05 10:18 ` Lee Jones
2023-03-07 4:08 ` ChiYuan Huang
2023-03-08 13:42 ` Lee Jones [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230308134208.GK9667@google.com \
--to=lee@kernel.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=chiaen_wu@richtek.com \
--cc=corbet@lwn.net \
--cc=cy_huang@richtek.com \
--cc=jacek.anaszewski@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=pavel@ucw.cz \
--cc=peterwu.pub@gmail.com \
--cc=szunichen@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).