From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 66A02C64EC4 for ; Wed, 8 Mar 2023 14:04:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=GWjjG/BIhglhszZSzdyFeRtAnyZ7i3gA7+BCWwQrzH4=; b=z9JqhJkjo5D7ZW PHaI5mqOuh7pmpJMe3tojZsd6zIeHARAQ76GDDLSFpmN6+LkJdFDB+7mCvYBD3ZvNZmkVZt9ExrMY 72Z6B88fmmIPFFRZReyEPC/aCt2HnItAjIHZD+CYHUO+miv5GEZpAW2v6HJynHmCW+uaAC2n4x05N lx/1T8Ahsa824/lACoxwgjgOIvvH+6U1Ws3cXxZUJTOwj+oANeynbKfc9yn0hOXvATlku6XGa0seu EimSuvjSaZ23pgGdzJGmFwQhcnng1CcOvfmjt86nJkWxTL2+JmX2IDxBO6MYMB5sXE8q31TtMZZFV fx2ys7wHAxh6gq8OCi4Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pZuNt-005LyY-W1; Wed, 08 Mar 2023 14:03:14 +0000 Received: from ams.source.kernel.org ([145.40.68.75]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pZuNo-005LsR-6Y; Wed, 08 Mar 2023 14:03:10 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 448B3B81CB0; Wed, 8 Mar 2023 14:03:00 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id EFA44C4339B; Wed, 8 Mar 2023 14:02:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1678284179; bh=3hWMzSBp2LshUH8WZVkMXZ1L/iWYq6eMTZ5lUjo/grs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=CdmFLfC6hlLq+1GYsbbKXcBliS1OW9OAzBOk9ohJbLILNteUJU9Noq9z+dJYlK4UZ r3qRccMzo2ZcVxH+O/cxYIaT+oI0zQWNxOqS+nY7fzTTvAB/8N4y5ipYDRKTkPduvn zJkMTpdZ/Ayyy7qS0YlUmFWwABIfzJLsdrsp/fGVODd/NDxI82919GmTb76tvSqQlQ jWUs1tHEL4XM88rEqQpZKbh/v07sqOulZ+6Fbm1kK6PQqCJn1n9zsS2DAgNtZmrr8b sMSwz8qDuzVIIqMEULZqIjJTr10b7eRgNQy7WiO5Pe5hzk+xAHBCfpKJukiPFjJ9AC yehCwZeRtErTw== Date: Wed, 8 Mar 2023 14:02:52 +0000 From: Lee Jones To: ChiYuan Huang Cc: ChiaEn Wu , corbet@lwn.net, pavel@ucw.cz, matthias.bgg@gmail.com, andriy.shevchenko@linux.intel.com, jacek.anaszewski@gmail.com, angelogioacchino.delregno@collabora.com, linux-doc@vger.kernel.org, peterwu.pub@gmail.com, linux-leds@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, szunichen@gmail.com, Alice Chen Subject: Re: [PATCH v17 RESEND 1/3] leds: rgb: mt6370: Add MediaTek MT6370 current sink type LED Indicator support Message-ID: <20230308140252.GM9667@google.com> References: <8f139c773de274311c8ca63a47d6b207c30913e2.1677150607.git.chiaen_wu@richtek.com> <20230305085533.GC2574592@google.com> <20230307022302.GA4930@linuxcarl2.richtek.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230307022302.GA4930@linuxcarl2.richtek.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230308_060308_572297_822BD185 X-CRM114-Status: GOOD ( 36.60 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gVHVlLCAwNyBNYXIgMjAyMywgQ2hpWXVhbiBIdWFuZyB3cm90ZToKCj4gSGksIExlZToKPgo+ IFRoYW5rcydzIGZvciB0aGUgcmV2aWV3aW5nLgo+IFRvIHByZXZlbnQgdGhlIG1pc3VuZGVyc3Rh bmRpbmcsIHJlcGx5IGFzIGJlbG93Lgo+IE5vIHJlcGx5IG1lYW5zIHdpbGwgZG8uCj4KPiBPbiBT dW4sIE1hciAwNSwgMjAyMyBhdCAwODo1NTozM0FNICswMDAwLCBMZWUgSm9uZXMgd3JvdGU6Cj4g PiBPbiBUaHUsIDIzIEZlYiAyMDIzLCBDaGlhRW4gV3Ugd3JvdGU6Cj4gPgo+ID4gPiBGcm9tOiBD aGlZdWFuIEh1YW5nIDxjeV9odWFuZ0ByaWNodGVrLmNvbT4KPiA+ID4KPiA+ID4gVGhlIE1lZGlh VGVrIE1UNjM3MCBpcyBhIGhpZ2hseS1pbnRlZ3JhdGVkIHNtYXJ0IHBvd2VyIG1hbmFnZW1lbnQg SUMsCj4gPiA+IHdoaWNoIGluY2x1ZGVzIGEgc2luZ2xlIGNlbGwgTGktSW9uL0xpLVBvbHltZXIg c3dpdGNoaW5nIGJhdHRlcnkKPiA+ID4gY2hhcmdlciwgYSBVU0IgVHlwZS1DICYgUG93ZXIgRGVs aXZlcnkgKFBEKSBjb250cm9sbGVyLCBkdWFsCj4gPiA+IEZsYXNoIExFRCBjdXJyZW50IHNvdXJj ZXMsIGEgUkdCIExFRCBkcml2ZXIsIGEgYmFja2xpZ2h0IFdMRUQgZHJpdmVyLAo+ID4gPiBhIGRp c3BsYXkgYmlhcyBkcml2ZXIgYW5kIGEgZ2VuZXJhbCBMRE8gZm9yIHBvcnRhYmxlIGRldmljZXMu Cj4gPiA+Cj4gPiA+IEFkZCBzdXBwb3J0IGZvciB0aGUgTWVkaWFUZWsgTVQ2MzcwIEN1cnJlbnQg U2luayBUeXBlIExFRCBJbmRpY2F0b3IKPiA+ID4gZHJpdmVyLiBJdCBjYW4gY29udHJvbCBmb3Vy IGNoYW5uZWxzIGN1cnJlbnQtc2luayBSR0IgTEVEcyB3aXRoIDMgbW9kZXM6Cj4gPiA+IGNvbnN0 YW50IGN1cnJlbnQsIFBXTSwgYW5kIGJyZWF0aCBtb2RlLgo+ID4gPgo+ID4gPiBBY2tlZC1ieTog SmFjZWsgQW5hc3pld3NraSA8amFjZWsuYW5hc3pld3NraUBnbWFpbC5jb20+Cj4gPiA+IENvLWRl dmVsb3BlZC1ieTogQWxpY2UgQ2hlbiA8YWxpY2VfY2hlbkByaWNodGVrLmNvbT4KPiA+ID4gU2ln bmVkLW9mZi1ieTogQWxpY2UgQ2hlbiA8YWxpY2VfY2hlbkByaWNodGVrLmNvbT4KPiA+ID4gU2ln bmVkLW9mZi1ieTogQ2hpWXVhbiBIdWFuZyA8Y3lfaHVhbmdAcmljaHRlay5jb20+Cj4gPiA+IFNp Z25lZC1vZmYtYnk6IENoaWFFbiBXdSA8Y2hpYWVuX3d1QHJpY2h0ZWsuY29tPgo+ID4gPiAtLS0K PiA+ID4gdjE3Cj4gPiA+IC0gVXBkYXRlIHRoZSB5ZWFyIG9mIENvcHlyaWdodCBmcm9tIDIwMjIg dG8gMjAyMwo+ID4gPgo+ID4gPiAtLS0KPiA+ID4gIGRyaXZlcnMvbGVkcy9yZ2IvS2NvbmZpZyAg ICAgICAgICAgfCAgIDEzICsKPiA+ID4gIGRyaXZlcnMvbGVkcy9yZ2IvTWFrZWZpbGUgICAgICAg ICAgfCAgICAxICsKPiA+ID4gIGRyaXZlcnMvbGVkcy9yZ2IvbGVkcy1tdDYzNzAtcmdiLmMgfCAx MDA5ICsrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKwo+ID4gPiAgMyBmaWxlcyBj aGFuZ2VkLCAxMDIzIGluc2VydGlvbnMoKykKPiA+ID4gIGNyZWF0ZSBtb2RlIDEwMDY0NCBkcml2 ZXJzL2xlZHMvcmdiL2xlZHMtbXQ2MzcwLXJnYi5jCgpbLi4uXQoKPiA+ID4gK3N0YXRpYyBpbnQg bXQ2MzcwX2dlbl9icmVhdGhfcGF0dGVybihzdHJ1Y3QgbXQ2MzcwX3ByaXYgKnByaXYsCj4gPiA+ ICsJCQkJICAgICBzdHJ1Y3QgbGVkX3BhdHRlcm4gKnBhdHRlcm4sIHUzMiBsZW4sCj4gPiA+ICsJ CQkJICAgICB1OCAqcGF0dGVybl92YWwsIHUzMiB2YWxfbGVuKQo+ID4gPiArewo+ID4gPiArCWVu dW0gbXQ2MzcwX2xlZF9yYW5nZXMgc2VsX3JhbmdlOwo+ID4gPiArCXN0cnVjdCBsZWRfcGF0dGVy biAqY3VycjsKPiA+ID4gKwl1bnNpZ25lZCBpbnQgc2VsOwo+ID4gPiArCXUzMiB2YWwgPSAwOwo+ ID4gPiArCWludCBpOwo+ID4gPiArCj4gPiA+ICsJaWYgKGxlbiA8IFBfTUFYX1BBVFRFUk5TICYm IHZhbF9sZW4gPCBQX01BWF9QQVRURVJOUyAvIDIpCj4gPiA+ICsJCXJldHVybiAtRUlOVkFMOwo+ ID4gPiArCj4gPiA+ICsJLyoKPiA+ID4gKwkgKiBQYXR0ZXJuIGxpc3QKPiA+ID4gKwkgKiB0cjE6 CSBieXRlIDAsIGInWzc6IDRdCj4gPgo+ID4gUGVyaGFwcyB0aGlzIGlzIHN0YW5kYXJkIGZvcm1h dHRpbmcgYW5kIEknbSBqdXN0IG5vdCBhd2FyZSBvZiBpdCwgYnV0Cj4gPiB0aGUgc3BhY2UgaXMg dGhyb3dpbmcgbWUgYW5kIG1ha2luZyBtZSB0aGluayB0d2ljZS4gIERvZXMgdGhpcyBtZWFuIGJp dHMKPiA+IDcgdGhyb3VnaCA0LCBzbyBiJzExMTEwMDAwPwo+ID4KPiBZZXMuIGxpa2UgYXMgeW91 IHNhaWQuIFNvcnJ5IGZvciB0aGUgcmVkdWRhbnQgc3BhY2UgbWFrZSB5b3UgY29uZnVzZWQuCj4g SSdtIG5vdCBzdXJlIHdoZXRoZXIgaXQncyBhIHN0YW5kYXJkIGZvcm1hdGluZyBvciBub3QuCj4g U29tZXRpbWVzLCBpbiBkYXRhc2hlZXQsIHdlJ2xsIHVzZSB0aGlzIGZvcm1hdCB0byByZXByZXNl bnQgdGhlIGJpdGZpZWxkIGZvciBmdW5jdGlvbnMuCj4gWW91ciBmb3JtYXQgaXMgYWxzbyBnb29k IGZvciBpdC4KPiBBbmQgd2hpY2ggb25lIGlzIHByZWZlcmFibGU/CgpTaW5jZSBuZWl0aGVyIG9m IHVzIGFyZSBzdXJlLCBqdXN0IHRha2UgdGhlIHNwYWNlIG91dCBmb3Igbm93IHBsZWFzZS4KCj4g PiA+ICsJICogdHIyOgkgYnl0ZSAwLCBiJ1szOiAwXQo+ID4gPiArCSAqIHRmMToJIGJ5dGUgMSwg YidbNzogNF0KPiA+ID4gKwkgKiB0ZjI6CSBieXRlIDEsIGInWzM6IDBdCj4gPiA+ICsJICogdG9u OgkgYnl0ZSAyLCBiJ1s3OiA0XQo+ID4gPiArCSAqIHRvZmY6IGJ5dGUgMiwgYidbMzogMF0KPiA+ ID4gKwkgKi8KPiA+ID4gKwlmb3IgKGkgPSAwOyBpIDwgUF9NQVhfUEFUVEVSTlM7IGkrKykgewo+ ID4gPiArCQljdXJyID0gcGF0dGVybiArIGk7Cj4gPiA+ICsKPiA+ID4gKwkJc2VsX3JhbmdlID0g aSA9PSBQX0xFRF9UT0ZGID8gUl9MRURfVE9GRiA6IFJfTEVEX1RSRk9OOwo+ID4gPiArCj4gPiA+ ICsJCWxpbmVhcl9yYW5nZV9nZXRfc2VsZWN0b3Jfd2l0aGluKHByaXYtPnJhbmdlcyArIHNlbF9y YW5nZSwKPiA+ID4gKwkJCQkJCSBjdXJyLT5kZWx0YV90LCAmc2VsKTsKPiA+ID4gKwo+ID4gPiAr CQlpZiAoaSAlIDIpIHsKPiA+ID4gKwkJCXZhbCB8PSBzZWw7Cj4gPiA+ICsJCX0gZWxzZSB7Cj4g PiA+ICsJCQl2YWwgPDw9IDg7Cj4gPiA+ICsJCQl2YWwgfD0gc2VsIDw8IDQ7Cj4gPiA+ICsJCX0K PiA+ID4gKwl9CgpbLi4uXQoKPiA+ID4gK3N0YXRpYyBpbnQgbXQ2MzcwX2xlZF9yZWdpc3Rlcihz dHJ1Y3QgZGV2aWNlICpkZXYsIHN0cnVjdCBtdDYzNzBfbGVkICpsZWQsCj4gPiA+ICsJCQkgICAg ICAgc3RydWN0IGxlZF9pbml0X2RhdGEgKmluaXRfZGF0YSkKPiA+ID4gK3sKPiA+ID4gKwlzdHJ1 Y3QgbXQ2MzcwX3ByaXYgKnByaXYgPSBsZWQtPnByaXY7Cj4gPiA+ICsJaW50IHJldDsKPiA+ID4g Kwo+ID4gPiArCWlmIChsZWQtPmluZGV4ID09IE1UNjM3MF9WSVJUVUFMX01VTFRJQ09MT1IpIHsK PiA+Cj4gPiBUaGlzIHRvbyBjb3VsZCBiZSBzcGxpdCBpbnRvIHNlcGFyYXRlIGZ1bmN0aW9ucyB0 byB0aWR5IHRoaW5ncyB1cCBhCj4gPiBsaXR0bGUuCj4gPgo+IExpa2UgYXMgYmVsb3c/Cj4KPiBp ZiAobGVkLT5pbmRleCA9PSBNVDYzNzBfVklSVFVBTF9NVUxUSUNPTE9SKQo+ICAgIHJldHVybiBt dDYzNzBfbXVsdGljb2xvcl9sZWRfcmVnaXN0ZXIoLi4uLikKPgo+IGlmIChsZWQtPmluZGV4ID09 IE1UNjM3MF9MRURfSVNOSzQpIHsKPiAgICAgLi4uLi4KPiB9Cj4KPiByZXQgPSBtdDYzNzBfaW5p dF9pc25rX2RlZmF1bHRfc3RhdGUoLi4uKQoKWWVzLCB0aGF0IGtpbmQgb2YgdGhpbmcuCgo+IFNp bmNlIHRoZSBtdWx0aWxvciBjYXNlIGRpcmVjdGx5IHJldHVybiBmcm9tIHRoZSBzdWItZnVuY3Rp b24sIGVsc2UgY2FuIGJlIHJlbW92ZWQuCgo+ID4gPiArCQlyZXQgPSBtdDYzNzBfbWNfYnJpZ2h0 bmVzc19zZXQoJmxlZC0+bWMubGVkX2NkZXYsIDApOwo+ID4gPiArCQlpZiAocmV0KQo+ID4gPiAr CQkJcmV0dXJuIGRldl9lcnJfcHJvYmUoZGV2LCByZXQsICJDb3VsZG4ndCBzZXQgbXVsdGljb2xv ciBicmlnaHRuZXNzXG4iKTsKPiA+ID4gKwo+ID4gPiArCQlyZXQgPSBkZXZtX2xlZF9jbGFzc2Rl dl9tdWx0aWNvbG9yX3JlZ2lzdGVyX2V4dChkZXYsICZsZWQtPm1jLAo+ID4gPiArCQkJCQkJCQlp bml0X2RhdGEpOwo+ID4gPiArCQlpZiAocmV0KQo+ID4gPiArCQkJcmV0dXJuIGRldl9lcnJfcHJv YmUoZGV2LCByZXQsICJDb3VsZG4ndCByZWdpc3RlciBtdWx0aWNvbG9yXG4iKTsKPiA+ID4gKwl9 IGVsc2Ugewo+ID4gPiArCQlpZiAobGVkLT5pbmRleCA9PSBNVDYzNzBfTEVEX0lTTks0KSB7Cj4g PiA+ICsJCQlyZXQgPSByZWdtYXBfZmllbGRfd3JpdGUocHJpdi0+ZmllbGRzW0ZfQ0hHSU5EX0VO XSwgMSk7Cj4gPiA+ICsJCQlpZiAocmV0KQo+ID4gPiArCQkJCXJldHVybiBkZXZfZXJyX3Byb2Jl KGRldiwgcmV0LCAiRmFpbGVkIHRvIHNldCBDSFJJTkQgdG8gU1dcbiIpOwo+ID4gPiArCQl9Cj4g PiA+ICsKPiA+ID4gKwkJcmV0ID0gbXQ2MzcwX2lzbmtfaW5pdF9kZWZhdWx0X3N0YXRlKGxlZCk7 Cj4gPiA+ICsJCWlmIChyZXQpCj4gPiA+ICsJCQlyZXR1cm4gZGV2X2Vycl9wcm9iZShkZXYsIHJl dCwgIkZhaWxlZCB0byBpbml0ICVkIGlzbmsgc3RhdGVcbiIsCj4gPiA+ICsJCQkJCSAgICAgbGVk LT5pbmRleCk7Cj4gPiA+ICsKPiA+ID4gKwkJcmV0ID0gZGV2bV9sZWRfY2xhc3NkZXZfcmVnaXN0 ZXJfZXh0KGRldiwgJmxlZC0+aXNpbmssCj4gPiA+ICsJCQkJCQkgICAgIGluaXRfZGF0YSk7Cj4g PiA+ICsJCWlmIChyZXQpCj4gPiA+ICsJCQlyZXR1cm4gZGV2X2Vycl9wcm9iZShkZXYsIHJldCwg IkNvdWxkbid0IHJlZ2lzdGVyIGlzaW5rICVkXG4iLCBsZWQtPmluZGV4KTsKPiA+ID4gKwl9Cj4g PiA+ICsKPiA+ID4gKwlyZXR1cm4gMDsKPiA+ID4gK30KPiA+ID4gKwo+ID4gPiArc3RhdGljIGlu dCBtdDYzNzBfY2hlY2tfdmVuZG9yX2luZm8oc3RydWN0IG10NjM3MF9wcml2ICpwcml2KQo+ID4g PiArewo+ID4gPiArCXVuc2lnbmVkIGludCBkZXZpbmZvLCB2aWQ7Cj4gPiA+ICsJaW50IHJldDsK PiA+ID4gKwo+ID4gPiArCXJldCA9IHJlZ21hcF9yZWFkKHByaXYtPnJlZ21hcCwgTVQ2MzcwX1JF R19ERVZfSU5GTywgJmRldmluZm8pOwo+ID4gPiArCWlmIChyZXQpCj4gPiA+ICsJCXJldHVybiBy ZXQ7Cj4gPiA+ICsKPiA+ID4gKwl2aWQgPSBGSUVMRF9HRVQoTVQ2MzcwX1ZFTklEX01BU0ssIGRl dmluZm8pOwo+ID4gPiArCWlmICh2aWQgPT0gMHg5IHx8IHZpZCA9PSAweGIpIHsKPiA+Cj4gPiBB cmUgdGhlcmUgbmljZSBodW1hbiByZWFkYWJsZSBhc3NvY2lhdGVzIG9mIHRoZXNlICh2ZW5kb3I/ KSBJRFM/Cj4gPgo+IEZvciBjbGVhcmx5IHVuZGVyc3RhbmRpbmcsIEknbGwgZGVmaW5lIHRoZXNl IHR3byBhcyAnTVQ2MzcyX1ZFTkRPUl9JRCcgYW5kICdNVDYzNzJDX1ZFTkRPUl9JRCcuCgpNdWNo IGJldHRlciwgdGhhbmsgeW91LgoKLS0KTGVlIEpvbmVzIFvmnY7nkLzmlq9dCgpfX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpsaW51eC1hcm0ta2VybmVsIG1h aWxpbmcgbGlzdApsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xp c3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1hcm0ta2VybmVsCg==