From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Cc: "Rafał Miłecki" <zajec5@gmail.com>,
"Rob Herring" <robh+dt@kernel.org>,
"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
"Shawn Guo" <shawnguo@kernel.org>,
"Sascha Hauer" <s.hauer@pengutronix.de>,
"Pengutronix Kernel Team" <kernel@pengutronix.de>,
"Fabio Estevam" <festevam@gmail.com>,
"NXP Linux Team" <linux-imx@nxp.com>,
"Michael Walle" <michael@walle.cc>,
gregkh@linuxfoundation.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, u-boot@lists.denx.de,
"Rafał Miłecki" <rafal@milecki.pl>
Subject: Re: [PATCH 2/4] nvmem: core: allow nvmem_cell_post_process_t callbacks to adjust buffer
Date: Thu, 9 Mar 2023 11:32:11 +0100 [thread overview]
Message-ID: <20230309113211.6321ce3d@xps-13> (raw)
In-Reply-To: <37f821b8-f681-08e4-d4f1-d37be191ff7f@linaro.org>
Hi Srinivas,
srinivas.kandagatla@linaro.org wrote on Thu, 9 Mar 2023 10:12:24 +0000:
> On 22/02/2023 17:22, Rafał Miłecki wrote:
> > @@ -1791,11 +1792,15 @@ ssize_t nvmem_device_cell_read(struct nvmem_device *nvmem,
> > if (!nvmem)
> > return -EINVAL;
> > > + /* Cells with read_post_process hook may realloc buffer we can't allow here */
> > + if (info->read_post_process)
> > + return -EINVAL;
> This should probably go in 1/4 patch. Other than that series looks good to me.
FYI patch 1/4 is also carried by the nvmem-layouts series, so it's
probably best to keep these 2 patches separated to simplify the merging.
Thanks,
Miquèl
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-03-09 10:33 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-22 17:22 [PATCH 0/4] nvmem: cell post-processing & U-Boot env MAC support Rafał Miłecki
2023-02-22 17:22 ` [PATCH 1/4] nvmem: core: add per-cell post processing Rafał Miłecki
2023-02-22 17:22 ` [PATCH 2/4] nvmem: core: allow nvmem_cell_post_process_t callbacks to adjust buffer Rafał Miłecki
2023-03-09 10:12 ` Srinivas Kandagatla
2023-03-09 10:32 ` Miquel Raynal [this message]
2023-03-09 10:53 ` Srinivas Kandagatla
2023-03-09 11:23 ` Miquel Raynal
2023-03-09 11:44 ` Srinivas Kandagatla
2023-03-09 11:52 ` Rafał Miłecki
2023-03-09 13:10 ` Miquel Raynal
2023-03-09 13:31 ` Rafał Miłecki
2023-03-10 9:25 ` Srinivas Kandagatla
2023-02-22 17:22 ` [PATCH 3/4] dt-bindings: nvmem: u-boot,env: add MAC's #nvmem-cell-cells Rafał Miłecki
2023-02-22 17:22 ` [PATCH 4/4] nvmem: u-boot-env: post-process "ethaddr" env variable Rafał Miłecki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230309113211.6321ce3d@xps-13 \
--to=miquel.raynal@bootlin.com \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=kernel@pengutronix.de \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=michael@walle.cc \
--cc=rafal@milecki.pl \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=srinivas.kandagatla@linaro.org \
--cc=u-boot@lists.denx.de \
--cc=zajec5@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).