From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D8B35C61DA4 for ; Sat, 11 Mar 2023 18:07:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=/qml5T24mxrL/XK7gagDXJTrYskektqmR2u6FX700I8=; b=2mThhNRzIjNS6T HyeBBY1LqgE4gUyHXrMnZAQ6WqUgO3N4sUbcoYf+oNyiOkq98XwM9zGjnPQxX9eIj8DZXig8LrYOL wADMxi9rH2gyJtLypo6YZxPZ0TBxj+PszXPmyV4weCcNm3/H6aP0m09GlHkXjbz5ERrYxMUY9ARDR 9NxQt8XJwbVinRVtgIly237908w6MtRtDrwLgHNFb0RfZeGIuY1f8FWwvrvHJl92H89ti7/GRY3ms owZNUQjP3exYzS96qKOLdpBOZo4hl+SVOHUKGb0mYncGuwAUdcHHGWmnQIb5amrURouFZ5YNtqBLu T0LnrckHeu6VPwuVMjfQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pb3cE-0011de-Ev; Sat, 11 Mar 2023 18:06:46 +0000 Received: from ams.source.kernel.org ([2604:1380:4601:e00::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pb3cA-0011cX-Br for linux-arm-kernel@lists.infradead.org; Sat, 11 Mar 2023 18:06:44 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id B2B9BB802C5; Sat, 11 Mar 2023 18:06:39 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9F786C433D2; Sat, 11 Mar 2023 18:06:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1678557997; bh=GOsprbGMCTh8vvgH1NxGTJsbnd6+WJTpWCk1MiS32Gk=; h=Date:From:To:List-Id:Cc:Subject:In-Reply-To:References:From; b=DrxiGBbb1pdW3L1oTqoeTZx2r6BeE0tjerapNGJhWJdundfZF5pX2bcxJSOrkKdFs X51go0vh7SkfaMa3QBWxAuunqtjPvN4/TWdYc54bQWkpnt8RSu/mlnVb3vX7E63WCC uO9qYaaaSzaI+DiasaMU7FFxztkIW2QL+6kV2xvJwWwG2WuqvlSz4rrQhSawd+trAi Z86zZrw2MT5ECxOO97QnhAEUX1jUkvsi/K87IKxH7UklGYj1C+lCloIOKJOXpSdXQy CV1+Xjm+dQmnBnHrgj9js2hyZGKrC46WS9p35GCp/PEEB1HiHdG6/wRMttzYt8XRQi 4NgiZMPm3JC8A== Date: Sat, 11 Mar 2023 18:06:40 +0000 From: Jonathan Cameron To: Stefan Wahren Cc: Krzysztof Kozlowski , Rob Herring , Krzysztof Kozlowski , Lars-Peter Clausen , Arnd Bergmann , Olof Johansson , Evgeniy Polyakov , Shawn Guo , Sascha Hauer , Fabio Estevam , linux-imx@nxp.com, Li Yang , Denis Ciocca , soc@kernel.org, linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Stefan Wahren Subject: Re: [PATCH 4/8] dt-bindings: iio: st-sensors: Add IIS328DQ accelerometer Message-ID: <20230311180640.4f975f78@jic23-huawei> In-Reply-To: <9c2d0ca3-660e-72d2-d158-5c921cd9d607@i2se.com> References: <20230306172249.74003-1-stefan.wahren@i2se.com> <20230306172249.74003-5-stefan.wahren@i2se.com> <633b1e27-d148-62d2-ef83-2d0da432c0a7@linaro.org> <9c2d0ca3-660e-72d2-d158-5c921cd9d607@i2se.com> X-Mailer: Claws Mail 4.1.1 (GTK 3.24.37; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230311_100642_750632_18C20DCC X-CRM114-Status: GOOD ( 22.77 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, 7 Mar 2023 18:27:53 +0100 Stefan Wahren wrote: > Hi Krzysztof, > > Am 07.03.23 um 09:23 schrieb Krzysztof Kozlowski: > > On 06/03/2023 18:22, Stefan Wahren wrote: > >> From: Stefan Wahren > >> > >> The ST IIS328DQ is an accelerometer sensor compatible with > >> the existing ST sensor binding. > > If it is compatible with existing binding, then make it compatible. > > Although your driver change suggests it is not compatible... > since the policy is to make the compatible so specific as possible, i > will fix the wording here. Driver changes are naming only - which we do want as that isn't discoverable from the device but it will 'work' fine with a fallback compatible of st,h3lis331dl-accel be it with wrong device naming exposed to userspace. Hmm. That shouldn't have the postfix as it's not a multi device package (which are the cases where we need postfix as they have multiple drivers binding to different independent things in the one package / part number) If someone wants to add a compatible of st,h3lis331dl and deprecate the accel variant that would be fine, but wouldn't help us much here for a fallback compatible and it's probably not worth the effort. Historically we've not been doing fallback compatibles right in this driver but it's probably not worth 'fixing' that for old devices as the only real benefit would be things working nicely with old kernels. Nice to not make it worse though. So I'd like to see this fallback to st,h3lis331dl-accel Jonathan > > > > Best regards, > > Krzysztof > > > > > > _______________________________________________ > > linux-arm-kernel mailing list > > linux-arm-kernel@lists.infradead.org > > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel