From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3C095C6FD1C for ; Sat, 11 Mar 2023 18:09:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=pBkR+rdfu+b+4kFnjTtLL669Wy3cBKXyBFAKv7MFavs=; b=yctfUHE/pmQBch hmaPNJ1+UGcyIYYSz8N7N/XC3hwIt5GCH+8+LZu/s5c8wQreb0/KudeNgGdOeHPnDXFZQDcKBg3zl aKbVjM3I7cLzBzQHnWitDomAMlYe82h3slLyOrg3z0yU9XjCezAamJ/WrV3ml5Ht7AcOUvSVM90Dn gBf5GApBfu+uWsInZmtImE7T73lPm7lEQB6vzKXh5WV4ZPARlw8KwyfVT0XWj+wp8fAiFnaNDb4GN KTCdYlZkRnuPy2m+DhJHV3NcEpT1qtohYPfNgtDJ68pUcLYLhqV3JmjzSN6ubRZ396mjAippv4Zp+ b+nmlp9LUGL4sO5ex7kQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pb3eK-0011ud-9Y; Sat, 11 Mar 2023 18:08:56 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pb3eH-0011u5-3D for linux-arm-kernel@lists.infradead.org; Sat, 11 Mar 2023 18:08:54 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 8781260DE2; Sat, 11 Mar 2023 18:08:48 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8673AC4339B; Sat, 11 Mar 2023 18:08:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1678558126; bh=Hxwcyty0Eai6b4gI+GWKz8jsfgHY5+szBl5RoUwvZBg=; h=Date:From:To:List-Id:Cc:Subject:In-Reply-To:References:From; b=mn01IHeTgKouFJx2YZJ3r60NByaSimffuGy7a0j4HdNJDzsZNK9QECzYSY6Zpbv+F EOx7N0WA493Iyb8M+FpyvV8V4SYR9XuNBOizPJeYxBkZ6vS0t9Oe+OOn7I5gzjskbJ IKsj0tIRbXUcuEmL2vlQxxut/0THYHmfQ9XCbNHvg80l5qZ8sfvuOIpM1Ukg6DcVCq w72IXolYh3WKliqMJxtdYvKjLnqHdUFBAnccQ9X+TJbeg/YJOPbYhgRcQKh4atFWOk alD9NWjAEfZOWYJhsbvM0dw19Nc5eXiwX8sF/C1OJB5ItSmXpf+OyFyv6C/eoVUJDf sUs0+Nc/tCkJQ== Date: Sat, 11 Mar 2023 18:08:49 +0000 From: Jonathan Cameron To: Stefan Wahren Cc: Rob Herring , Krzysztof Kozlowski , Lars-Peter Clausen , Arnd Bergmann , Olof Johansson , Evgeniy Polyakov , Shawn Guo , Sascha Hauer , Fabio Estevam , linux-imx@nxp.com, Li Yang , Denis Ciocca , soc@kernel.org, linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Stefan Wahren Subject: Re: [PATCH 5/8] iio: accel: add support for IIS328DQ variant Message-ID: <20230311180849.0a8f58a3@jic23-huawei> In-Reply-To: <20230306172249.74003-6-stefan.wahren@i2se.com> References: <20230306172249.74003-1-stefan.wahren@i2se.com> <20230306172249.74003-6-stefan.wahren@i2se.com> X-Mailer: Claws Mail 4.1.1 (GTK 3.24.37; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230311_100853_243486_EB7CBC1F X-CRM114-Status: GOOD ( 18.62 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, 6 Mar 2023 18:22:46 +0100 Stefan Wahren wrote: > From: Stefan Wahren > > Add support for ST IIS328DQ accelerometer to the st_accel framework. > The chip is compatible to the LIS331DL. > > Link: https://www.st.com/resource/en/datasheet/iis328dq.pdf > Signed-off-by: Stefan Wahren > Signed-off-by: Stefan Wahren LGTM. I'll pick up when the binding discussion concludes. (assuming no other issues raised!) Jonathan > --- > drivers/iio/accel/st_accel.h | 1 + > drivers/iio/accel/st_accel_core.c | 1 + > drivers/iio/accel/st_accel_i2c.c | 5 +++++ > drivers/iio/accel/st_accel_spi.c | 5 +++++ > 4 files changed, 12 insertions(+) > > diff --git a/drivers/iio/accel/st_accel.h b/drivers/iio/accel/st_accel.h > index 56ed0c776d4a..e7525615712b 100644 > --- a/drivers/iio/accel/st_accel.h > +++ b/drivers/iio/accel/st_accel.h > @@ -39,6 +39,7 @@ > #define LIS302DL_ACCEL_DEV_NAME "lis302dl" > #define LSM303C_ACCEL_DEV_NAME "lsm303c_accel" > #define SC7A20_ACCEL_DEV_NAME "sc7a20" > +#define IIS328DQ_ACCEL_DEV_NAME "iis328dq" > > > #ifdef CONFIG_IIO_BUFFER > diff --git a/drivers/iio/accel/st_accel_core.c b/drivers/iio/accel/st_accel_core.c > index 6b8562f684d5..5f7d81b44b1d 100644 > --- a/drivers/iio/accel/st_accel_core.c > +++ b/drivers/iio/accel/st_accel_core.c > @@ -517,6 +517,7 @@ static const struct st_sensor_settings st_accel_sensors_settings[] = { > .wai_addr = ST_SENSORS_DEFAULT_WAI_ADDRESS, > .sensors_supported = { > [0] = H3LIS331DL_ACCEL_DEV_NAME, > + [1] = IIS328DQ_ACCEL_DEV_NAME, > }, > .ch = (struct iio_chan_spec *)st_accel_12bit_channels, > .odr = { > diff --git a/drivers/iio/accel/st_accel_i2c.c b/drivers/iio/accel/st_accel_i2c.c > index 3f02fd5d5946..fb9e2d6f4210 100644 > --- a/drivers/iio/accel/st_accel_i2c.c > +++ b/drivers/iio/accel/st_accel_i2c.c > @@ -119,6 +119,10 @@ static const struct of_device_id st_accel_of_match[] = { > .compatible = "silan,sc7a20", > .data = SC7A20_ACCEL_DEV_NAME, > }, > + { > + .compatible = "st,iis328dq", > + .data = IIS328DQ_ACCEL_DEV_NAME, > + }, > {}, > }; > MODULE_DEVICE_TABLE(of, st_accel_of_match); > @@ -157,6 +161,7 @@ static const struct i2c_device_id st_accel_id_table[] = { > { LIS302DL_ACCEL_DEV_NAME }, > { LSM303C_ACCEL_DEV_NAME }, > { SC7A20_ACCEL_DEV_NAME }, > + { IIS328DQ_ACCEL_DEV_NAME }, > {}, > }; > MODULE_DEVICE_TABLE(i2c, st_accel_id_table); > diff --git a/drivers/iio/accel/st_accel_spi.c b/drivers/iio/accel/st_accel_spi.c > index 5740dc1820bd..f72a24f45322 100644 > --- a/drivers/iio/accel/st_accel_spi.c > +++ b/drivers/iio/accel/st_accel_spi.c > @@ -100,6 +100,10 @@ static const struct of_device_id st_accel_of_match[] = { > .compatible = "st,lsm303c-accel", > .data = LSM303C_ACCEL_DEV_NAME, > }, > + { > + .compatible = "st,iis328dq", > + .data = IIS328DQ_ACCEL_DEV_NAME, > + }, > {} > }; > MODULE_DEVICE_TABLE(of, st_accel_of_match); > @@ -157,6 +161,7 @@ static const struct spi_device_id st_accel_id_table[] = { > { LIS3DE_ACCEL_DEV_NAME }, > { LIS302DL_ACCEL_DEV_NAME }, > { LSM303C_ACCEL_DEV_NAME }, > + { IIS328DQ_ACCEL_DEV_NAME }, > {}, > }; > MODULE_DEVICE_TABLE(spi, st_accel_id_table); _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel