From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8D796C6FD1C for ; Sat, 11 Mar 2023 19:07:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=8yVWd2WKJcSnhUNCsJBps2XExgyRN1+n2MR7MVJvdI4=; b=Jty6pTjJlWujpE XYyEmr5h+FVUduT0HKdZ64xDALG2tIuJ6VkcUHS4W8nbbqyEPjLkiceHIERnZCQIHpIcJPUnU+doP 1Kpmlvwj84Qp3+jdMoHr+LZkoLUkez08sa8hHkJn8qn6yv7//ZXAJZc8//1j4bPC6igPLmYo1jhOt jAcw0DL6upXxzoQTaVw2nDX94781ManpmFWI1HSRo3NjmF7kEB025eCbQxZWSSlHO7BYjdJZDvY0j TCVXSJm9/CTXnOkno/FQmxvbOC/QUFsNtJEDeNTtUmodbzaHPvnByrNAjOlDk6pcgeVR6cgJuhyxc KnK07sScEfFOG6GefRSw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pb4Xy-0015gY-Mp; Sat, 11 Mar 2023 19:06:26 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pb4Xv-0015fr-N1 for linux-arm-kernel@lists.infradead.org; Sat, 11 Mar 2023 19:06:24 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id F1E9260DE4; Sat, 11 Mar 2023 19:06:22 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C8F91C433EF; Sat, 11 Mar 2023 19:06:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1678561582; bh=OVpVDAx6o+qPxZLHPJLKgJrkkAtgPU+JJrR+L7/ayqg=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=OxedlAcIv6lwoziD8w1j78pxnHMQD6CZ5pJHdoDz8EZOhPS+l/mDwjnL4ELyJwifX nm9p8l/u/CqrG6H3CO+DxKZfMXclPDX5ZHaQDn+9lrDBjBvx/S7cxPqKvQma0gyY7s 6nuFXWlmsVLZt+w3gwiS2XGZYlKc39mdw7qi6dG6M1VI9ERmMzDVL3Z0xStdUi/RL8 uTiPGiEAowtwJ0rxpLRBjWl3T66E579rxEaPd6b9wEM1BdhYKI+zZgzwUNMHh2OrxN 7z5+4xzSbvgLZjFBpDwCVlRZgSuhD2lw5S5tE5K/aSiPUl1t+7G2783NYiq5YmG7Jj 18/vGvTfKaWEw== Date: Sat, 11 Mar 2023 19:06:25 +0000 From: Jonathan Cameron To: James Clark Cc: linux-kernel@vger.kernel.org, linux@roeck-us.net, michal.simek@amd.com, Jonathan Corbet , Jean Delvare , Anand Ashok Dumbre , Lars-Peter Clausen , Michal Simek , Andy Gross , Bjorn Andersson , Konrad Dybcio , Greg Kroah-Hartman , Jiri Slaby , linux-doc@vger.kernel.org, linux-hwmon@vger.kernel.org, linux-iio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-serial@vger.kernel.org Subject: Re: [PATCH v2 2/4] hwmon: pmbus: Use devm_krealloc_array Message-ID: <20230311190625.1618bbf4@jic23-huawei> In-Reply-To: <20230309150334.216760-3-james.clark@arm.com> References: <20230309150334.216760-1-james.clark@arm.com> <20230309150334.216760-3-james.clark@arm.com> X-Mailer: Claws Mail 4.1.1 (GTK 3.24.37; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230311_110623_818181_3CD93632 X-CRM114-Status: GOOD ( 17.25 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, 9 Mar 2023 15:03:31 +0000 James Clark wrote: > Now that it exists, use it instead of doing the multiplication manually. > > Acked-by: Guenter Roeck > Signed-off-by: James Clark FWIW LGTM Reviewed-by: Jonathan Cameron > --- > drivers/hwmon/pmbus/pmbus_core.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/hwmon/pmbus/pmbus_core.c b/drivers/hwmon/pmbus/pmbus_core.c > index 95e95783972a..e7bee25a3706 100644 > --- a/drivers/hwmon/pmbus/pmbus_core.c > +++ b/drivers/hwmon/pmbus/pmbus_core.c > @@ -1190,9 +1190,9 @@ static int pmbus_add_attribute(struct pmbus_data *data, struct attribute *attr) > { > if (data->num_attributes >= data->max_attributes - 1) { > int new_max_attrs = data->max_attributes + PMBUS_ATTR_ALLOC_SIZE; > - void *new_attrs = devm_krealloc(data->dev, data->group.attrs, > - new_max_attrs * sizeof(void *), > - GFP_KERNEL); > + void *new_attrs = devm_krealloc_array(data->dev, data->group.attrs, > + new_max_attrs, sizeof(void *), > + GFP_KERNEL); > if (!new_attrs) > return -ENOMEM; > data->group.attrs = new_attrs; _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel