From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7093EC6FA99 for ; Sun, 12 Mar 2023 21:41:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=j88v2izhcyFLWTP34H7KhlUlokq5tUeB7y+2HpX+Hbc=; b=LnTkSK469f1gPf vr8qwr2yGSQSLWK4gf5dGPQegGAXlSHXhfim83Z+fWhfWOiFkKjisKaXS1Ef5G/bPHupCkHefLUBD M6SqR3j3J/ZaGcLy8cclP2d1IUL0lsxefWpuf3eaXbj6lNKD6cAgyE72nOvfaDJSTQuwbmW9X5Pi7 yYIGBcbEte8oS3brRsqRU58YsdQQBEJrmG8I5G9iF7EhMamNnb12ekqUF6Mw6He1wPMczOVD1ckq2 rVWXs2UpllUdZuskz04mKSyQt1Xv5lVxsfhxJ3z6ch3CC67tHXkD45eRC6YczU5OBOUr8E8i2ufGV yZDZ/ZassOSSr50ylPSw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pbTR1-003dzr-FI; Sun, 12 Mar 2023 21:40:55 +0000 Received: from mail.andi.de1.cc ([2a01:238:4321:8900:456f:ecd6:43e:202c]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pbTQx-003dzI-Mr for linux-arm-kernel@lists.infradead.org; Sun, 12 Mar 2023 21:40:53 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=kemnade.info; s=20220719; h=Content-Transfer-Encoding:Content-Type: MIME-Version:References:In-Reply-To:Message-ID:Subject:Cc:To:From:Date:Sender :Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help: List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=6f6Y7LE26iLoc26gBiJX3yiT5sQ5r15wZSUvx/W8T2A=; b=y2xckxbzEJzBEgBXHPIVBi2S5P UOXuf6LR3jI+mDoCJcROEk8+QZAVMKQMy6jcaPcTGf3P9EWu7CLbwilK71/BMlmFPGvcj/Wama3uh 7zuZ8IlLHOhLtlC5ehRWNaoMegk+YK9LGXZyJser799SUPp0Vc5PweubB9nEqH48aXCLT2cZPvdu+ MDyQeu5hHvJUnX4mVks9otMqJzxHUfjzxK+XWjsy6HFJbdtz5tiHEXLF9pSzZsOMNbdh6j1OzISfH QZKi96XqBFMSUwGgent5ylrhlt31GmymF7ILDxWPyHKjFHN8GDWdhVRzXc+WTvBXucGjCknXvWqXY CuGe8bOw==; Received: from p200300ccff059e001a3da2fffebfd33a.dip0.t-ipconnect.de ([2003:cc:ff05:9e00:1a3d:a2ff:febf:d33a] helo=aktux) by mail.andi.de1.cc with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1pbTQk-00045m-9W; Sun, 12 Mar 2023 22:40:38 +0100 Date: Sun, 12 Mar 2023 22:40:36 +0100 From: Andreas Kemnade To: Krzysztof Kozlowski Cc: robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, arnd@arndb.de, olof@lixom.net, soc@kernel.org, shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com, marex@denx.de, max.krummenacher@toradex.com, leoyang.li@nxp.com, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 2/2] ARM: dts: imx: Add devicetree for Tolino Vison Message-ID: <20230312224036.37dc4d41@aktux> In-Reply-To: <1346ce4e-f1fd-1a77-f38e-cd87efc59082@linaro.org> References: <20230312205236.2281466-1-andreas@kemnade.info> <20230312205236.2281466-3-andreas@kemnade.info> <1346ce4e-f1fd-1a77-f38e-cd87efc59082@linaro.org> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230312_144051_956799_C1445BC4 X-CRM114-Status: GOOD ( 13.55 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sun, 12 Mar 2023 22:02:24 +0100 Krzysztof Kozlowski wrote: > On 12/03/2023 21:52, Andreas Kemnade wrote: > > This adds a devicetree for the Kobo Aura 2 Ebook reader. It is based > > on boards marked with "37NB-E60Q30+4A3". It is equipped with an i.MX6SL > > SoC. > > > > Thank you for your patch. There is something to discuss/improve. [...] > > + pinctrl_i2c2: i2c2grp { > > + fsl,pins = < > > + MX6SL_PAD_I2C2_SCL__I2C2_SCL 0x4001f8b1 > > + MX6SL_PAD_I2C2_SDA__I2C2_SDA 0x4001f8b1 > > + >; > > + }; > > + > > + pinctrl_i2c2_sleep: i2c2grp-sleep { > > Shouldn't all groups end with 'grp' suffix? Are you sure this passes > dtbs_check? > > ... > No problem with dtbs_check. But I will resend with corrected names. Regards, Andreas _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel