From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DE7B1C61DA4 for ; Mon, 13 Mar 2023 10:41:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:CC:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=06Ij+T+TmJhOp2CarFZPCelD2RqohLxBJ1VM+xqfa/A=; b=xKA/hzUkwLq3S+ 3+lghLa0yicXvoBLIXwdhZRR0UYUjSJ7MKqvhTgYfdD56l3OcTFy+6WNl0h7tPChtbmb8x04DoMai z8YktwkVubAwaGrFDS7BiN626WblOjv/71mDXOR7lSeoT9nC336j7aqo1tQOfxetBchzppPmG+5yr xsKu0s0rSmt0IHwc/EWLEl7S4IwrTU7vcTrir5RaZYJI7ySp89z/GuXR9oQgrsOUxwKXzmlsbkMec g+4RZvGRYOmVa3NPeSo5QTxQWHTJGqbq/qEHPuMM0FAc3D5lxmBbkgMDCBnjQOnJGZl8/vD+jdnd8 GPK38jAdA3cGKtYAiNbw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pbfQu-005ApT-Fx; Mon, 13 Mar 2023 10:29:36 +0000 Received: from mx.sberdevices.ru ([45.89.227.171]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pbfMx-005AMe-NZ; Mon, 13 Mar 2023 10:25:34 +0000 Received: from s-lin-edge02.sberdevices.ru (localhost [127.0.0.1]) by mx.sberdevices.ru (Postfix) with ESMTP id 204C75FD0B; Mon, 13 Mar 2023 13:25:17 +0300 (MSK) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sberdevices.ru; s=mail; t=1678703117; bh=3oXZsLeafS38+qYJFdTL8leUTox2P7WbbzgFUBRnCNg=; h=Date:From:To:Subject:Message-ID:MIME-Version:Content-Type; b=Qv/6hWdUh6jbEDRyIaWb0tKazL9ceDy5A4eBl9oL1x15fhKp0lC3vw3j324sOYQ0v 6xUgWl2C/Qt2YbkdjVoKgbGd8evAqrEUN4qI8MXoluGDowAAJbyREitrFmUd5mtcP1 Vb86myzYsKE7owVQq6dkJXyTvbxG1zJ52VDRSB4VRjGeQ/uqHS/+sQ5ESTa78y7EP5 B/RmhZOkv8c8x5AFQSp2KlHC2db1nH+lwfJQzSwThjC3v79A9Iy1D8skAuOD9cdziT abV2qOGPZiflje6hBIFK+HijGFq3u1tLoSiv4KrTqWT0dVjrx8rkpIUQEnf47NMx+u cMvfkYXcMB4wQ== Received: from S-MS-EXCH01.sberdevices.ru (S-MS-EXCH01.sberdevices.ru [172.16.1.4]) by mx.sberdevices.ru (Postfix) with ESMTP; Mon, 13 Mar 2023 13:25:16 +0300 (MSK) Date: Mon, 13 Mar 2023 13:25:16 +0300 From: Dmitry Rokosov To: Jerome Brunet CC: , , , , , , , , , , , , , , Subject: Re: [PATCH v9 2/5] clk: meson: a1: add Amlogic A1 PLL clock controller driver Message-ID: <20230313102516.grkj4jhkke2w7blm@CAB-WSD-L081021> References: <20230301183759.16163-1-ddrokosov@sberdevices.ru> <20230301183759.16163-3-ddrokosov@sberdevices.ru> <1jr0u2azfi.fsf@starbuckisacylon.baylibre.com> <20230306200549.7iuedbl27ejfhf6b@CAB-WSD-L081021> <1jlek60zun.fsf@starbuckisacylon.baylibre.com> <20230309182857.a2fzotcejueio23w@CAB-WSD-L081021> <1j5yb50zxz.fsf@starbuckisacylon.baylibre.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1j5yb50zxz.fsf@starbuckisacylon.baylibre.com> User-Agent: NeoMutt/20220415 X-Originating-IP: [172.16.1.6] X-ClientProxiedBy: S-MS-EXCH01.sberdevices.ru (172.16.1.4) To S-MS-EXCH01.sberdevices.ru (172.16.1.4) X-KSMG-Rule-ID: 4 X-KSMG-Message-Action: clean X-KSMG-AntiSpam-Status: not scanned, disabled by settings X-KSMG-AntiSpam-Interceptor-Info: not scanned X-KSMG-AntiPhishing: not scanned, disabled by settings X-KSMG-AntiVirus: Kaspersky Secure Mail Gateway, version 1.1.2.30, bases: 2023/03/13 06:38:00 #20941627 X-KSMG-AntiVirus-Status: Clean, skipped X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230313_032532_342477_F13ADCAA X-CRM114-Status: GOOD ( 18.38 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Mar 13, 2023 at 10:18:02AM +0100, Jerome Brunet wrote: > > On Thu 09 Mar 2023 at 21:28, Dmitry Rokosov wrote: > > >> >> > >> >> This last poke should not bits otherwise handled by parms. > >> >> This is a rate init in disguise. > >> >> > >> > > >> > I believe, you are talking about hifi_pll clk_regmap conflicts with > >> > hifi_init_regs. The above init sequence shouldn't affect pll regmap setup, > >> > it doesn't touch them (we assume that default bit values are all zero): > >> > > >> > .en = { > >> > .reg_off = ANACTRL_HIFIPLL_CTRL0, > >> > .shift = 28, > >> > .width = 1, > >> > }, > >> > // init_value = 0x01f18440 > >> > // en_mask = 0x10000000 > >> > > >> > .m = { > >> > .reg_off = ANACTRL_HIFIPLL_CTRL0, > >> > .shift = 0, > >> > .width = 8, > >> > }, > >> > // init_value = 0x01f18440 > >> > // m_mask = 0x0000000f > >> > >> mask is 0xff with width 8 > >> > > > > Ah, you're right. Anyway, I think this is just init value and it's okay > > to set it during initialization and rewrite after in parameter > > propagation stage. > > > > ... But the magic pokes are there only to initialize the unmanaged part > of the clock regs. I'd like it to be clear and stay that way. > > So please, clear the managed fields from the initial poke table. I've double checked hifi_pll clk. In the my current configuration no any clks inherited from it. Therefore its 'enable_count' equals to 0. And of course in the such situation the rate must be zeroed as well. It means you are right at all. I'll remove pre_sel and fbkdiv hifi_pll pre-setup in the next version. Thank you for hunted down! -- Thank you, Dmitry _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel