From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1C84DC61DA4 for ; Mon, 13 Mar 2023 16:14:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:CC:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=lsOQ0h4KHJ7sojq1/G3keNRv8kyX4ak3GwUtoVECANo=; b=UE36/c0Yr/spby Pjrvz1xdJUwse/ek+6Rssby/KX7eplmHXSBPhuFQ4gZGpUOoP5WzGhLOm2ijAVjfZDT5hNGCiadLC A/PW4BCyFG2dyUrLwGTD2W4UJpcERSWLxVdAmPxQQT44QayWrm0rSaWupmKO19TYmY+KXZuxXmJ9C TYlT+InU+zLu/H+nHDsg6UJ7Ywc8vEYWwPnlaIWi7k8MxIbJ/YLm3OfC4mjZn2GiKoTTYSNIMsFoq SSCJdNKNOfp92LfFvGEzMFk/vnommZi0kUEvZT7Ubl/sFlDIiGluLqFUIdTaRZZ96iUkFrQTOHecA XS2MAwsjaKELLHJXLI0Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pbkny-006fZ4-Fe; Mon, 13 Mar 2023 16:13:47 +0000 Received: from lelv0142.ext.ti.com ([198.47.23.249]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pbkb9-006ZyO-0o for linux-arm-kernel@lists.infradead.org; Mon, 13 Mar 2023 16:00:32 +0000 Received: from lelv0265.itg.ti.com ([10.180.67.224]) by lelv0142.ext.ti.com (8.15.2/8.15.2) with ESMTP id 32DG0Jnj063002; Mon, 13 Mar 2023 11:00:19 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1678723219; bh=+iXu+QwUaS/FNlboJGJIEUHApVIyYjVUJPVX3JIXH+I=; h=Date:From:To:CC:Subject:References:In-Reply-To; b=SlmsOiYPM7TBUkWXBYj9KpuxFJ8bQ334o1X1Ka/N8fK+AHcwELu4TtBzU+4A7c5Si w2ENVwGW+8uJhAbdVWLH4j3MozR4/LRzSp1Q3TZrqdh+rlxPgfUG8pKji6Tvp3Hi66 TXJ/NofbP89DLpPz+qMWKlxAA/KtOvmrHcxsQv48= Received: from DLEE111.ent.ti.com (dlee111.ent.ti.com [157.170.170.22]) by lelv0265.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 32DG0Jj7009948 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Mon, 13 Mar 2023 11:00:19 -0500 Received: from DLEE112.ent.ti.com (157.170.170.23) by DLEE111.ent.ti.com (157.170.170.22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.16; Mon, 13 Mar 2023 11:00:19 -0500 Received: from lelv0327.itg.ti.com (10.180.67.183) by DLEE112.ent.ti.com (157.170.170.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.16 via Frontend Transport; Mon, 13 Mar 2023 11:00:19 -0500 Received: from localhost (ileaxei01-snat.itg.ti.com [10.180.69.5]) by lelv0327.itg.ti.com (8.15.2/8.15.2) with ESMTP id 32DG0JXb040911; Mon, 13 Mar 2023 11:00:19 -0500 Date: Mon, 13 Mar 2023 11:00:19 -0500 From: Nishanth Menon To: Krzysztof Kozlowski CC: Sekhar Nori , Linus Walleij , Krzysztof Kozlowski , Rob Herring , Paolo Abeni , Jakub Kicinski , Eric Dumazet , "David S. Miller" , , , , , , Tero Kristo , Vignesh Raghavendra Subject: Re: [PATCH 2/2] dt-bindings: pinctrl: Move k3.h to arch Message-ID: <20230313160019.vask6atfs6qwphml@twerp> References: <20230311131325.9750-1-nm@ti.com> <20230311131325.9750-3-nm@ti.com> <71c7feff-4189-f12f-7353-bce41a61119d@linaro.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <71c7feff-4189-f12f-7353-bce41a61119d@linaro.org> X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230313_090031_208126_80B13523 X-CRM114-Status: GOOD ( 21.46 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 16:46-20230311, Krzysztof Kozlowski wrote: > On 11/03/2023 14:13, Nishanth Menon wrote: > > Move the k3 pinctrl definition to arch dts folder. > > > > While at this, fixup MAINTAINERS and header guard macro to better > > reflect the changes. > > > > Suggested-by: Krzysztof Kozlowski > > Suggested-by: Linus Walleij > > Link: https://lore.kernel.org/all/c4d53e9c-dac0-8ccc-dc86-faada324beba@linaro.org/ > > Signed-off-by: Nishanth Menon > > --- > > > > There is no specific case I can think of at the moment to create a > > pinctrl.dtsi for the SoCs.. So, unlike other SoCs, I had not done that > > in the series, if folks have a better opinion about this, please let us > > discuss. > > > > MAINTAINERS | 1 - > > arch/arm64/boot/dts/ti/k3-am62.dtsi | 3 ++- > > arch/arm64/boot/dts/ti/k3-am62a.dtsi | 3 ++- > > arch/arm64/boot/dts/ti/k3-am64.dtsi | 3 ++- > > arch/arm64/boot/dts/ti/k3-am65.dtsi | 3 ++- > > arch/arm64/boot/dts/ti/k3-j7200.dtsi | 3 ++- > > arch/arm64/boot/dts/ti/k3-j721e.dtsi | 3 ++- > > arch/arm64/boot/dts/ti/k3-j721s2.dtsi | 3 ++- > > arch/arm64/boot/dts/ti/k3-j784s4.dtsi | 3 ++- > > .../pinctrl/k3.h => arch/arm64/boot/dts/ti/k3-pinctrl.h | 6 +++--- > > Bindings are separate from other changes (also DTS). Split the patches. > > (...) > > > / { > > model = "Texas Instruments K3 J784S4 SoC"; > > compatible = "ti,j784s4"; > > diff --git a/include/dt-bindings/pinctrl/k3.h b/arch/arm64/boot/dts/ti/k3-pinctrl.h > > similarity index 94% > > rename from include/dt-bindings/pinctrl/k3.h > > rename to arch/arm64/boot/dts/ti/k3-pinctrl.h > > index 469bd29651db..6004e0967ec5 100644 > > --- a/include/dt-bindings/pinctrl/k3.h > > +++ b/arch/arm64/boot/dts/ti/k3-pinctrl.h > > Dropping this file is going to break existing code and I would say is > also a break of the ABI. You need to keep the header for at least one > cycle, you can add there a warning for coming deprecation. > > See for example: > https://lore.kernel.org/all/20220605160508.134075-5-krzysztof.kozlowski@linaro.org/ Makes complete sense. Thanks. will follow the lead and redo the series. -- Regards, Nishanth Menon Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel