From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4FE2BC61DA4 for ; Mon, 13 Mar 2023 19:39:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=sHeiy01nAXvhsnggCOtwHQF3VGC9HMPt+6CvezSh6ds=; b=icJEnAw8+Lf9uM Q11KODGcq4zHnliLgOGuxIKS0/hA1MC8V1BGfwDLDfOXxbexdxoDskf/Lqx9QVBrHYsZzCL2h1Yb2 TT5qLn6P6OjnUhM3VXKFJtKWpA43V384yIBgMfzzuwrE98TzVzwZG/30ubfRnGWcGZarx3wg/zEz5 CO6J4NihwfiD9GSZSKc1dVc8Yx0et2ylhhu055rzg6Fo16sGblZudWonMueXI6bN03nrsuakCpVyP XlyX/lIwI72rdsyYyWgBrwK/zonieNozm17H7iiMHIauGLO0J2KEGbphi6KYSIgCR/dBpVnCXtvkT e5lazSOlEKCgyiDfIqaw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pbo0T-007YQA-DV; Mon, 13 Mar 2023 19:38:53 +0000 Received: from mail-pl1-x635.google.com ([2607:f8b0:4864:20::635]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pbo0P-007YPb-Vq for linux-arm-kernel@lists.infradead.org; Mon, 13 Mar 2023 19:38:51 +0000 Received: by mail-pl1-x635.google.com with SMTP id p6so14238583plf.0 for ; Mon, 13 Mar 2023 12:38:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1678736327; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=IVO7PEi2yUALQReAQnVtBqU4m2MDeMLRMQcMWB2PiI0=; b=W5VAFVxT5KsRqtiz+5GE7fVAr/3byifsHIfF9hGkKl3m+4e/iWNinGUjiJQQcBURGm BtpuoYi09J19BbcCwIARjSdPz2HTN1qUjuTiRpNlVt4j+jLtGIqF4ZNmzHXUoDw4Mw9o Qjwf6fysHrAypYip+fUNdluusbd7ljMX7V+2sUtt+0IZ8A5Q34KdTzzXzf9fjkDxOzB6 ssgcKvdkq5QiNdsuh0sHIrguPigPq412RiDUBZdC+iJ/qpxCWgvQ2lfTTmnk2u3C5c0i VJgvHUqXb0e3iKMU3aP4QVI5Jj2xZOWk/OzillHCFcQdFIXlD9h/SJo2uTGskA1/abnL KPFg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678736327; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=IVO7PEi2yUALQReAQnVtBqU4m2MDeMLRMQcMWB2PiI0=; b=l/JaJ3uL46VokjiRJ9KOfqgPj83m9PIBUxaGNXhXsU5InruzQ83Jv3ABUXesTCzmJs jvtHlfMHrRj4YrmCxHdblYLKAKQ6DkITPMNwbOF6zpIjYSRext1YB6AmYNuSrYbrfEHP 7DcH8izhBH8efk53dix075zgzx40lWXPeVCl1ySjtughRYFv+hQijUFAjBumzDmBPf8q yi8suF0NTmlqt3q7ECny1WAl7o3C/7U17Bsd+aNqFPt8iDTQMppLv+h/8AYlL0t2qsyE bKREdTd76Mp0xR+Ikw2PzsfvnGcld+DcqdkjJnMf15XHAYzXk0GO9+/JHCleY39OTLBB lJIw== X-Gm-Message-State: AO0yUKUIeNhlbtBpkelPizRIqY6JO68fgl4IcyYrQM6+B9/CJoH9y8kR pR9sHrLuiWIHNYkCZd11Xm1LSg== X-Google-Smtp-Source: AK7set9qmdjM6JLXUsmVRUYr4chTrnyzUEowNxp6Tf8dv829z/ENOfvRbqn26nHGslbpU+eDnL2l9Q== X-Received: by 2002:a05:6a20:734c:b0:bf:40b:2db with SMTP id v12-20020a056a20734c00b000bf040b02dbmr43679619pzc.22.1678736327521; Mon, 13 Mar 2023 12:38:47 -0700 (PDT) Received: from p14s ([2604:3d09:148c:c800:2c47:cef8:f9d7:c7e1]) by smtp.gmail.com with ESMTPSA id i11-20020aa78d8b000000b005ded4825201sm100214pfr.112.2023.03.13.12.38.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 Mar 2023 12:38:47 -0700 (PDT) Date: Mon, 13 Mar 2023 13:38:44 -0600 From: Mathieu Poirier To: Tanmay Shah Cc: michal.simek@amd.com, andersson@kernel.org, jaswinder.singh@linaro.org, ben.levinsky@amd.com, shubhrajyoti.datta@amd.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-remoteproc@vger.kernel.org Subject: Re: [PATCH v5 1/5] mailbox: zynqmp: fix counts of child nodes Message-ID: <20230313193844.GA2071975@p14s> References: <20230311012407.1292118-1-tanmay.shah@amd.com> <20230311012407.1292118-2-tanmay.shah@amd.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230311012407.1292118-2-tanmay.shah@amd.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230313_123850_071223_E8414D67 X-CRM114-Status: GOOD ( 20.73 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Mar 10, 2023 at 05:24:04PM -0800, Tanmay Shah wrote: > If child mailbox node status is disabled it causes > crash in interrupt handler. Fix this by assigning > only available child node during driver probe. > > Fixes: 4981b82ba2ff ("mailbox: ZynqMP IPI mailbox controller") > Signed-off-by: Tanmay Shah > --- > > Changes in v5: > - mailbox node count should not be 0 for driver to probe > > drivers/mailbox/zynqmp-ipi-mailbox.c | 7 ++++++- > 1 file changed, 6 insertions(+), 1 deletion(-) > > diff --git a/drivers/mailbox/zynqmp-ipi-mailbox.c b/drivers/mailbox/zynqmp-ipi-mailbox.c > index a4c8d23c76e2..ae47fbac38d2 100644 > --- a/drivers/mailbox/zynqmp-ipi-mailbox.c > +++ b/drivers/mailbox/zynqmp-ipi-mailbox.c > @@ -634,7 +634,12 @@ static int zynqmp_ipi_probe(struct platform_device *pdev) > struct zynqmp_ipi_mbox *mbox; > int num_mboxes, ret = -EINVAL; > > - num_mboxes = of_get_child_count(np); > + num_mboxes = of_get_available_child_count(np); > + if (num_mboxes == 0) { > + dev_err(dev, "mailbox nodes not available\n"); > + return -EINVAL; > + } > + This patchset looks good now. I'll queue it once I get an ack from Michal. Thanks, Mathieu > pdata = devm_kzalloc(dev, struct_size(pdata, ipi_mboxes, num_mboxes), > GFP_KERNEL); > if (!pdata) > -- > 2.25.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel