From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 14FCBC61DA4 for ; Tue, 14 Mar 2023 01:19:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=P5TQ3oBRgYx0o2kPrBAcNdZnbHfoKtuxdWw+n9rqXMc=; b=IM3W8JVA6Qb3Ty AWTDIbJIFAp+18jt2TXKz1qgmULlElV9NlCfDCVUuRlvNxoulA0RyiIpSRYpzCQilzyemy3vXFf5y o5NM/sbzXuSx42owFE3tqFzPptwY3QLMxpBYgWhTfEHcnyDqvTImBVBRGsPdMVjBBVS/ITzdYrT4H cWDLBdqvfqN63picHLdhM4TLZQ4XTmIntcnAlYR6WEVXEaVEZXI1+7s9CjchW/eQZyNWF5M06X+pW 3amTdOWd2Xrn1Ez5MbyAM5Yh0+/m9WZhX2DZsNkAyaJqslNl7qYYz0itnay70CRsqYH+PUpkZzunl Cr0sZ8YWVr1Ho/tMt2eQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pbtJM-008XDu-Qo; Tue, 14 Mar 2023 01:18:44 +0000 Received: from ams.source.kernel.org ([2604:1380:4601:e00::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pbtJD-008XDW-NQ for linux-arm-kernel@lists.infradead.org; Tue, 14 Mar 2023 01:18:37 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 8CD7AB81642; Tue, 14 Mar 2023 01:18:32 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 96661C433EF; Tue, 14 Mar 2023 01:18:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1678756711; bh=KLf/FUDnFAKt1b8cInxL4tc7SQPgD86Zsjy4duwD4hk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ZXM15SCBZENIO48uv3gXoIbNlCUanfUy3hBKrtJT31ae1R7SNfMKe69nK2GNMscFJ RfKJBRp1xH7riXfVeH8sl7uDxEGxihRKYs3rMtNDBJlQpcKyJ/cBtGwIInLVfc6Gcc wGBEvrYCChyFptmnSX77R9Zy1qRCDbQGgQbrRV22+3YW5IYPcv1uRRZR3rPmzSmeyI 67DngttA0zm9bwV/OsgYRyPm58cv1ZtO21wc43TBmkQNr3DXEDTOvcYPk2oRUyLnwC cmaK3iBBwul1fROAP8TjS4KTxIe57/QqrTpAgdnHoEAuvTChtrbT9RFnFX1jE3hLth x6i4eEX8VhmEQ== Date: Tue, 14 Mar 2023 09:18:25 +0800 From: Shawn Guo To: Ivan Bornyakov Cc: linux-imx@nxp.com, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH] bus: imx-weim: fix branch condition evaluates to a garbage value Message-ID: <20230314011825.GZ143566@dragon> References: <20230217135950.19469-1-i.bornyakov@metrotek.ru> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230217135950.19469-1-i.bornyakov@metrotek.ru> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230313_181835_929650_2357907D X-CRM114-Status: GOOD ( 11.72 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Feb 17, 2023 at 04:59:50PM +0300, Ivan Bornyakov wrote: > If bus type is other than imx50_weim_devtype and have no child devices, > variable 'ret' in function weim_parse_dt() will not be initialized, but > will be used as branch condition and return value. Fix this by > initializing 'ret' with 0. > > This was discovered with help of clang-analyzer, but the situation is > quite possible in real life. > > Signed-off-by: Ivan Bornyakov > Cc: stable@vger.kernel.org Applied with Fixes tag below. Let me know if it's incorrect. Fixes: 52c47b63412b ("bus: imx-weim: improve error handling upon child probe-failure") Shawn _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel