From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E43BBC6FD19 for ; Tue, 14 Mar 2023 01:37:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=pmn/A5PriLD1HUgLihrFcawZRbjtXvFTttfEgINetN8=; b=du6NEUjDTWcCPj 90sAOKD68tAwg/PMTtMWraj0PKUM0K3apQMOE24dEb5LPMDKwAlEjyCodj+zdBufeDi2Mu5eP0Mkj JP2iTQmz4XzGOMoTYLLD8FtZ0Mu5yqPdYvv0HIOM6etPqEu5fDUMRzuKKPXYO82jRISN98op/gG3P j7paKC1ENZZg1KmRxNlw1JX/8By/YL3BAhgkRM1MtzTfZ529/vhzYeg2oUUPnedbEn6al48meW72F aUE/OGybyQtb5xT6oxp2pewps1iBS2tAXxPVIT34rhg/7W9KPYIQOTXTJ8UVxOe6MoFJLif4pz9U/ 4U7tohdK/njCK5y9uX4w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pbtZu-008ZfB-Nh; Tue, 14 Mar 2023 01:35:50 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pbtZq-008Zdm-US for linux-arm-kernel@lists.infradead.org; Tue, 14 Mar 2023 01:35:48 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id E440C614A6; Tue, 14 Mar 2023 01:35:45 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id BFF61C433EF; Tue, 14 Mar 2023 01:35:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1678757745; bh=ajascUjSBJkC6YidStXTpH1e4W+hUu+o0Jx76v8V6C4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=se0ogZ702sRMgoXN/Xp2mZuLXhrBCP8O0BpHdtrKz58h7aAnYI5hrRaXuWnhVggql pfZEEs2IhUeQbs2FfloML3EJIhLjaPDKnvEhojstu+SyBINEVMug/VGzohtrgIplQK 6MJ5j5taAHQZKaDnUCE88AnjJeKOOkQT2jCUJ/VZ8qgdBxch6bRZVRWSjIOeRGwSOq VoT8Mz7qXxiRXnGTTV68ii0ux57Pkr/Kk7ooU5MVmXy58P3ncgskiiPCM7PAW5/aRw NIBlZGo5SsmKo0sKBaRU4xhdbQAL8TbvOVIUEBMx04n4b/Pv5rYsWHJgBIQnzFokeT wkI/dHZfKGjCw== Date: Tue, 14 Mar 2023 09:35:39 +0800 From: Shawn Guo To: Nick Alcock Cc: mcgrof@kernel.org, linux-modules@vger.kernel.org, linux-kernel@vger.kernel.org, Hitomi Hasegawa , Sascha Hauer , linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 14/24] kbuild, firmware: imx: remove MODULE_LICENSE in non-modules Message-ID: <20230314013539.GA143566@dragon> References: <20230217141059.392471-1-nick.alcock@oracle.com> <20230217141059.392471-15-nick.alcock@oracle.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230217141059.392471-15-nick.alcock@oracle.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230313_183547_035477_9837846F X-CRM114-Status: GOOD ( 13.90 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Feb 17, 2023 at 02:10:49PM +0000, Nick Alcock wrote: > Since commit 8b41fc4454e ("kbuild: create modules.builtin without > Makefile.modbuiltin or tristate.conf"), MODULE_LICENSE declarations > are used to identify modules. As a consequence, uses of the macro > in non-modules will cause modprobe to misidentify their containing > object file as a module when it is not (false positives), and modprobe > might succeed rather than failing with a suitable error message. > > So remove it in the files in this commit, none of which can be built as > modules. > > Signed-off-by: Nick Alcock > Suggested-by: Luis Chamberlain Should I apply it as a fix for 6.3-rc with Cc stable tag, or can it be a material for -next? Shawn _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel