* [PATCH 1/1] arm64: dts: imx93: Fix eqos properties
@ 2023-02-23 6:05 Alexander Stein
2023-02-24 1:46 ` Peng Fan
2023-03-14 2:48 ` Shawn Guo
0 siblings, 2 replies; 3+ messages in thread
From: Alexander Stein @ 2023-02-23 6:05 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Shawn Guo, Sascha Hauer,
Fabio Estevam, Clark Wang, Peng Fan, David S . Miller
Cc: Alexander Stein, Pengutronix Kernel Team, NXP Linux Team,
devicetree, linux-arm-kernel
'macirq' is supposed to be listed first. Also only 'snps,clk-csr' is
listed in the bindings while 'clk_csr' is only supported for legacy
reasons. See commit 83936ea8d8ad2 ("net: stmmac: add a parse for new
property 'snps,clk-csr'")
Fixes: 1f4263ea6a4b ("arm64: dts: imx93: add eqos support")
Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
---
arch/arm64/boot/dts/freescale/imx93.dtsi | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/arch/arm64/boot/dts/freescale/imx93.dtsi b/arch/arm64/boot/dts/freescale/imx93.dtsi
index 4c70089d419f2..13ea4bfb97c68 100644
--- a/arch/arm64/boot/dts/freescale/imx93.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx93.dtsi
@@ -666,9 +666,9 @@ usdhc2: mmc@42860000 {
eqos: ethernet@428a0000 {
compatible = "nxp,imx93-dwmac-eqos", "snps,dwmac-5.10a";
reg = <0x428a0000 0x10000>;
- interrupts = <GIC_SPI 183 IRQ_TYPE_LEVEL_HIGH>,
- <GIC_SPI 184 IRQ_TYPE_LEVEL_HIGH>;
- interrupt-names = "eth_wake_irq", "macirq";
+ interrupts = <GIC_SPI 184 IRQ_TYPE_LEVEL_HIGH>,
+ <GIC_SPI 183 IRQ_TYPE_LEVEL_HIGH>;
+ interrupt-names = "macirq", "eth_wake_irq";
clocks = <&clk IMX93_CLK_ENET_QOS_GATE>,
<&clk IMX93_CLK_ENET_QOS_GATE>,
<&clk IMX93_CLK_ENET_TIMER2>,
@@ -681,7 +681,7 @@ eqos: ethernet@428a0000 {
<&clk IMX93_CLK_SYS_PLL_PFD0_DIV2>;
assigned-clock-rates = <100000000>, <250000000>;
intf_mode = <&wakeupmix_gpr 0x28>;
- clk_csr = <0>;
+ snps,clk-csr = <0>;
status = "disabled";
};
--
2.34.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 3+ messages in thread* RE: [PATCH 1/1] arm64: dts: imx93: Fix eqos properties
2023-02-23 6:05 [PATCH 1/1] arm64: dts: imx93: Fix eqos properties Alexander Stein
@ 2023-02-24 1:46 ` Peng Fan
2023-03-14 2:48 ` Shawn Guo
1 sibling, 0 replies; 3+ messages in thread
From: Peng Fan @ 2023-02-24 1:46 UTC (permalink / raw)
To: Alexander Stein, Rob Herring, Krzysztof Kozlowski, Shawn Guo,
Sascha Hauer, Fabio Estevam, Clark Wang, David S . Miller
Cc: Pengutronix Kernel Team, dl-linux-imx, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
> Subject: [PATCH 1/1] arm64: dts: imx93: Fix eqos properties
>
> 'macirq' is supposed to be listed first. Also only 'snps,clk-csr' is listed in the
> bindings while 'clk_csr' is only supported for legacy reasons. See commit
> 83936ea8d8ad2 ("net: stmmac: add a parse for new property 'snps,clk-csr'")
>
> Fixes: 1f4263ea6a4b ("arm64: dts: imx93: add eqos support")
> Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
[Peng Fan]
Reviewed-by: Peng Fan <peng.fan@nxp.com>
> ---
> arch/arm64/boot/dts/freescale/imx93.dtsi | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/freescale/imx93.dtsi
> b/arch/arm64/boot/dts/freescale/imx93.dtsi
> index 4c70089d419f2..13ea4bfb97c68 100644
> --- a/arch/arm64/boot/dts/freescale/imx93.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx93.dtsi
> @@ -666,9 +666,9 @@ usdhc2: mmc@42860000 {
> eqos: ethernet@428a0000 {
> compatible = "nxp,imx93-dwmac-eqos",
> "snps,dwmac-5.10a";
> reg = <0x428a0000 0x10000>;
> - interrupts = <GIC_SPI 183
> IRQ_TYPE_LEVEL_HIGH>,
> - <GIC_SPI 184
> IRQ_TYPE_LEVEL_HIGH>;
> - interrupt-names = "eth_wake_irq", "macirq";
> + interrupts = <GIC_SPI 184
> IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI 183
> IRQ_TYPE_LEVEL_HIGH>;
> + interrupt-names = "macirq", "eth_wake_irq";
> clocks = <&clk
> IMX93_CLK_ENET_QOS_GATE>,
> <&clk
> IMX93_CLK_ENET_QOS_GATE>,
> <&clk IMX93_CLK_ENET_TIMER2>,
> @@ -681,7 +681,7 @@ eqos: ethernet@428a0000 {
> <&clk
> IMX93_CLK_SYS_PLL_PFD0_DIV2>;
> assigned-clock-rates = <100000000>,
> <250000000>;
> intf_mode = <&wakeupmix_gpr 0x28>;
> - clk_csr = <0>;
> + snps,clk-csr = <0>;
> status = "disabled";
> };
>
> --
> 2.34.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH 1/1] arm64: dts: imx93: Fix eqos properties
2023-02-23 6:05 [PATCH 1/1] arm64: dts: imx93: Fix eqos properties Alexander Stein
2023-02-24 1:46 ` Peng Fan
@ 2023-03-14 2:48 ` Shawn Guo
1 sibling, 0 replies; 3+ messages in thread
From: Shawn Guo @ 2023-03-14 2:48 UTC (permalink / raw)
To: Alexander Stein
Cc: Rob Herring, Krzysztof Kozlowski, Sascha Hauer, Fabio Estevam,
Clark Wang, Peng Fan, David S . Miller, Pengutronix Kernel Team,
NXP Linux Team, devicetree, linux-arm-kernel
On Thu, Feb 23, 2023 at 07:05:43AM +0100, Alexander Stein wrote:
> 'macirq' is supposed to be listed first. Also only 'snps,clk-csr' is
> listed in the bindings while 'clk_csr' is only supported for legacy
> reasons. See commit 83936ea8d8ad2 ("net: stmmac: add a parse for new
> property 'snps,clk-csr'")
>
> Fixes: 1f4263ea6a4b ("arm64: dts: imx93: add eqos support")
> Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
Applied, thanks!
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-03-14 2:49 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-02-23 6:05 [PATCH 1/1] arm64: dts: imx93: Fix eqos properties Alexander Stein
2023-02-24 1:46 ` Peng Fan
2023-03-14 2:48 ` Shawn Guo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).