From: Shawn Guo <shawnguo@kernel.org>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: Russell King <linux@armlinux.org.uk>,
Sascha Hauer <s.hauer@pengutronix.de>,
Arnd Bergmann <arnd@arndb.de>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>,
NXP Linux Team <linux-imx@nxp.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 4/8] ARM: imx: mmdc: Convert to platform remove callback returning void
Date: Tue, 14 Mar 2023 14:52:33 +0800 [thread overview]
Message-ID: <20230314065233.GV143566@dragon> (raw)
In-Reply-To: <20230308100012.2539189-5-u.kleine-koenig@pengutronix.de>
On Wed, Mar 08, 2023 at 11:00:08AM +0100, Uwe Kleine-König wrote:
> The .remove() callback for a platform driver returns an int which makes
> many driver authors wrongly assume it's possible to do error handling by
> returning an error code. However the value returned is (mostly) ignored
> and this typically results in resource leaks. To improve here there is a
> quest to make the remove callback return void. In the first step of this
> quest all drivers are converted to .remove_new() which already returns
> void.
>
> Trivially convert this driver from always returning zero in the remove
> callback to the void returning variant.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Acked-by: Shawn Guo <shawnguo@kernel.org>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-03-14 6:53 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-08 10:00 [PATCH 0/8] ARM: Convert to platform remove callback returning void Uwe Kleine-König
2023-03-08 10:00 ` [PATCH 1/8] ARM: locomo: " Uwe Kleine-König
2023-03-08 10:00 ` [PATCH 2/8] ARM: sa1111: " Uwe Kleine-König
2023-03-08 10:00 ` [PATCH 3/8] ARM: scoop: " Uwe Kleine-König
2023-03-08 10:00 ` [PATCH 4/8] ARM: imx: mmdc: " Uwe Kleine-König
2023-03-14 6:52 ` Shawn Guo [this message]
2023-03-08 10:00 ` [PATCH 5/8] ARM: omap1: omap-dma: " Uwe Kleine-König
2023-03-08 10:00 ` [PATCH 6/8] ARM: pxa: sharpsl_pm: " Uwe Kleine-König
2023-03-08 10:00 ` [PATCH 7/8] ARM: sa1100: jornada720_ssp: " Uwe Kleine-König
2023-03-08 10:00 ` [PATCH 8/8] ARM: sa1100: neponset: " Uwe Kleine-König
2023-03-08 15:06 ` [PATCH 0/8] ARM: " Arnd Bergmann
2023-03-08 16:01 ` Uwe Kleine-König
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230314065233.GV143566@dragon \
--to=shawnguo@kernel.org \
--cc=arnd@arndb.de \
--cc=festevam@gmail.com \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux@armlinux.org.uk \
--cc=s.hauer@pengutronix.de \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).