From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 776E0C6FD1F for ; Tue, 14 Mar 2023 06:53:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Y9pqo3lixQjX1cGJFDj9+i9//XEmZ3mrFgAG8P2QJvE=; b=3z5KhsrmqIO1XL q4Jg5NdBj1QlJHCoHefoFv4xjYc36c7N/EYhSRS0WveZfBeuIDqWJf5OTfC+OwiA4hFCKUMPgyKUC CiQaUOjUzZd9x5SuF9hDRqU35aI6JqP/4+S2yQLhp7IAKrrbo3EPLIdSWWP8PanLiIJEiqngtQijW wHKqFqb1dv0wISJn1WcrQK/OHMxkszJSxQdLLQzvuhpYDTuEptp+9NqroHPFvyNtLfXZVwAcZTzRk 1tSGwPFHD0ZSX6l2rD7BwvITXuM4a3AYognwQ/7z7anPlqqlpCLBXbl2y0e/eoXcRKTu25iUkbhCR M8vxuD9IsJczPjgx/6Aw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pbyWc-009G0l-3m; Tue, 14 Mar 2023 06:52:46 +0000 Received: from ams.source.kernel.org ([145.40.68.75]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pbyWY-009Fz6-Dt for linux-arm-kernel@lists.infradead.org; Tue, 14 Mar 2023 06:52:43 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id A7FC0B81887; Tue, 14 Mar 2023 06:52:40 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C54C7C433D2; Tue, 14 Mar 2023 06:52:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1678776759; bh=lirmI7R5XJe3agZz295saqXNhH83V378HuroPVkMweM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=EhwQ5y1PUdgJknXFq1+LL8LHfP3PyvYPQeEti56O03+9ynxX7fVGvL2TbAsIQUYct G2htNpgRXcug8vQ1QUfIsf0RlXpu5dpY03eFVwl5FgHwHQNNoEIptJvGUT1E+0MDde 7G7Wo/KVXA3H5zWOZc1KrBGKTXekLJ3/qK5cko0UnJOjqa+pgM9+a7w5gNKnQmr+2a wrxGB1tZQ0aR6RAVMn0MSXHrJl7BKusxJDiXdvWP8OXR/nvfHj+biFiwUxX4K5YAcB LDsh4x4TXkK/xIYEg2oUerAgPiiSOxYmY6JeXvljN9N+vyRq53mhxnLW26wZV+7j4g zHLQI9v4gxiIA== Date: Tue, 14 Mar 2023 14:52:33 +0800 From: Shawn Guo To: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= Cc: Russell King , Sascha Hauer , Arnd Bergmann , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 4/8] ARM: imx: mmdc: Convert to platform remove callback returning void Message-ID: <20230314065233.GV143566@dragon> References: <20230308100012.2539189-1-u.kleine-koenig@pengutronix.de> <20230308100012.2539189-5-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230308100012.2539189-5-u.kleine-koenig@pengutronix.de> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230313_235242_635884_D0BDE5C0 X-CRM114-Status: GOOD ( 14.44 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Mar 08, 2023 at 11:00:08AM +0100, Uwe Kleine-K=F6nig wrote: > The .remove() callback for a platform driver returns an int which makes > many driver authors wrongly assume it's possible to do error handling by > returning an error code. However the value returned is (mostly) ignored > and this typically results in resource leaks. To improve here there is a > quest to make the remove callback return void. In the first step of this > quest all drivers are converted to .remove_new() which already returns > void. > = > Trivially convert this driver from always returning zero in the remove > callback to the void returning variant. > = > Signed-off-by: Uwe Kleine-K=F6nig Acked-by: Shawn Guo _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel