From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 649F2C6FD1C for ; Tue, 14 Mar 2023 08:18:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=uUbzKNLEbUCczE+kQsaeBWwDDq6TMjhtMyulTyQg8Ks=; b=k8YsMvQGuUk5ZE 74vmpuRwMmfyY0Hyv+uCYV1IU1PbuInM/QyNFLWD7uaNaiJ1PbAVjWVUNlU0+MGe9yx5tTuR7PjI9 ZZixwyQ9Zt7ok7XGW0Laty/rkQBMLe5GwQcLBTux1hvDvMFxFEkz/u0jCNUliK9HIeWVKEOjua35j QOU9tqMK74ZRBSq7lbin+Qr/SdURcn2NPAyZHjkhb3uSvGt1ODUq6y1K/5igOJRvJQkWPfTUuJJY1 Z2ohRa6z2wrkWTGEQ3OSklgg77dD22UMSOxe35WdKQwYORdUcS4Ot0Rx9MMsLfT2dsT+V4kAgcpKG 96TNDMkUL4rFW6wgIM4w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pbzqs-009SqV-Pf; Tue, 14 Mar 2023 08:17:46 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pbzqp-009Sph-OJ for linux-arm-kernel@lists.infradead.org; Tue, 14 Mar 2023 08:17:45 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 4FD6761647; Tue, 14 Mar 2023 08:17:43 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9B1CBC433D2; Tue, 14 Mar 2023 08:17:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1678781862; bh=Xi2794rdLlEIsfm3cg4qF1ROjcOdCNpLbzUABC/gRQc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=UzbwfGVIDSHLMLIkX+l3tn4KjEkfQkXi6RDxwh7iaaeUsJOfJiLLVQmX4LMhJuLJZ +JaJlQS4iVuNHM/IsYnVjDiGD/Ytj7WdhN1hn7kFjZvmMg2FtzYAUrnk9CoQ77dVTi 32gDeMtT7faxnhvv269AeWv+rjEyCBwW0PzQw+j/tlTPoecrX4Oa4x8pPBcXtDlbnm p2V4mHJhLBvcccYkVARBeMO63/cffNLPhLEfIbey24Lpa/FH3/HSnFJYsUFTeS+Ffy YC/1OObK8qetusWHAkga/TO6zbTxwaHO8Yz0betHqlsa4xQUfiMaMbk44ecMEHJm3S +3sMPf9vXoAWQ== Date: Tue, 14 Mar 2023 16:17:35 +0800 From: Shawn Guo To: Francesco Dolcini Cc: Krzysztof Kozlowski , Philippe Schenker , devicetree@vger.kernel.org, Sascha Hauer , NXP Linux Team , Krzysztof Kozlowski , Rob Herring , Pengutronix Kernel Team , Frank Rowand , linux-arm-kernel@lists.infradead.org, Fabio Estevam , Philippe Schenker , linux-kernel@vger.kernel.org, Marcel Ziswiler Subject: Re: [PATCH v1 03/25] arm64: dts: colibri-imx8x: Sort properties Message-ID: <20230314081735.GE143566@dragon> References: <20230308125300.58244-1-dev@pschenker.ch> <20230308125300.58244-4-dev@pschenker.ch> <9d213504-d457-21a6-d467-41d8783d53d3@linaro.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230314_011743_896612_73085ACA X-CRM114-Status: GOOD ( 23.40 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Mar 09, 2023 at 01:19:13PM +0100, Francesco Dolcini wrote: > Hello Krzysztof, first thanks for your review. > > Let's try to get some clarity on this with the help of Shawn. > > On Wed, Mar 08, 2023 at 01:57:38PM +0100, Krzysztof Kozlowski wrote: > > On 08/03/2023 13:52, Philippe Schenker wrote: > > > From: Philippe Schenker > > > > > > Sort properties according to the following order and inside these > > > alphabetically. > > > > > > 1. compatible > > > 2. reg > > > 3. standard properties > > > 4. specific properties > > > 5. status > > > > Is this approved coding style for IMX DTS? > > I 100% understand your concerns here. > > With that said let me try to briefly explain the reasoning here, in > various threads we were asked in the past to move node around based on > some not 100% defined rules [0][1]. > > On Sun, 2023-01-29 at 11:19 +0800, Shawn Guo wrote: > >> +&usbotg1 { > >> + adp-disable; > >> + ci-disable-lpm; > >> + hnp-disable; > >> + over-current-active-low; > >> + pinctrl-names = "default"; > >> + pinctrl-0 = <&pinctrl_usbotg1>; > > > >We generally want to put such generic properties before device specific > >ones. > > In addition to that we find convenient to have properties sorted > alphabetically when no other rule is available, it just prevents any > kind of discussion, minimize merge conflicts and make comparing files > easier. > > I also agree that the difference between "generic"/"specific" is fuzzy > at best. > > With all that said ... > > Shawn: What should we do? We can of course avoid any kind of re-ordering > from now on. We are practically asking for 1, 2 and 5 for i.MX DTS files, but pretty flexible for the rest. > I am fine to be very pragmatic here, no-reordering on existing DTS > files, newly added DTS files we discuss whatever is the reasoning of the > reviewer/maintainer on a case-by-case basis. Sounds good to me! While I personally like your ordering, I do not want it to churn the existing DTS files. I'm happy to take this patch as a special case though :) Shawn _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel