From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 02E2DC6FD1D for ; Tue, 14 Mar 2023 12:41:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ZSCVaHBfUR8f6zMNV15SOjozvT++752rx8vDJ1IFhfU=; b=mnnI6UiGIeNa7t dB5KZYiMRnpm5ExcHTDomAWxv6UXzfKtkQ/P4ooLPsHiGx87J5UvHF9zpza+vesXCVQ++J9wRzr5X RkJ2Gh1kw8i3GOMEh3mQvcaDU6IefVlbtVlRKLtNCeTQCaztSaVFO6MjhhPaN1m9+amIF8GmkVy8y qNxngQFWJnEQkangKDcHe38a+QUdfIk2qrfOMMEDK4BQKK42e3K6ruhBPbgDeGNUzcHMREl9ULtU5 T2K9z+vSfrwYHwELPxD+l5hSyXQbJ6Ke0kk6O9C67r2JxTxB9fSTHtK9AwK4tFplg6tdyo2fwak7k AYHQUSQxR38WDHp4PV1Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pc3xQ-00A8eY-0W; Tue, 14 Mar 2023 12:40:48 +0000 Received: from mout.kundenserver.de ([212.227.17.13]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pc3xD-00A8Zj-25 for linux-arm-kernel@lists.infradead.org; Tue, 14 Mar 2023 12:40:37 +0000 Received: from maxwell.localdomain ([109.43.51.107]) by mrelayeu.kundenserver.de (mreue109 [213.165.67.113]) with ESMTPSA (Nemesis) id 1MHG4c-1pgRfb1IOW-00DIcr; Tue, 14 Mar 2023 13:39:43 +0100 From: Jochen Henneberg To: netdev@vger.kernel.org Cc: Jochen Henneberg , Giuseppe Cavallaro , Alexandre Torgue , Jose Abreu , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Maxime Coquelin , Ong Boon Leong , linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH net 1/2] net: stmmac: Premature loop termination check was ignored Date: Tue, 14 Mar 2023 13:37:58 +0100 Message-Id: <20230314123759.132521-2-jh@henneberg-systemdesign.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230314123759.132521-1-jh@henneberg-systemdesign.com> References: <20230314123759.132521-1-jh@henneberg-systemdesign.com> MIME-Version: 1.0 X-Provags-ID: V03:K1:9odOXzVTEt6nET6RlhuEMzaEAU5NfNUV6HWs/su++s+L/5aTzSd 2U+FGb12WmVeADxMSgj4AoUS69olA6Y9Kqi+kaAIlGBdcnOr8aIQTWSm35+rNDTBjRDVDho eNHW/U3NzgInsz4ivdVqmoAVGimlcvOV08kcXmzmia9EAJJvXkgpnldAn3iCMiK2y9zzQ9o B/b58yd8mdmj1Sk9DPXaQ== UI-OutboundReport: notjunk:1;M01:P0:/fOfKsvUD+g=;sxxvpWoq14GpQddXVAEZgM/jJdG yHR9rVIVtYcQhfVxQeryIFNxqE2xa3liPaImv5X7DGDyJovJMlKl2PUktAIYCOAl1JdUiuRZg jCE+lvKP4cY2gf7CEPskk3rw1bEtGEl75ftWcrz6ErR3E1sYEPSccN0fwkazy9o36+IifYr/C zagZvmnDAYwGdpl2+9HtVFKx+xhfBRFM5ILGh+dtXSehJ4limnGf/mqUyU3WU9nynsSQQK5iR zOn3ljotP68kUNn1oTelWNEoyPZr9ZtY9zGCihw1YG60oAjxF6AuZqDbzB+vVkxBw6SuH22EF /vbU3FDdSMeTqRc248H+KSsFX4zj7TijNro2Jc/4D1Gv/QZze/CpuEjA6fizZDPv/nRNitOJw ClbGx6tJvw24Ni59fV/V662YQbogO4CUfvc73t3ZtzsEbcJqBAZndyNJCQ46QBZDUIku7rWov lks4mV+uFXuy7yfov+pGKToFbq0ATarscX5yru3ZHNwekFd6tCxvljOzgR4vDt4H9qH80aKcG OzcB1JUzp4Tnj9Id34dLcGi3s/wjUqvwgbmkK79tQIDzoe01FlFu6VnJfBmnSzSR/vCWVOYDf 0MOldfeWjXyTw45HxZjkAxUo+bxXpinW5NjIM2tZPvVvbB1kTrx0YZhn4MZ/j1m5jeuVjyedg osVLy171KIFp3SyPzFqZy2YTP0+8iFyyCQ+kfGGwrGH6LWYymaJ/OjzuA2apBGl2DPw/anWCM wi1pOr75AiL X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230314_054035_967038_3117487B X-CRM114-Status: GOOD ( 12.54 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The premature loop termination check makes sense only in case of the jump to read_again where the count may have been updated. But read_again did not include the check. Fixes: ec222003bd94 ("net: stmmac: Prepare to add Split Header support") Signed-off-by: Jochen Henneberg --- drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c index e4902a7bb61e..ea51c7c93101 100644 --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c @@ -5221,10 +5221,10 @@ static int stmmac_rx(struct stmmac_priv *priv, int limit, u32 queue) len = 0; } +read_again: if (count >= limit) break; -read_again: buf1_len = 0; buf2_len = 0; entry = next_entry; -- 2.39.2 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel