From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EAAC3C6FD1D for ; Tue, 14 Mar 2023 12:41:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=u3d1OSnGs1ZlYVG9AyyqLt6eUJkaddmggyAv8untLQc=; b=fsxm+ag8URAbZD TINIEDPLsPmFhW32Vs/RCJ5Hut/ktaZ61SMxDmUlnH1pIb0PW7Nen3WZxEsrmhHXfMGyQqmmdNYV3 xuJJXtluuOsPrW+QYpTsfAp8fbRpDm2usQa5uwUCCvhNOpi7Co5X6k2aOUn9EfIGWO3kcYaw/Se5Y 56lXgVsXAdbmpHZUCMsoKXyWfToKxat6FbcAgro2GOafrxeYbFqa+iUQXwBWxTSAebTY7oHwNVB3o InLXJHA8gzv1M/xVIgkWQMlYuJwiA0nEa+jHYljyc6eX1Z3IfcE8egeQZNIwiMkf2b0dLgkVduxAM wkl4/DR+FcWCQDV9wXAQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pc3xH-00A8cX-1n; Tue, 14 Mar 2023 12:40:39 +0000 Received: from mout.kundenserver.de ([217.72.192.74]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pc3xC-00A8ZN-2E for linux-arm-kernel@lists.infradead.org; Tue, 14 Mar 2023 12:40:36 +0000 Received: from maxwell.localdomain ([109.43.51.107]) by mrelayeu.kundenserver.de (mreue109 [213.165.67.113]) with ESMTPSA (Nemesis) id 1MkYkC-1qO0UO1e0M-00m3Lr; Tue, 14 Mar 2023 13:39:46 +0100 From: Jochen Henneberg To: netdev@vger.kernel.org Cc: Jochen Henneberg , Giuseppe Cavallaro , Alexandre Torgue , Jose Abreu , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Maxime Coquelin , Ong Boon Leong , linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH net 2/2] net: stmmac: Premature loop termination check was ignored Date: Tue, 14 Mar 2023 13:37:59 +0100 Message-Id: <20230314123759.132521-3-jh@henneberg-systemdesign.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230314123759.132521-1-jh@henneberg-systemdesign.com> References: <20230314123759.132521-1-jh@henneberg-systemdesign.com> MIME-Version: 1.0 X-Provags-ID: V03:K1:l1W1LjxOLRyxarFh4d7uXBRK1UHreknpzqZxegOM2jODzpg/YnC 9we6QMFFMqqrvH21mCENI6V0GewVL31+FUjESlQG/GgCnknsFYczuD3QVxAowBFgssxKeKC BvP40Y6ELDXd3GZ27r2KYfUuPWtMiyJOvLPWLgjjxUnr2hsS6L6ExUn8v0AUlKJ591P77sJ 29IArAxiVdxnm/YEFKiCg== UI-OutboundReport: notjunk:1;M01:P0:93Q4pkTBlcY=;L5+hOIGa4JQQYKT/ivORpETbJOe xeRgGVFuV+HZv/dkjU1Gn5zajrzC/NSAczXyiKaGKF3dXytSyT2NHBuijTXe5DrPwOvbPhtCn ICG8jUlOsPn2Q4/TKm4qT4cMBijg72sg20InodyDEBX8c8tOJbzo/nM0X77ZPPr76kmFHdSJg pcQEB005uHvucrHD/FdsRu6pijUCgehsy61z1lrRFNm4tlVA1luN7TxZPPOdxR3wy4wYEf0IL Vnvl2TiaBQwRWGkQjOrS1sCeeAb8CMoNgj6cHDjitRc/YIfljqaF/+UfjsbRWRWVg3OS8TNlt 6AbH+5lAQ4dyh6PIBab6Ii6HZMs9m74jwC4qR37Yp9gV/on2QdNoXLST3mWgH1u588N5OKZbg M4+M8P49WbGom3FbZNaG9085ykEj4tpiS3Y/fpiRj2rRXA+aZWnCh7rbb/6lcTv9cKPRQCWau hYO6kBO24PGlEI1qZI9OoN7j3+qLqmN67+Bd5lDQT8oAVY5WEyHQxThBnYwOkYDoFaz95E6d1 lHK0F/wlaZKQNWy3y3GUpihlQyDGX3NpoRfWsixcbjvzsSFd2KX48IS7QqSbTXqeSiI97xIDj tt2bTUmPbcALTvigORsXdGXK0AWc21IPyudnHxhsCSuaN2FXfquLvLWovdQMPGuUX5DsIjETC 5pcZzGIFJnNEc4XYVW5EASaf2SswvjSCV6YMWMuE2g== X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230314_054035_052420_0C08FBE2 X-CRM114-Status: GOOD ( 12.25 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The premature loop termination check makes sense only in case of the jump to read_again where the count may have been updated. But read_again did not include the check. Fixes: bba2556efad6 ("net: stmmac: Enable RX via AF_XDP zero-copy") Signed-off-by: Jochen Henneberg --- drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c index ea51c7c93101..4886668a54c5 100644 --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c @@ -5031,10 +5031,10 @@ static int stmmac_rx_zc(struct stmmac_priv *priv, int limit, u32 queue) len = 0; } +read_again: if (count >= limit) break; -read_again: buf1_len = 0; entry = next_entry; buf = &rx_q->buf_pool[entry]; -- 2.39.2 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel