From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 447A6C6FD1D for ; Wed, 15 Mar 2023 00:45:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=wPL50kB3CNK/5WrU6FuJdtYkVgN13okMxjJnG08x9Ew=; b=mf+z/dFFpg5vkf xkbsHUsA7eKlKnbR4Q7QxikkfncH1+aKaBQoirYmhagm6AGtE9G0YL2i34uDoHUctph+P0qJ1DF1p /AMQecG5ppkJSmJhPp/JcHi/cW6f7zwvXKuqse0e+WaHC9K873zN18E5cnG34UgS5ydDp/GhXT1AI aou3xqF2X/vLe+DncXpW66rNcTl3OFKUS0cO26+26VUfQtY/qtdDpvtwU/5Qb9WHLpMgMHKM9DqRf CdKNiROywEJQ/Mrmfd054u30rCUVFXgci+/S4TqLrSCk6vaIdo+xyw3XhZUjBib2jsr6xP9scPuTa aSq4olwD6wlPc6wUQnNQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pcFGL-00Bsce-0E; Wed, 15 Mar 2023 00:45:05 +0000 Received: from mail-ed1-x52c.google.com ([2a00:1450:4864:20::52c]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pcFGH-00BsbG-28 for linux-arm-kernel@lists.infradead.org; Wed, 15 Mar 2023 00:45:02 +0000 Received: by mail-ed1-x52c.google.com with SMTP id y4so39817063edo.2 for ; Tue, 14 Mar 2023 17:44:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1678841096; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=j78xQ/dlyO2w00ZN1x42fWcOhlv4pH4hNYDeYpQy2n8=; b=leeP0sVej5vmyF9D2t/OAvWprJsKpLWHi48jtA0CBilduZsy148k3ehRl0W0S/G1sR wYR1UYvjb4TZl4M5cGXbO5/hIq/q0rXmxjAb8l+A7nzyXTdD9a0g5y776coHgnL6jMIk GWlVbPpd1V+uTpAslb0Ydxx40mucbWxbm6b6S+E79ZajNZyNbAj8Z40oLptQnoL8EviZ NRbepbHvRknUgvYnCYh3LUHzaRzdiFjQE7uLSssDadZqLYJt1huoEHw+/KlGEsdc/asp hZDocnmwfmxGyXEKNFDPLUH3O72RWqxxNhDbaDaufj5fEuNzzRf6Q+OmRWC8W7nTmSrF Lq+g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678841096; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=j78xQ/dlyO2w00ZN1x42fWcOhlv4pH4hNYDeYpQy2n8=; b=eIagLbu8pNyhy+SJMK7mAf3OThpPXGkPd0XjiSEOcLwZB8YQ/+qlytmRKRBlOQ9NPY lo2qIuSkPEDhaXAgKZpyUdYcw6NLfgc70D5iJkncYySw42jA7mMz5h5hwdubJFQck69V q/I3jg5gb3wa1oA3yKE0mBszQI+hxNOfhhT0QJUay22O1jtQnf533ZtgAiOEFwqL76p9 QCSyQReA3iZLxRNn21XlWuqZwvjiGqpu4z9kDlEJZntd9X33DighdTrfHODOdOdjsGZn e6qHmea3NMwOaY7Zrw5ucaDpW5DWrq+/LT8Z7UhZnB2CoqSKDzEq3ffXHZvyiEtjUy03 SUWA== X-Gm-Message-State: AO0yUKW2LNEctDSKxgm1p1u8xSmfO6gteTw2hDCz5EMpnZDkKQ6D1cTp Vwpb4l/+QTOaO/Tjs28Gl3k= X-Google-Smtp-Source: AK7set8pcWkJwyFz0NAnNAYiFWllDpt6MlFJbmaxFj6EunAKetqApp966inRNzHkXw26kbdMNkUhFQ== X-Received: by 2002:a17:906:1714:b0:870:d9a:9ebb with SMTP id c20-20020a170906171400b008700d9a9ebbmr4595398eje.38.1678841096165; Tue, 14 Mar 2023 17:44:56 -0700 (PDT) Received: from skbuf ([188.27.184.189]) by smtp.gmail.com with ESMTPSA id td10-20020a1709078c8a00b009256a5c3b2dsm1785112ejc.90.2023.03.14.17.44.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Mar 2023 17:44:55 -0700 (PDT) Date: Wed, 15 Mar 2023 02:44:53 +0200 From: Vladimir Oltean To: Christian Marangi Cc: Andrew Lunn , Florian Fainelli , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Heiner Kallweit , Russell King , Gregory Clement , Sebastian Hesselbarth , Andy Gross , Bjorn Andersson , Konrad Dybcio , John Crispin , netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, Lee Jones , linux-leds@vger.kernel.org Subject: Re: [net-next PATCH v3 06/14] net: phy: marvell: Add software control of the LEDs Message-ID: <20230315004453.sxzqccyozvsfp374@skbuf> References: <20230314101516.20427-1-ansuelsmth@gmail.com> <20230314101516.20427-1-ansuelsmth@gmail.com> <20230314101516.20427-7-ansuelsmth@gmail.com> <20230314101516.20427-7-ansuelsmth@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230314101516.20427-7-ansuelsmth@gmail.com> <20230314101516.20427-7-ansuelsmth@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230314_174501_704079_EC0A0FBC X-CRM114-Status: GOOD ( 15.02 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Mar 14, 2023 at 11:15:08AM +0100, Christian Marangi wrote: > From: Andrew Lunn > > Add a brightness function, so the LEDs can be controlled from > software using the standard Linux LED infrastructure. > > Signed-off-by: Andrew Lunn > Signed-off-by: Christian Marangi > --- > +static int m88e1318_led_brightness_set(struct phy_device *phydev, > + u32 index, enum led_brightness value) > +{ > + u16 reg; > + > + reg = phy_read_paged(phydev, MII_MARVELL_LED_PAGE, > + MII_88E1318S_PHY_LED_FUNC); > + if (reg < 0) > + return reg; "reg" is declared as unsigned, so it's surely positive. > + > + switch (index) { > + case 0: > + case 1: > + case 2: > + reg &= ~(0xf << (4 * index)); > + if (value == LED_OFF) > + reg |= MII_88E1318S_PHY_LED_FUNC_OFF << (4 * index); > + else > + reg |= MII_88E1318S_PHY_LED_FUNC_ON << (4 * index); > + break; > + default: > + return -EINVAL; > + } > + > + return phy_write_paged(phydev, MII_MARVELL_LED_PAGE, > + MII_88E1318S_PHY_LED_FUNC, reg); > +} _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel