From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 509D0C6FD1F for ; Wed, 15 Mar 2023 00:47:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=+8e/WuBClHxC9Ynrcnrokv89evHJttZGiGLNKz9lYSE=; b=2G8vgC3jmGvMDr CVOUSbeT7nCCuzgPbzfi/ZmTDEy2SaPT/FTVxOFjuGeBAM6cZk78Ah6PZU35444AyKTQmExgL8/ZW 0H3WF9D22rKdW7FCSd6rSiOypkPjUWl4VDjOGSXlnSWQxSyrekqxnSRSfeDGaTLVnHkzdmFe9cMHS pqwflM4j5DEEOiqppr6ksE+zMTdN8nHknrMnwuQ/RVFYEYElfZg6kshTnnRjEbK/a80hE1q+8RsJq Fbxl2hyGp8yQfHHNq43yyGZewqb23k9JUV8uow4u1hhkpK6iS7DjT8pmZeRgGqUAP941heUx8U9/F G/ahDrq6uJmnUHIywFPg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pcFHm-00Bst1-0j; Wed, 15 Mar 2023 00:46:34 +0000 Received: from mail-ed1-x52b.google.com ([2a00:1450:4864:20::52b]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pcFHi-00Bspr-1e for linux-arm-kernel@lists.infradead.org; Wed, 15 Mar 2023 00:46:31 +0000 Received: by mail-ed1-x52b.google.com with SMTP id x3so69215870edb.10 for ; Tue, 14 Mar 2023 17:46:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1678841185; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=BTzP8PV/k7hn5ySvaalQhoPOaZQQSzTzzd7nJ9iaxqs=; b=KpPDrUhRoylDbLnSBva8ESLP9jKTFaue2Z8EjTuFS5I8DZ20F9M69EDyyuoAuH0eQw P0FaahJiMpTcI1chW5eH8YcFd12iprXRM/mgYeVtfNvUARkZvy062mxtMQFbfjUrj5zN iqZh3y7XAjhHd/MTRvROd97+j57o0hBuT7B8oL6YfUaNaD+/TGUF9n/NZ9EW+1zXnnd9 a5H1oTFQtNr7lFq58mv7Vx7y3T5pP20ZSNLz6VbZmPM796KIK/g6kydHbTUCL3tj2jnx t/3o8WfeaOJXURu9peymrU+uBbzCoQtcL2NcMbm9e5ds1O03RG8az984KXKSVfSBHQTq FRrA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678841185; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=BTzP8PV/k7hn5ySvaalQhoPOaZQQSzTzzd7nJ9iaxqs=; b=31jwp3CV1bZv9hAC0ZOiu6QY1dQRAUI3ZIAxTOMT15ecpkJPB0KmZ87K7g6aISN6KD hz7HovwznOcZecT45dSAix0r6ji+7ss2Z6KFPXLk/7K1IzzCxskWItQMPveskjhlJrde PnFkpX+wkYJukO9YPr/RZwMNkgLeS7zC9oJJMwO8YKxdiMOTgbHnF9Bx4K5TQsep1W1w pd5BQaH1tZA+DRSxezdKocwTyzykgxc21GO5fx9R2ls1q6AesoTY2xAwgYKZl03h+8k6 Dn6EM2otPZr+QgAxfEpeZqinEw8Xmy7D+HHridvdB8BY6VIrFxeYRAOzKFo2Fihknbpx iZ+Q== X-Gm-Message-State: AO0yUKWGu2pUkhDRiGNt6byP0s3g6mjVW0jm94V5iwSd2EcFJbI/P0xC WPppDfsTTibTwluhBcu9T9A= X-Google-Smtp-Source: AK7set+Op+PdChW2bk4sM1l0mYPTUdl+5ud49p2zpol3gxJxfY0SezHaCawg78gKlMcKWMF6l9WeaQ== X-Received: by 2002:a17:906:a450:b0:88d:9cf8:2dbb with SMTP id cb16-20020a170906a45000b0088d9cf82dbbmr4656921ejb.12.1678841184986; Tue, 14 Mar 2023 17:46:24 -0700 (PDT) Received: from skbuf ([188.27.184.189]) by smtp.gmail.com with ESMTPSA id bt20-20020a0564020a5400b004fb419921e2sm1658450edb.57.2023.03.14.17.46.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Mar 2023 17:46:24 -0700 (PDT) Date: Wed, 15 Mar 2023 02:46:22 +0200 From: Vladimir Oltean To: Christian Marangi Cc: Andrew Lunn , Florian Fainelli , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Heiner Kallweit , Russell King , Gregory Clement , Sebastian Hesselbarth , Andy Gross , Bjorn Andersson , Konrad Dybcio , John Crispin , netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, Lee Jones , linux-leds@vger.kernel.org Subject: Re: [net-next PATCH v3 08/14] net: phy: marvell: Implement led_blink_set() Message-ID: <20230315004622.yxhxrslblgxylubd@skbuf> References: <20230314101516.20427-1-ansuelsmth@gmail.com> <20230314101516.20427-9-ansuelsmth@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230314101516.20427-9-ansuelsmth@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230314_174630_555397_9072EBA3 X-CRM114-Status: GOOD ( 13.21 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Mar 14, 2023 at 11:15:10AM +0100, Christian Marangi wrote: > +static int m88e1318_led_blink_set(struct phy_device *phydev, u32 index, > + unsigned long *delay_on, > + unsigned long *delay_off) > +{ > + u16 reg; Same problem here. > + > + reg = phy_read_paged(phydev, MII_MARVELL_LED_PAGE, > + MII_88E1318S_PHY_LED_FUNC); > + if (reg < 0) > + return reg; > + > + switch (index) { > + case 0: > + case 1: > + case 2: > + reg &= ~(0xf << (4 * index)); > + reg |= MII_88E1318S_PHY_LED_FUNC_BLINK << (4 * index); > + /* Reset default is 84ms */ > + *delay_on = 84 / 2; > + *delay_off = 84 / 2; > + break; > + default: > + return -EINVAL; > + } > + > + return phy_write_paged(phydev, MII_MARVELL_LED_PAGE, > + MII_88E1318S_PHY_LED_FUNC, reg); > +} _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel