Re: [net-next PATCH v3 06/14] net: phy: marvell: Add software control of the LEDs

Andrew Lunn
2023-03-15T01:49:26Z

> > + u16 reg;
> > +
> > + reg = phy_read_paged(phydev, MII_MARVELL_LED_PAGE,
> > + MII_88E1318S_PHY_LED_FUNC);
> > + if (reg < 0)
> > + return reg;
>
> "reg" is declared as unsigned, so it's surely positive.

Gerr. That is one of the most common errors in phylib. I should know
better :-(

Thanks
Andrew