From: Manivannan Sadhasivam <mani@kernel.org>
To: Yang Li <yang.lee@linux.alibaba.com>
Cc: ulf.hansson@linaro.org, afaerber@suse.de,
linux-mmc@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-actions@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH -next] mmc: owl-mmc: Use devm_platform_get_and_ioremap_resource()
Date: Wed, 15 Mar 2023 13:11:16 +0530 [thread overview]
Message-ID: <20230315074116.GB25575@thinkpad> (raw)
In-Reply-To: <20230315073912.GA25575@thinkpad>
On Wed, Mar 15, 2023 at 01:09:26PM +0530, Manivannan Sadhasivam wrote:
> On Wed, Mar 15, 2023 at 01:41:13PM +0800, Yang Li wrote:
> > According to commit 890cc39a8799 ("drivers: provide
> > devm_platform_get_and_ioremap_resource()"), convert
> > platform_get_resource(), devm_ioremap_resource() to a single
> > call to devm_platform_get_and_ioremap_resource(), as this is exactly
> > what this function does.
> >
> > Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
> > ---
> > drivers/mmc/host/owl-mmc.c | 3 +--
> > 1 file changed, 1 insertion(+), 2 deletions(-)
> >
> > diff --git a/drivers/mmc/host/owl-mmc.c b/drivers/mmc/host/owl-mmc.c
> > index 3dc143b03939..6f9d31a886ba 100644
> > --- a/drivers/mmc/host/owl-mmc.c
> > +++ b/drivers/mmc/host/owl-mmc.c
> > @@ -578,8 +578,7 @@ static int owl_mmc_probe(struct platform_device *pdev)
> > owl_host->mmc = mmc;
> > spin_lock_init(&owl_host->lock);
> >
> > - res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
>
> You forgot to remove the local variable which is now unused.
>
Oops, no my bad. It is being used...
Reviewed-by: Manivannan Sadhasivam <mani@kernel.org>
Thanks,
Mani
> Thanks,
> Mani
>
> > - owl_host->base = devm_ioremap_resource(&pdev->dev, res);
> > + owl_host->base = devm_platform_get_and_ioremap_resource(pdev, 0, &res);
> > if (IS_ERR(owl_host->base)) {
> > ret = PTR_ERR(owl_host->base);
> > goto err_free_host;
> > --
> > 2.20.1.7.g153144c
> >
>
> --
> மணிவண்ணன் சதாசிவம்
--
மணிவண்ணன் சதாசிவம்
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-03-15 7:42 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-15 5:41 [PATCH -next] mmc: owl-mmc: Use devm_platform_get_and_ioremap_resource() Yang Li
2023-03-15 7:39 ` Manivannan Sadhasivam
2023-03-15 7:41 ` Manivannan Sadhasivam [this message]
2023-03-23 12:12 ` Ulf Hansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230315074116.GB25575@thinkpad \
--to=mani@kernel.org \
--cc=afaerber@suse.de \
--cc=linux-actions@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=ulf.hansson@linaro.org \
--cc=yang.lee@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).