* [PATCH -next] mmc: owl-mmc: Use devm_platform_get_and_ioremap_resource()
@ 2023-03-15 5:41 Yang Li
2023-03-15 7:39 ` Manivannan Sadhasivam
2023-03-23 12:12 ` Ulf Hansson
0 siblings, 2 replies; 4+ messages in thread
From: Yang Li @ 2023-03-15 5:41 UTC (permalink / raw)
To: ulf.hansson
Cc: afaerber, mani, linux-mmc, linux-arm-kernel, linux-actions,
linux-kernel, Yang Li
According to commit 890cc39a8799 ("drivers: provide
devm_platform_get_and_ioremap_resource()"), convert
platform_get_resource(), devm_ioremap_resource() to a single
call to devm_platform_get_and_ioremap_resource(), as this is exactly
what this function does.
Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
---
drivers/mmc/host/owl-mmc.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/mmc/host/owl-mmc.c b/drivers/mmc/host/owl-mmc.c
index 3dc143b03939..6f9d31a886ba 100644
--- a/drivers/mmc/host/owl-mmc.c
+++ b/drivers/mmc/host/owl-mmc.c
@@ -578,8 +578,7 @@ static int owl_mmc_probe(struct platform_device *pdev)
owl_host->mmc = mmc;
spin_lock_init(&owl_host->lock);
- res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
- owl_host->base = devm_ioremap_resource(&pdev->dev, res);
+ owl_host->base = devm_platform_get_and_ioremap_resource(pdev, 0, &res);
if (IS_ERR(owl_host->base)) {
ret = PTR_ERR(owl_host->base);
goto err_free_host;
--
2.20.1.7.g153144c
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH -next] mmc: owl-mmc: Use devm_platform_get_and_ioremap_resource()
2023-03-15 5:41 [PATCH -next] mmc: owl-mmc: Use devm_platform_get_and_ioremap_resource() Yang Li
@ 2023-03-15 7:39 ` Manivannan Sadhasivam
2023-03-15 7:41 ` Manivannan Sadhasivam
2023-03-23 12:12 ` Ulf Hansson
1 sibling, 1 reply; 4+ messages in thread
From: Manivannan Sadhasivam @ 2023-03-15 7:39 UTC (permalink / raw)
To: Yang Li
Cc: ulf.hansson, afaerber, linux-mmc, linux-arm-kernel, linux-actions,
linux-kernel
On Wed, Mar 15, 2023 at 01:41:13PM +0800, Yang Li wrote:
> According to commit 890cc39a8799 ("drivers: provide
> devm_platform_get_and_ioremap_resource()"), convert
> platform_get_resource(), devm_ioremap_resource() to a single
> call to devm_platform_get_and_ioremap_resource(), as this is exactly
> what this function does.
>
> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
> ---
> drivers/mmc/host/owl-mmc.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/mmc/host/owl-mmc.c b/drivers/mmc/host/owl-mmc.c
> index 3dc143b03939..6f9d31a886ba 100644
> --- a/drivers/mmc/host/owl-mmc.c
> +++ b/drivers/mmc/host/owl-mmc.c
> @@ -578,8 +578,7 @@ static int owl_mmc_probe(struct platform_device *pdev)
> owl_host->mmc = mmc;
> spin_lock_init(&owl_host->lock);
>
> - res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
You forgot to remove the local variable which is now unused.
Thanks,
Mani
> - owl_host->base = devm_ioremap_resource(&pdev->dev, res);
> + owl_host->base = devm_platform_get_and_ioremap_resource(pdev, 0, &res);
> if (IS_ERR(owl_host->base)) {
> ret = PTR_ERR(owl_host->base);
> goto err_free_host;
> --
> 2.20.1.7.g153144c
>
--
மணிவண்ணன் சதாசிவம்
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH -next] mmc: owl-mmc: Use devm_platform_get_and_ioremap_resource()
2023-03-15 7:39 ` Manivannan Sadhasivam
@ 2023-03-15 7:41 ` Manivannan Sadhasivam
0 siblings, 0 replies; 4+ messages in thread
From: Manivannan Sadhasivam @ 2023-03-15 7:41 UTC (permalink / raw)
To: Yang Li
Cc: ulf.hansson, afaerber, linux-mmc, linux-arm-kernel, linux-actions,
linux-kernel
On Wed, Mar 15, 2023 at 01:09:26PM +0530, Manivannan Sadhasivam wrote:
> On Wed, Mar 15, 2023 at 01:41:13PM +0800, Yang Li wrote:
> > According to commit 890cc39a8799 ("drivers: provide
> > devm_platform_get_and_ioremap_resource()"), convert
> > platform_get_resource(), devm_ioremap_resource() to a single
> > call to devm_platform_get_and_ioremap_resource(), as this is exactly
> > what this function does.
> >
> > Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
> > ---
> > drivers/mmc/host/owl-mmc.c | 3 +--
> > 1 file changed, 1 insertion(+), 2 deletions(-)
> >
> > diff --git a/drivers/mmc/host/owl-mmc.c b/drivers/mmc/host/owl-mmc.c
> > index 3dc143b03939..6f9d31a886ba 100644
> > --- a/drivers/mmc/host/owl-mmc.c
> > +++ b/drivers/mmc/host/owl-mmc.c
> > @@ -578,8 +578,7 @@ static int owl_mmc_probe(struct platform_device *pdev)
> > owl_host->mmc = mmc;
> > spin_lock_init(&owl_host->lock);
> >
> > - res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
>
> You forgot to remove the local variable which is now unused.
>
Oops, no my bad. It is being used...
Reviewed-by: Manivannan Sadhasivam <mani@kernel.org>
Thanks,
Mani
> Thanks,
> Mani
>
> > - owl_host->base = devm_ioremap_resource(&pdev->dev, res);
> > + owl_host->base = devm_platform_get_and_ioremap_resource(pdev, 0, &res);
> > if (IS_ERR(owl_host->base)) {
> > ret = PTR_ERR(owl_host->base);
> > goto err_free_host;
> > --
> > 2.20.1.7.g153144c
> >
>
> --
> மணிவண்ணன் சதாசிவம்
--
மணிவண்ணன் சதாசிவம்
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH -next] mmc: owl-mmc: Use devm_platform_get_and_ioremap_resource()
2023-03-15 5:41 [PATCH -next] mmc: owl-mmc: Use devm_platform_get_and_ioremap_resource() Yang Li
2023-03-15 7:39 ` Manivannan Sadhasivam
@ 2023-03-23 12:12 ` Ulf Hansson
1 sibling, 0 replies; 4+ messages in thread
From: Ulf Hansson @ 2023-03-23 12:12 UTC (permalink / raw)
To: Yang Li
Cc: afaerber, mani, linux-mmc, linux-arm-kernel, linux-actions,
linux-kernel
On Wed, 15 Mar 2023 at 06:41, Yang Li <yang.lee@linux.alibaba.com> wrote:
>
> According to commit 890cc39a8799 ("drivers: provide
> devm_platform_get_and_ioremap_resource()"), convert
> platform_get_resource(), devm_ioremap_resource() to a single
> call to devm_platform_get_and_ioremap_resource(), as this is exactly
> what this function does.
>
> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
Applied for next, thanks!
Kind regards
Uffe
> ---
> drivers/mmc/host/owl-mmc.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/mmc/host/owl-mmc.c b/drivers/mmc/host/owl-mmc.c
> index 3dc143b03939..6f9d31a886ba 100644
> --- a/drivers/mmc/host/owl-mmc.c
> +++ b/drivers/mmc/host/owl-mmc.c
> @@ -578,8 +578,7 @@ static int owl_mmc_probe(struct platform_device *pdev)
> owl_host->mmc = mmc;
> spin_lock_init(&owl_host->lock);
>
> - res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> - owl_host->base = devm_ioremap_resource(&pdev->dev, res);
> + owl_host->base = devm_platform_get_and_ioremap_resource(pdev, 0, &res);
> if (IS_ERR(owl_host->base)) {
> ret = PTR_ERR(owl_host->base);
> goto err_free_host;
> --
> 2.20.1.7.g153144c
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-03-23 12:14 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-03-15 5:41 [PATCH -next] mmc: owl-mmc: Use devm_platform_get_and_ioremap_resource() Yang Li
2023-03-15 7:39 ` Manivannan Sadhasivam
2023-03-15 7:41 ` Manivannan Sadhasivam
2023-03-23 12:12 ` Ulf Hansson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).