From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 746D3C6FD1D for ; Wed, 15 Mar 2023 22:08:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:Date:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=wgfGNpS6rkaJk8LaWj3BeCoOs08yvwabEY2SB7L3hnQ=; b=TC6fCrhpUj55H3 rpqHn3OYlua2LIIJeVl+OxvkaD95dNePLjbTP6mMLIglkXVjODGpb5QLLDuNDn+G5Y9sD0+4Gh+gv mQgdp0cKxrWsyXlFee9aSBuqA0Yc22eu9DleaUikjHCgKMqkb889oJttc1kP+TOWNFkUwNOwia/La cN0P72KxQTDyk4GDJABunfb71mAWiVcwpZ7fVAZ0T+OHvJp9NIp6FoYLL1MIzPflaohumoJ2I75XS ANDhW4UTvmFwnRVMIQIn8skfxtQOfLaoG87k9M7zuvm5AcEL5KSz26G9KiOgxDPHJxicrAjFG7klj L8Kp7f2eCYYGvc3wEvsw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pcZHU-00EXrs-2P; Wed, 15 Mar 2023 22:07:36 +0000 Received: from mail-pl1-x633.google.com ([2607:f8b0:4864:20::633]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pcZHR-00EXqu-1b for linux-arm-kernel@lists.infradead.org; Wed, 15 Mar 2023 22:07:34 +0000 Received: by mail-pl1-x633.google.com with SMTP id u5so21613471plq.7 for ; Wed, 15 Mar 2023 15:07:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1678918048; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:from:to:cc:subject:date:message-id:reply-to; bh=NRZfNvRJH2R9venvB1Ewk+3QqCpqEvBKToRomyaeMIY=; b=Jq8eXCLFPj7waxli1wSRcLqa0vHgD7q64CBtVK4S+LqvzH40rCjXl0GCtAh4uXDWHR xpYvMe7nZZc/LYtZmybJNU9mi4kPiLa+3kctOrpL1yRaRuMf0ZvPQ1QZ9ZTky7pG4kWW QN2g3xe5kNS1p6ocJPTkXQptlLPW90DCB6knTuJpm6PCOWIRypIIW8jJNJO3fivn/1H/ vvgt7C/oapqU+WyYshVz3vi51fnxp7xGk9yfnLnDSnVvDgnqYFSH7ryO5up9Rp89nObW u2T0QyE1nHS5O/o9PwxLHP4IdYnkahmZ4aywk3HvwalC645r1TVck/8UNf6GAcwnH5h0 VSOw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678918048; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=NRZfNvRJH2R9venvB1Ewk+3QqCpqEvBKToRomyaeMIY=; b=zbzAWuKHYyCBgTlbo5ZBLZwOWBKHbuFtMwu1nUmzvR8EVpCsemwT+kdU5Q1rWILijD H7pGeK1OO06co2Q8EDIRZ9zxF4BpGNzbR/gX/1RZrY+LbLRkzCC+/QPfFuJBGBIhSo3M Rgy2PnFxogD2dMjMR3T4a3XNRrXHsw04LgmX+Gu1mzahTRyCEoKUwrKi02R54GBjR19F O3ta5XUPgz7g74Vu+6MkRhJmv+hyyn1jzCIGsRPfoFkrGoZYr35XR4DMz0HiivY+tAf4 w9I+HLRHaSSUhQC1lJ+nQU0a1HZYRIZ+VfsLoVIytt4qhkuYiZ86qreW3sxAX/8KwecG z/Ug== X-Gm-Message-State: AO0yUKVzU9fUEbqqx2Dpy23ySCpIFb9Mlzia/H+/FE77mcMCBKPfMfbu EgfbO6XH5YJlBISIHkh4jUQ= X-Google-Smtp-Source: AK7set+t30uUNq2SziUU5pNyzzPIbKC3+13zl2U4XwREnFntqtYn1OSmt2jjdQd5zgMCvxKgpJ98xA== X-Received: by 2002:a17:90b:1bc4:b0:23b:bd09:7f0b with SMTP id oa4-20020a17090b1bc400b0023bbd097f0bmr1302332pjb.30.1678918047710; Wed, 15 Mar 2023 15:07:27 -0700 (PDT) Received: from kazuki-mac ([2400:4051:ea3:5910::789]) by smtp.gmail.com with ESMTPSA id a18-20020a63cd52000000b00502ea3898a7sm3864100pgj.31.2023.03.15.15.07.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Mar 2023 15:07:27 -0700 (PDT) From: Kazuki X-Google-Original-From: Kazuki Date: Thu, 16 Mar 2023 07:07:22 +0900 To: "Rafael J. Wysocki" Cc: linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Sudeep Holla , "Rafael J. Wysocki" , Daniel Lezcano , Lorenzo Pieralisi , Hector Martin , Sven Peter , Len Brown , Pavel Machek Subject: Re: [PATCH] PM: s2idle: Don't allow s2idle when cpuidle isn't supported Message-ID: <20230315220722.cyw4smvxlb5c5got@kazuki-mac> References: <20230214215003.70683-1-kazukih0205@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230315_150733_539044_1D22E416 X-CRM114-Status: GOOD ( 12.67 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Feb 21, 2023 at 04:40:01PM +0100, Rafael J. Wysocki wrote: > On Tue, Feb 14, 2023 at 11:04 PM Kazuki Hashimoto wrote: > > > > s2idle isn't supported on platforms that don't support cpuidle as of > > 31a3409065d1 ("cpuidle / sleep: Do sanity checks in cpuidle_enter_freeze() > > too"), so update the suspend framework to reflect this in order to avoid > > breakages. > Hello, apologies for the late reply. > Hmm. Doesn't the cpuidle_not_available() check in cpuidle_idle_call() > trigger then? > > The commit mentioned above hasn't changed that AFAICS. Yes it does, but there's nothing in enter_state() that's preventing the system from entering s2idle. Both the suspend and cpuidle subsystems need to be aware that the system is entering s2idle, otherwise it'll result in breakges. Thanks, Kazuki _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel